From 1a00681356909b7921270074e2569815e70f9283 Mon Sep 17 00:00:00 2001 From: Parnic Date: Mon, 25 Oct 2010 04:20:22 +0000 Subject: [PATCH] - hid the "rotate 90 degrees" option on cast bars and eclipse bars since it just doesn't work very well and looks bad. users keep reporting that these are broken when rotating and since i don't have a good fix, i'm disabling the feature for now --- IceBarElement.lua | 4 ++-- modules/CastBar.lua | 6 ++++++ modules/EclipseBar.lua | 6 ++++++ 3 files changed, 14 insertions(+), 2 deletions(-) diff --git a/IceBarElement.lua b/IceBarElement.lua index 51f13c2..c044e32 100644 --- a/IceBarElement.lua +++ b/IceBarElement.lua @@ -453,7 +453,7 @@ end values = IceHUD.validBarList, order = 30.08 } - +if not self.moduleSettings.shouldHideBarRotation then opts["barRotate"] = { type = 'toggle', @@ -475,7 +475,7 @@ end end, order = 30.09 } - +end opts["textSettings"] = { type = 'group', diff --git a/modules/CastBar.lua b/modules/CastBar.lua index d629d7b..0c21b62 100644 --- a/modules/CastBar.lua +++ b/modules/CastBar.lua @@ -34,6 +34,7 @@ function CastBar.prototype:GetDefaultSettings() settings["hideAnimationSettings"] = true settings["usesDogTagStrings"] = false settings["rangeColor"] = true + settings["shouldHideBarRotation"] = true return settings end @@ -294,6 +295,11 @@ end function CastBar.prototype:Enable(core) + if self.moduleSettings.rotateBar then + self.moduleSettings.rotateBar = false + self:ResetRotation() + end + CastBar.super.prototype.Enable(self, core) self:RegisterEvent("UNIT_ENTERED_VEHICLE", "EnteringVehicle") diff --git a/modules/EclipseBar.lua b/modules/EclipseBar.lua index 0e3b718..5104074 100644 --- a/modules/EclipseBar.lua +++ b/modules/EclipseBar.lua @@ -45,11 +45,17 @@ function EclipseBar.prototype:GetDefaultSettings() color = {r=1, g=0, b=0, a=1}, height = 6, } + defaults.shouldHideBarRotation = true return defaults end function EclipseBar.prototype:Enable(core) + if self.moduleSettings.rotateBar then + self.moduleSettings.rotateBar = false + self:ResetRotation() + end + EclipseBar.super.prototype.Enable(self, core) self:RegisterEvent("UPDATE_SHAPESHIFT_FORM", "UpdateShown")