From 383b7cae2f16a3105330cf5a2a5fea79ff15206b Mon Sep 17 00:00:00 2001 From: Parnic Date: Thu, 19 Jul 2018 22:18:05 -0500 Subject: [PATCH] Fixed DK Rune state not always matching actual state --- changelog.txt | 1 + modules/Runes.lua | 14 +++++--------- 2 files changed, 6 insertions(+), 9 deletions(-) diff --git a/changelog.txt b/changelog.txt index ebf401f..33f1386 100644 --- a/changelog.txt +++ b/changelog.txt @@ -1,5 +1,6 @@ v1.11.2: - Fixed Stagger bar to work in 8.0 +- Fixed DK Runes in graphical mode not always correctly showing runes on cooldown (curse ticket 238, thanks ithorazei!) v1.11.1: - Fixed error when playing as a Monk diff --git a/modules/Runes.lua b/modules/Runes.lua index 658981e..778461b 100644 --- a/modules/Runes.lua +++ b/modules/Runes.lua @@ -317,9 +317,7 @@ function Runes.prototype:ResetRuneAvailability(event) self:UpdateRunePower(event, i, not event) end - if not event then - self:Redraw() - end + self:Redraw() end -- simply shows/hides the foreground rune when it becomes usable/unusable. this allows the background transparent rune to show only @@ -338,9 +336,9 @@ function Runes.prototype:UpdateRunePower(event, rune, dontFlash) local lastState = self.lastRuneState[rune] self.lastRuneState[rune] = usable - if lastState == usable then - return - end +-- if lastState == usable then +-- return +-- end -- print("Runes.prototype:UpdateRunePower: rune="..rune.." usable="..(usable and "yes" or "no").." GetRuneType(rune)="..GetRuneType(rune)); @@ -354,7 +352,7 @@ function Runes.prototype:UpdateRunePower(event, rune, dontFlash) self.frame.graphical[rune]:SetAlpha(1) end - if not dontFlash then + if not dontFlash and lastState ~= usable then local fadeInfo={ mode = "IN", timeToFade = 0.25, @@ -378,8 +376,6 @@ function Runes.prototype:UpdateRunePower(event, rune, dontFlash) self.frame.graphical[rune]:SetAlpha(0.2) end end - - self:Redraw() end function Runes.prototype:GetNumRunesAvailable()