- converted most of the mod to ace3. the only ace2 remaining is AceEvent-2 (probably easy to get away from) and AceOO-2 (not so easy)

- the ace3 conversion also broke the dependence on Waterfall and gave a much better configuration screen through AceConfigDialog; plus Waterfall is very broken in Cataclysm and it's unclear whether anyone will bother to fix it or not
- fixed a bug with the custom CD bar when changing profiles where it would generate endless errors until a reloadui
- removed DewDrop library as it was no longer in use
- temporarily removed FuBar plugin as it doesn't work as a mixin with AceAddon-3. i will eventually be bringing this back in some form (before the next full release version)
- removed an unused 'about' button on the config page and some empty headers...not sure why they were ever there

modules/Runes.lua

@@ -48,7 +48,7 @@ function Runes.prototype:GetOptions()
 		get = function()
 			return self.moduleSettings.vpos
 		end,
-		set = function(v)
+		set = function(info, v)
 			self.moduleSettings.vpos = v
 			self:Redraw()
 		end,
@@ -68,7 +68,7 @@ function Runes.prototype:GetOptions()
 		get = function()
 			return self.moduleSettings.hpos
 		end,
-		set = function(v)
+		set = function(info, v)
 			self.moduleSettings.hpos = v
 			self:Redraw()
 		end,
@@ -88,7 +88,7 @@ function Runes.prototype:GetOptions()
 		get = function()
 			return self.moduleSettings.hideBlizz
 		end,
-		set = function(value)
+		set = function(info, value)
 			self.moduleSettings.hideBlizz = value
 			if (value) then
 				self:HideBlizz()
@@ -103,17 +103,17 @@ function Runes.prototype:GetOptions()
 	}
 
 	opts["displayMode"] = {
-		type = 'text',
+		type = 'select',
 		name = 'Rune orientation',
 		desc = 'Whether the runes should draw side-by-side or on top of one another',
-		get = function()
-			return self.moduleSettings.displayMode
+		get = function(info)
+			return IceHUD:GetSelectValue(info, self.moduleSettings.displayMode)
 		end,
-		set = function(v)
-			self.moduleSettings.displayMode = v
+		set = function(info, v)
+			self.moduleSettings.displayMode = info.option.values[v]
 			self:Redraw()
 		end,
-		validate = { "Horizontal", "Vertical" },
+		values = { "Horizontal", "Vertical" },
 		disabled = function()
 			return not self.moduleSettings.enabled
 		end,
@@ -121,62 +121,23 @@ function Runes.prototype:GetOptions()
 	}
 
 	opts["cooldownMode"] = {
-		type = 'text',
+		type = 'select',
 		name = 'Rune cooldown mode',
 		desc = 'Choose whether the runes use a cooldown-style wipe, simply an alpha fade to show availability or both.',
-		get = function()
-			return self.moduleSettings.cooldownMode
+		get = function(info)
+			return IceHUD:GetSelectValue(info, self.moduleSettings.cooldownMode)
 		end,
-		set = function(v)
-			self.moduleSettings.cooldownMode = v
+		set = function(info, v)
+			self.moduleSettings.cooldownMode = info.option.values[v]
 			self:Redraw()
 		end,
-		validate = { "Cooldown", "Alpha", "Both" },
+		values = { "Cooldown", "Alpha", "Both" },
 		disabled = function()
 			return not self.moduleSettings.enabled
 		end,
 		order = 36
 	}
--- todo: numeric mode isn't supported just yet...so these options are removed for now
---[[
-	opts["runeFontSize"] = {
-		type = "range",
-		name = "Runes Font Size",
-		desc = "Runes Font Size",
-		get = function()
-			return self.moduleSettings.runeFontSize
-		end,
-		set = function(v)
-			self.moduleSettings.runeFontSize = v
-			self:Redraw()
-		end,
-		min = 10,
-		max = 40,
-		step = 1,
-		disabled = function()
-			return not self.moduleSettings.enabled
-		end,
-		order = 33
-	}
 
-	opts["runeMode"] = {
-		type = "text",
-		name = "Display Mode",
-		desc = "Show graphical or numeric runes",
-		get = function()
-			return self.moduleSettings.runeMode
-		end,
-		set = function(v)
-			self.moduleSettings.runeMode = v
-			self:Redraw()
-		end,
-		validate = { "Numeric", "Graphical" },
-		disabled = function()
-			return not self.moduleSettings.enabled
-		end,
-		order = 34
-	}
-]]--
 	opts["runeGap"] = {
 		type = 'range',
 		name = 'Rune gap',
@@ -187,7 +148,7 @@ function Runes.prototype:GetOptions()
 		get = function()
 			return self.moduleSettings.runeGap
 		end,
-		set = function(v)
+		set = function(info, v)
 			self.moduleSettings.runeGap = v
 			self:Redraw()
 		end,
@@ -457,4 +418,4 @@ end
 local _, unitClass = UnitClass("player")
 if (unitClass == "DEATHKNIGHT") then
 	IceHUD.Runes = Runes:new()
-end
+end