Fix spell cooldown bars in 11.x

GetSpellCooldown used to return 1 for "has duration", but the new native version returns true. Fun.

Additionally, it looks like the events triggering UpdateCustomBarEvent() are passing a nil argument that the mod thought was supposed to be the affected unit. So I also fixed that, though I don't know if that's an 11.x thing or not.

https://www.wowace.com/projects/ice-hud/issues/363
This commit is contained in:
Parnic
2024-07-27 15:42:31 -05:00
parent 6c1c68a0c3
commit 66f4492fa7
3 changed files with 11 additions and 3 deletions

View File

@ -1,5 +1,9 @@
# Changelog # Changelog
v1.15.3:
- Fix custom cooldown bars not working in 11.x (wowace issue #363)
v1.15.2: v1.15.2:
- Re-enable right-click context menus on 11.x. - Re-enable right-click context menus on 11.x.

View File

@ -637,9 +637,9 @@ function IceCustomCDBar.prototype:GetCooldownDuration(buffName)
local localRemaining = nil local localRemaining = nil
local localStart, localDuration, hasCooldown = GetSpellCooldown(buffName) local localStart, localDuration, hasCooldown = GetSpellCooldown(buffName)
if (hasCooldown == 1) then if hasCooldown then
-- the item has a potential cooldown -- the item has a potential cooldown
if (localDuration <= 1.5) then if localDuration <= 1.5 then
return nil, nil return nil, nil
end end
@ -734,7 +734,7 @@ function IceCustomCDBar.prototype:UpdateItemUnitInventoryChanged(event, unit)
end end
function IceCustomCDBar.prototype:UpdateCustomBarEvent(event, unit) function IceCustomCDBar.prototype:UpdateCustomBarEvent(event, unit)
if unit ~= self.unit then if unit and unit ~= self.unit then
return return
end end
if not self.moduleSettings.cooldownType or self.moduleSettings.cooldownType == COOLDOWN_TYPE_SPELL then if not self.moduleSettings.cooldownType or self.moduleSettings.cooldownType == COOLDOWN_TYPE_SPELL then

View File

@ -1,5 +1,9 @@
# Changelog # Changelog
v1.15.3:
- Fix custom cooldown bars not working in 11.x (wowace issue #363)
v1.15.2: v1.15.2:
- Re-enable right-click context menus on 11.x. - Re-enable right-click context menus on 11.x.