wow-mods/ice-hud
1
0
Fork 0
mirror of https://github.com/parnic/ice-hud.git synced 2025-06-16 14:50:13 -05:00
Code Issues Projects Releases Wiki Activity

Minor optimization for ZM puzzle detection

Browse Source 
COMBAT_LOG_EVENT_UNFILTERED is a spam-fest, so let's only subscribe to it when we absolutely have to. This could arguably by done entirely in UNIT_AURA, but since we don't know for sure that a given UNIT_AURA event was the removal of a buff, there is a potential problem with trying to detect exactly when the puzzle session was finished. This code can potentially mis-detect puzzle starting, or hide the addon again when it's already hidden, but there shouldn't be an issue in practice. If this turns out to be problematic, I will roll back to the previous method.
This commit is contained in:
Parnic
2022-03-23 23:07:20 -05:00
parent 0785265feb
commit b64294ca11
1 changed files with 20 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

36
IceCore.lua
View File

@ -303,9 +303,23 @@ function IceCore.prototype:Enable(userToggle)
end end
elseif (event == "UNIT_AURA") then elseif (event == "UNIT_AURA") then
local unit = ... local unit = ...
if IceHUD.IceCore.settings.bHideDuringShellGame and unit == "player" and IceHUD:HasDebuffs("player", {271571})[1] and UnitInVehicle("player") then if unit ~= "player" then
return
end
if IceHUD.IceCore.settings.bHideDuringShellGame and IceHUD:HasAnyDebuff("player", {271571}) and UnitInVehicle("player") then
self:RegisterEvent("UNIT_EXITED_VEHICLE") self:RegisterEvent("UNIT_EXITED_VEHICLE")
self:Hide() self:Hide()
elseif C_Map then
local bestMapID = C_Map.GetBestMapForUnit("player")
if bestMapID ~= ZM_MAP_ID then
return
end
if IceHUD:HasAnyBuff("player", IceCore.zmPuzzleIds) then
self:RegisterEvent("COMBAT_LOG_EVENT_UNFILTERED")
self:Hide()
end
end end
elseif (event == "UNIT_EXITED_VEHICLE") then elseif (event == "UNIT_EXITED_VEHICLE") then
self:UnregisterEvent("UNIT_EXITED_VEHICLE") self:UnregisterEvent("UNIT_EXITED_VEHICLE")
@ -314,30 +328,20 @@ function IceCore.prototype:Enable(userToggle)
if C_Map then if C_Map then
local bestMapID = C_Map.GetBestMapForUnit("player") local bestMapID = C_Map.GetBestMapForUnit("player")
if bestMapID == ZM_MAP_ID then if bestMapID == ZM_MAP_ID then
self:RegisterEvent("COMBAT_LOG_EVENT_UNFILTERED") if IceHUD:HasAnyBuff("player", IceCore.zmPuzzleIds) then
local puzzleStatus = IceHUD:HasBuffs("player", IceCore.zmPuzzleIds) self:RegisterEvent("COMBAT_LOG_EVENT_UNFILTERED")
for i=1, #puzzleStatus do self:Hide()
if puzzleStatus[i] then
self:Hide()
end
end end
else
self:UnregisterEvent("COMBAT_LOG_EVENT_UNFILTERED")
end end
end end
elseif (event == "COMBAT_LOG_EVENT_UNFILTERED") then elseif (event == "COMBAT_LOG_EVENT_UNFILTERED") then
local _,subevent,_,_,_,_,_,_,destName,_,_,spellId = CombatLogGetCurrentEventInfo() local _,subevent,_,_,_,_,_,_,destName,_,_,spellId = CombatLogGetCurrentEventInfo()
if subevent == "SPELL_AURA_APPLIED" then if subevent == "SPELL_AURA_REMOVED" then
if destName == UnitName("player") then
if IceCore.zmPuzzleMap[spellId] then
self:Hide()
end
end
elseif subevent == "SPELL_AURA_REMOVED" then
if destName == UnitName("player") then if destName == UnitName("player") then
if IceCore.zmPuzzleMap[spellId] then if IceCore.zmPuzzleMap[spellId] then
self:Show() self:Show()
self:UnregisterEvent("COMBAT_LOG_EVENT_UNFILTERED")
end end
end end
end end