wow-mods/ice-hud
1
0
Fork 0
mirror of https://github.com/parnic/ice-hud.git synced 2025-06-16 06:40:13 -05:00
Code Issues Projects Releases Wiki Activity

Fix several issues with low thresholds

Browse Source 
This addresses a user-reported issue where Low Threshold was not usable with Color By Health/Mana % disabled, due to some internal technical reasons. This was exacerbated by the recent fix that allowed Low Threshold and Color By Health % to work together.

This also fixes the low threshold flash to apply immediately when changing the option, and fixes the Low Threshold % slider to be usable without the Low Flash option set.

Finally, it hides the Low Flash option for bars that don't support it (right now that's just PlayerMana, I think because it only sets the low threshold to the Min Mana Color even if the class uses a different power type...something for future me...).

Fixes wowace ticket #334
This commit is contained in:
Parnic
2022-12-13 20:48:02 -06:00
parent 59f2792ce8
commit c5c44edf64
14 changed files with 36 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
IceUnitBar.lua
View File

@ -87,7 +87,7 @@ function IceUnitBar.prototype:GetOptions()
self:Redraw()
end,
disabled = function()
return not self.moduleSettings.enabled or not self.moduleSettings.lowThresholdFlash
return not self.moduleSettings.enabled or not (self.moduleSettings.lowThresholdFlash or self.moduleSettings.lowThresholdColor)
end,
min = 0,
max = 1,
@ -105,10 +105,14 @@ function IceUnitBar.prototype:GetOptions()
end,
set = function(info, v)
self.moduleSettings.lowThresholdFlash = v
self:Redraw()
end,
disabled = function()
return not self.moduleSettings.enabled
end,
hidden = function()
return self.noFlash
end,
order = 30.092
}
opts["lowThresholdColor"] = {
@ -123,7 +127,7 @@ function IceUnitBar.prototype:GetOptions()
self:Redraw()
end,
disabled = function()
return not self.moduleSettings.enabled or not (self.moduleSettings.scaleHealthColor and self.moduleSettings.scaleManaColor)
return not self.moduleSettings.enabled
end,
order = 30.093
}