Fix error on BCC

Fixes #21
Fix changelogs
2025-06-16 22:51:53 -05:00 · 2022-06-01 16:26:12 -05:00 · 2022-06-01 08:31:05 -05:00 · 2022-06-01 08:30:21 -05:00 · 2022-06-01 08:29:39 -05:00 · 2022-05-02 12:22:07 -05:00
5 changed files with 144 additions and 128 deletions
--- a/IceHUD.lua
+++ b/IceHUD.lua
@ -36,7 +36,7 @@ IceHUD.CanTrackOtherUnitBuffs = not IceHUD.WowClassic
 IceHUD.CanTrackGCD = not IceHUD.WowClassic
 IceHUD.GetSpellInfoReturnsFunnel = IceHUD.WowMain and IceHUD.WowVer < 60000
 IceHUD.CanHookDestroyTotem = IceHUD.WowClassic or IceHUD.WowClassicBC
-IceHUD.ShouldUpdateTargetHealthEveryTick = IceHUD.WowClassicBC and GetCVarBool("predictedHealth")
+IceHUD.ShouldUpdateTargetHealthEveryTick = (IceHUD.WowClassic or IceHUD.WowClassicBC) and GetCVarBool("predictedHealth")

 IceHUD.UnitPowerEvent = "UNIT_POWER_UPDATE"

@ -684,34 +684,35 @@ function IceHUD:GetIsInLFGGroup()
 	return IsInLFGGroup
 end

-local BLACKLISTED_UNIT_MENU_OPTIONS = {
+if UnitPopupButtons then
+	local BLACKLISTED_UNIT_MENU_OPTIONS = {
 		SET_FOCUS = "ICEHUD_SET_FOCUS",
 		CLEAR_FOCUS = "ICEHUD_CLEAR_FOCUS",
 		PET_DISMISS = "ICEHUD_PET_DISMISS",
 		LOCK_FOCUS_FRAME = true,
 		UNLOCK_FOCUS_FRAME = true,
-}
+	}

-UnitPopupButtons["ICEHUD_SET_FOCUS"] = {
+	UnitPopupButtons["ICEHUD_SET_FOCUS"] = {
 		text = L["Type %s to set focus"]:format(SLASH_FOCUS1),
 		tooltipText = L["Blizzard currently does not provide a proper way to right-click focus with custom unit frames."],
 		dist = 0,
-}
+	}

-UnitPopupButtons["ICEHUD_CLEAR_FOCUS"] = {
+	UnitPopupButtons["ICEHUD_CLEAR_FOCUS"] = {
 		text = L["Type %s to clear focus"]:format(SLASH_CLEARFOCUS1),
 		tooltipText = L["Blizzard currently does not provide a proper way to right-click focus with custom unit frames."],
 		dist = 0,
-}
+	}

-UnitPopupButtons["ICEHUD_PET_DISMISS"] = {
+	UnitPopupButtons["ICEHUD_PET_DISMISS"] = {
 		text = L["Use your Dismiss Pet spell to dismiss a pet"],
 		tooltipText = L["Blizzard currently does not provide a proper way to right-click dismiss a pet with custom unit frames."],
 		dist = 0,
-}
+	}

-local munged_unit_menus = {}
-local function munge_unit_menu(menu)
+	local munged_unit_menus = {}
+	local function munge_unit_menu(menu)
 		local result = munged_unit_menus[menu]
 		if result then
 			return result
@ -760,10 +761,10 @@ local function munge_unit_menu(menu)
 		UnitPopupMenus[new_menu_name] = new_data
 		munged_unit_menus[menu] = new_menu_name
 		return new_menu_name
-end
-IceHUD.MungeUnitMenu = munge_unit_menu
+	end
+	IceHUD.MungeUnitMenu = munge_unit_menu

-local function figure_unit_menu(unit)
+	local function figure_unit_menu(unit)
 		if unit == "focus" then
 			return "FOCUS"
 		end
@ -796,15 +797,15 @@ local function figure_unit_menu(unit)
 		end

 		return "PLAYER"
-end
+	end

-IceHUD_UnitFrame_DropDown = CreateFrame("Frame", "IceHUD_UnitFrame_DropDown", UIParent, "UIDropDownMenuTemplate")
-if UnitPopupFrames then
+	IceHUD_UnitFrame_DropDown = CreateFrame("Frame", "IceHUD_UnitFrame_DropDown", UIParent, "UIDropDownMenuTemplate")
+	if UnitPopupFrames then
 		UnitPopupFrames[#UnitPopupFrames+1] = "IceHUD_UnitFrame_DropDown"
-end
+	end

-IceHUD.DropdownUnit = nil
-UIDropDownMenu_Initialize(IceHUD_UnitFrame_DropDown, function()
+	IceHUD.DropdownUnit = nil
+	UIDropDownMenu_Initialize(IceHUD_UnitFrame_DropDown, function()
 		if not IceHUD.DropdownUnit then
 			return
 		end
@ -814,4 +815,5 @@ UIDropDownMenu_Initialize(IceHUD_UnitFrame_DropDown, function()
 			menu = IceHUD.MungeUnitMenu(menu)
 			UnitPopup_ShowMenu(IceHUD_UnitFrame_DropDown, menu, IceHUD.DropdownUnit, nil, id)
 		end
-end, "MENU", nil)
+	end, "MENU", nil)
+end
--- a/IceHUD.toc
+++ b/IceHUD.toc
@ -1,7 +1,7 @@
-## Interface: 90200
-## Interface-Retail: 90200
-## Interface-Classic: 11402
-## Interface-BCC: 20503
+## Interface: 90205
+## Interface-Retail: 90205
+## Interface-Classic: 11403
+## Interface-BCC: 20504
 ## Author: Parnic, originally created by Iceroth
 ## Name: IceHUD
 ## Title: IceHUD |cff7fff7f-Ace3-|r
--- a/IceHUD_Options/IceHUD_Options.toc
+++ b/IceHUD_Options/IceHUD_Options.toc
@ -1,7 +1,7 @@
-## Interface: 90200
-## Interface-Retail: 90200
-## Interface-Classic: 11402
-## Interface-BCC: 20503
+## Interface: 90205
+## Interface-Retail: 90205
+## Interface-Classic: 11403
+## Interface-BCC: 20504
 ## Title: IceHUD |cff7fff7f-Options-|r
 ## Author: Parnic
 ## Version: @project-version@
--- a/changelog.md
+++ b/changelog.md
@ -1,5 +1,15 @@
 # Changelog

+v1.13.14.1:
+
+- Restored guard around array that doesn't exist on Classic clients.
+
+v1.13.14:
+
+- Fixed target health updating infrequently on Classic.
+- Fixed compatibility with WoW 9.2.5.
+- Updated TOC for all game flavors.
+
 v1.13.13:

 - Slight optimization of Zereth Mortis puzzle detection logic.
--- a/this_version.md
+++ b/this_version.md
@ -1,7 +1,11 @@
 # Changelog

-v1.13.13:
+v1.13.14.1:

- Slight optimization of Zereth Mortis puzzle detection logic.
- Fixed target health updating infrequently on Classic-BC.
- Fixed reported error in TargetInvuln module.
+- Restored guard around array that doesn't exist on Classic clients.
+
+v1.13.14:
+
+- Fixed target health updating infrequently on Classic.
+- Fixed compatibility with WoW 9.2.5.
+- Updated TOC for all game flavors.
Author	SHA1	Message	Date
Parnic	9500bdf393	Fix error on BCC Fixes #21	2022-06-01 16:26:12 -05:00
Parnic	6325ed1ade	Fix changelogs This is why Unreleased is used instead...	2022-06-01 08:31:05 -05:00
Parnic	a4c44a5809	Update TOC	2022-06-01 08:30:21 -05:00
Parnic	82db70969a	Remove UnitPopupButtons usage I need to find a way to reintroduce this, but Blizzard's new method of building these frames doesn't look like it's going to be particularly easy. This stops error popups on 9.2.5	2022-06-01 08:29:39 -05:00
Parnic	47931922bd	Fix target health updating infrequently on Classic	2022-05-02 12:22:07 -05:00