Compare commits

...

8 Commits

Author SHA1 Message Date
bc16ae677b Update for WoW 9.1 2021-06-28 13:02:19 -05:00
dc5a3f3a05 Finalize changelog for v1.13.5 2021-06-26 14:21:36 -05:00
6c3ed55780 Update changelog 2021-06-26 14:20:39 -05:00
dfcef9617f Always update aura durations
If we're coming from a custom update func, it could mean that we're
tracking a unit that doesn't get events, like UNIT_AURA, for them. This
includes anything other than player, target, and focus, essentially.
2021-06-26 14:14:57 -05:00
94b62d56a0 Also subscribe for targettarget units 2021-06-26 14:13:57 -05:00
90f126d7a0 Fix custom bar update errors
I was tracking updates with two separate variables depending on where
the registration happened. The order that updates ran in was not
reliable, so sometimes one would register and sometimes the other would.
Since only one of them was setting itself as "from update", the behavior
internal to the bar was also inconsistent.
2021-06-26 14:13:44 -05:00
209fbe2b4e Trim whitespace off dogtags on upper/lower texts
This fixes an issue with strings getting clipped when newlines were
inadvertently included. wowace ticket #311
2021-06-10 22:29:30 -05:00
9435a9d74f Move LibRangeCheck to the proper location (wowace #306) 2021-05-21 07:40:01 -05:00
7 changed files with 25 additions and 24 deletions

View File

@ -58,6 +58,7 @@ optional-dependencies:
move-folders: move-folders:
IceHUD/IceHUD_Options: IceHUD_Options IceHUD/IceHUD_Options: IceHUD_Options
IceHUD/libs/LibRangeCheck-2.0/LibRangeCheck-2.0: IceHUD/libs/LibRangeCheck-2.0
tools-used: tools-used:
- libdatabroker-1-1 - libdatabroker-1-1

View File

@ -626,7 +626,7 @@ do
v = DogTag:CleanCode(v) v = DogTag:CleanCode(v)
end end
self.moduleSettings.upperText = v self.moduleSettings.upperText = strtrim(v)
self:RegisterFontStrings() self:RegisterFontStrings()
self:Redraw() self:Redraw()
end, end,
@ -655,7 +655,7 @@ do
v = DogTag:CleanCode(v) v = DogTag:CleanCode(v)
end end
self.moduleSettings.lowerText = v self.moduleSettings.lowerText = strtrim(v)
self:RegisterFontStrings() self:RegisterFontStrings()
self:Redraw() self:Redraw()
end, end,

View File

@ -1,5 +1,5 @@
## Interface: 90005 ## Interface: 90100
## Interface-Retail: 90005 ## Interface-Retail: 90100
## Interface-Classic: 11306 ## Interface-Classic: 11306
## Interface-BCC: 20501 ## Interface-BCC: 20501
## Author: Parnic, originally created by Iceroth ## Author: Parnic, originally created by Iceroth

View File

@ -1,5 +1,5 @@
## Interface: 90005 ## Interface: 90100
## Interface-Retail: 90005 ## Interface-Retail: 90100
## Interface-Classic: 11306 ## Interface-Classic: 11306
## Interface-BCC: 20501 ## Interface-BCC: 20501
## Title: IceHUD |cff7fff7f-Options-|r ## Title: IceHUD |cff7fff7f-Options-|r

View File

@ -1,9 +1,16 @@
# Changelog # Changelog
vNext: v1.13.6:
- Updated TOC to 9.1
- Packaged an updated DogTag library with a fix for Classic-era `[Class]` tags.
v1.13.5:
- Classic-Burning Crusade support - Classic-Burning Crusade support
- Package a community fork of LibRangeCheck with BC-Classic compatibility - Package a community fork of LibRangeCheck with BC-Classic compatibility
- Prevented DogTag strings sometimes cutting off and showing "..." when they shouldn't if the user entered blank lines in the text box for the tags. Also changed the tooltip to not suggest pressing Enter since that could cause this problem. If you already have blank lines in your DogTag strings, you will want to remove them manually, but this fix prevents the problem from occurring in the future.
- Fixed custom buff/debuff bar tracking for targettarget units.
v1.13.4: v1.13.4:

View File

@ -19,6 +19,7 @@ IceCustomBar.prototype.bIsAura = false
function IceCustomBar.prototype:init() function IceCustomBar.prototype:init()
IceCustomBar.super.prototype.init(self, "MyCustomBar", "player") IceCustomBar.super.prototype.init(self, "MyCustomBar", "player")
self.textColorOverride = true self.textColorOverride = true
self.CustomBarUpdateFunc = function() self:UpdateCustomBar(self.unit, true) end
end end
-- 'Public' methods ----------------------------------------------------------- -- 'Public' methods -----------------------------------------------------------
@ -107,11 +108,7 @@ end
function IceCustomBar.prototype:ConditionalSubscribe() function IceCustomBar.prototype:ConditionalSubscribe()
if self:ShouldAlwaysSubscribe() then if self:ShouldAlwaysSubscribe() then
if not IceHUD.IceCore:IsUpdateSubscribed(self) then if not IceHUD.IceCore:IsUpdateSubscribed(self, self.CustomBarUpdateFunc) then
if not self.CustomBarUpdateFunc then
self.CustomBarUpdateFunc = function() self:UpdateCustomBar() end
end
self.handlesOwnUpdates = true self.handlesOwnUpdates = true
IceHUD.IceCore:RequestUpdates(self, self.CustomBarUpdateFunc) IceHUD.IceCore:RequestUpdates(self, self.CustomBarUpdateFunc)
end end
@ -122,7 +119,7 @@ function IceCustomBar.prototype:ConditionalSubscribe()
end end
function IceCustomBar.prototype:ShouldAlwaysSubscribe() function IceCustomBar.prototype:ShouldAlwaysSubscribe()
return self.unit == "focustarget" or self.unit == "pettarget" return self.unit == "focustarget" or self.unit == "pettarget" or self.unit == "targettarget"
end end
function IceCustomBar.prototype:TargetChanged() function IceCustomBar.prototype:TargetChanged()
@ -755,7 +752,7 @@ function IceCustomBar.prototype:UpdateCustomBar(unit, fromUpdate)
local auraIcon = nil local auraIcon = nil
local endTime = 0 local endTime = 0
if not fromUpdate then --if not fromUpdate then
if tonumber(self.moduleSettings.buffToTrack) == nil then if tonumber(self.moduleSettings.buffToTrack) == nil then
self.auraDuration, remaining, self.auraBuffCount, auraIcon, endTime = self.auraDuration, remaining, self.auraBuffCount, auraIcon, endTime =
self:GetAuraDuration(self.unit, self.moduleSettings.buffToTrack) self:GetAuraDuration(self.unit, self.moduleSettings.buffToTrack)
@ -790,18 +787,14 @@ function IceCustomBar.prototype:UpdateCustomBar(unit, fromUpdate)
else else
self.barFrame.icon:Hide() self.barFrame.icon:Hide()
end end
end --end
self.auraBuffCount = self.auraBuffCount or 0 self.auraBuffCount = self.auraBuffCount or 0
if self.auraEndTime ~= nil and (self.auraEndTime == 0 or self.auraEndTime >= now) and (not self.moduleSettings.minCount or self.auraBuffCount >= self.moduleSettings.minCount) then if self.auraEndTime ~= nil and (self.auraEndTime == 0 or self.auraEndTime >= now) and (not self.moduleSettings.minCount or self.auraBuffCount >= self.moduleSettings.minCount) then
if not self:ShouldAlwaysSubscribe() and not fromUpdate and not IceHUD.IceCore:IsUpdateSubscribed(self) then if not self:ShouldAlwaysSubscribe() and not fromUpdate and not IceHUD.IceCore:IsUpdateSubscribed(self, self.CustomBarUpdateFunc) then
if not self.UpdateCustomBarFunc then
self.UpdateCustomBarFunc = function() self:UpdateCustomBar(self.unit, true) end
end
self.handlesOwnUpdates = true self.handlesOwnUpdates = true
IceHUD.IceCore:RequestUpdates(self, self.UpdateCustomBarFunc) IceHUD.IceCore:RequestUpdates(self, self.CustomBarUpdateFunc)
end end
self:Show(true) self:Show(true)

View File

@ -1,6 +1,6 @@
# Changelog # Changelog
vNext: v1.13.6:
- Classic-Burning Crusade support - Updated TOC to 9.1
- Package a community fork of LibRangeCheck with BC-Classic compatibility - Packaged an updated DogTag library with a fix for Classic-era `[Class]` tags.