Fix 10.1.5 error building a player menu

I explicitly added what I believe to be the spell id for the new Grotto Netherwing Drake so it *should* work regardless, but then also discovered that the flying mount's UnitPowerMax is 0 unless you're on a Dragonriding mount, so that should be the longer-term fix for whenever old-world mounts add Dragonriding capability (10.1.5?).

IceCastBar.lua

@@ -386,19 +386,24 @@ function IceCastBar.prototype:MyOnUpdate()
 		self.action == IceCastBar.Actions.Success or
 		self.action == IceCastBar.Actions.Failure)
 	then
-		local scale = GetTime() - self.actionStartTime
+		local scale
+		if self.actionStartTime then
+			scale = GetTime() - self.actionStartTime
+		end
 
-		if (scale > 1) then
+		if scale and (scale > 1) then
 			self:StopBar()
 			return
 		end
 
 		self:UpdateBar(1, self:GetCurrentCastingColor())
 
-		if (self.action == IceCastBar.Actions.Failure) then
-			self:FlashBar("CastFail", 1-scale, self.actionMessage, "CastFail")
-		else
-			self:FlashBar("CastSuccess", 1-scale, self.actionMessage)
+		if scale then
+			if (self.action == IceCastBar.Actions.Failure) then
+				self:FlashBar("CastFail", 1-scale, self.actionMessage, "CastFail")
+			else
+				self:FlashBar("CastSuccess", 1-scale, self.actionMessage)
+			end
 		end
 		return
 	end
@@ -465,7 +470,9 @@ function IceCastBar.prototype:GetCurrentCastingColor()
 end
 
 function IceCastBar.prototype:FlashBar(color, alpha, text, textColor)
-	self.frame:SetAlpha(alpha)
+	if alpha then
+		self.frame:SetAlpha(alpha)
+	end
 
 	local r, g, b = self.settings.backgroundColor.r, self.settings.backgroundColor.g, self.settings.backgroundColor.b
 	if (self.settings.backgroundToggle) then

IceHUD.lua

@@ -886,11 +886,13 @@ local function munge_unit_menu(menu)
 			if btns[i].IsMenu() then
 				local subbtns = btns[i].GetMenuButtons()
 				for j=1, #subbtns do
-					local blacklisted = BLACKLISTED_UNIT_MENU_OPTIONS[subbtns[j]:GetText()]
-					if not blacklisted then
-						new_buttons_list[#new_buttons_list+1] = subbtns[j]
-					elseif blacklisted ~= true then
-						new_buttons_list[#new_buttons_list+1] = blacklisted
+					if subbtns[j] then
+						local blacklisted = BLACKLISTED_UNIT_MENU_OPTIONS[subbtns[j]:GetText()]
+						if not blacklisted then
+							new_buttons_list[#new_buttons_list+1] = subbtns[j]
+						elseif blacklisted ~= true then
+							new_buttons_list[#new_buttons_list+1] = blacklisted
+						end
 					end
 				end
 			else

IceHUD.toc

@@ -1,8 +1,8 @@
-## Interface: 100007
-## Interface-Retail: 100007
+## Interface: 100105
+## Interface-Retail: 100105
 ## Interface-Classic: 11403
 ## Interface-BCC: 20504
-## Interface-Wrath: 30401
+## Interface-Wrath: 30402
 ## Author: Parnic, originally created by Iceroth
 ## Name: IceHUD
 ## Title: IceHUD |cff7fff7f-Ace3-|r
@@ -14,6 +14,7 @@
 # ## Version: @project-version@
 #@end-non-debug@
 ## SavedVariables: IceCoreDB
+## IconTexture: Interface\Icons\Spell_Frost_Frost
 ## OptionalDeps: Ace3, LibSharedMedia-3.0, LibDogTag-3.0, LibDogTag-Unit-3.0, LibRangeCheck-2.0, LibDualSpec-1.0, LibDBIcon-1.0, AceGUI-3.0-SharedMediaWidgets
 ## X-Category: HUDs
 ## X-Website: https://www.wowace.com/projects/ice-hud

IceHUD_Options/IceHUD_Options.toc

@@ -1,8 +1,8 @@
-## Interface: 100007
-## Interface-Retail: 100007
+## Interface: 100105
+## Interface-Retail: 100105
 ## Interface-Classic: 11403
 ## Interface-BCC: 20504
-## Interface-Wrath: 30401
+## Interface-Wrath: 30402
 ## Title: IceHUD |cff7fff7f-Options-|r
 ## Author: Parnic
 ## Version: @project-version@
@@ -10,6 +10,7 @@
 ## OptionalDeps: AceGUI-3.0-SharedMediaWidgets
 ## Dependencies: IceHUD
 ## LoadOnDemand: 1
+## IconTexture: Interface\Icons\Spell_Frost_Frost
 
 Json.lua
 JsonDecode.lua

IceHUD_Options/Options.lua

@@ -161,7 +161,7 @@ The Classic game client doesn't provide this information to addons because it wa
 						IceHUD.IceCore:SetScale(v)
 					end,
 					min = 0.2,
-					max = 2.0,
+					max = 4.0,
 					step = 0.05,
 					isPercent = true,
 					order = 14,

changelog.md

@@ -1,5 +1,38 @@
 # Changelog
 
+v1.14.24:
+
+- Fixed an error when targeting a player and right-clicking a module that should show a menu in 10.1.5.
+
+v1.14.23:
+
+- Update Dragonflight TOC for 10.1.5
+
+v1.14.22:
+
+- Fixed reported issue with a Lua error on Wrath Classic clients. https://www.wowace.com/projects/ice-hud/issues/344
+- Fixed Vigor module not working when riding Grotto Netherwing Drake (and theoretically all future Dragonriding mount types).
+- Updated TOC for Wrath-Classic.
+
+v1.14.21:
+
+- Increased maximum scale/zoom to 400%, by request.
+- Fixed TargetCC/FocusCC modules on Wrath Classic.
+- Fixed disabled Buff/Debuff Watchers showing a static gray bar when set to When Missing or Always display modes.
+- Fixed Buff/Debuff Watchers showing an empty bar when set to Missing mode. If the background was disabled, this looked like just a floating spell icon.
+- Fixed spell icons sometimes not showing up for custom bars until the tracked spell had been cast once.
+
+v1.14.20:
+
+- Added Winding Slitherdrake as recognized for the Dragonriding Vigor module
+
+v1.14.19:
+
+- Updated TOCs for 10.1.0
+- Added addon icon for 10.1.0 clients
+- Fixed Dragonriding Vigor charges not showing up in 10.1.0
+- Fixed Vigor not always updating correctly when loading into the game or a new zone
+
 v1.14.18:
 
 - Fixed Runic Power showing on a scale of 0-1000+ instead of 0-100+ with DogTags off

modules/CustomBar.lua

@@ -83,6 +83,7 @@ function IceCustomBar.prototype:Enable(core)
 	self:FixupTextColors()
 	self:SetCustomTextColor(self.frame.bottomUpperText, self.moduleSettings.upperTextColor)
 	self:SetCustomTextColor(self.frame.bottomLowerText, self.moduleSettings.lowerTextColor)
+	self:UpdateAuraIcon()
 end
 
 function IceCustomBar.prototype:Disable(core)
@@ -204,6 +205,7 @@ end
 function IceCustomBar.prototype:Redraw()
 	IceCustomBar.super.prototype.Redraw(self)
 
+	self:UpdateAuraIcon()
 	self:UpdateCustomBar(self.unit)
 end
 
@@ -822,7 +824,11 @@ function IceCustomBar.prototype:UpdateCustomBar(unit, fromUpdate)
 
 		self:UpdateBar(self.auraDuration ~= 0 and remaining / self.auraDuration or 0, "undef")
 	else
-		self:UpdateBar(0, "undef")
+		local updateVal = 0
+		if self.moduleSettings.displayMode == displayModes.MISSING then
+			updateVal = 1
+		end
+		self:UpdateBar(updateVal, "undef")
 		self:Show(false)
 		if not self:ShouldAlwaysSubscribe() then
 			self.handlesOwnUpdates = false
@@ -883,9 +889,14 @@ function IceCustomBar.prototype:Show(bShouldShow, bForceHide)
 	end
 
 	if self.moduleSettings.displayMode == displayModes.MISSING then
-		IceCustomBar.super.prototype.Show(self, not bShouldShow)
+		local show = not bShouldShow
+		if show and not self:IsEnabled() then
+			show = false
+		end
+
+		IceCustomBar.super.prototype.Show(self, show)
 	elseif self.moduleSettings.displayMode == displayModes.WHEN_TARGETING and self.target then
-		IceCustomBar.super.prototype.Show(self, true)
+		IceCustomBar.super.prototype.Show(self, self:IsEnabled())
 	elseif self.moduleSettings.displayMode == displayModes.ALWAYS then
 		if not self.bIsVisible then
 			IceCustomBar.super.prototype.Show(self, true)
@@ -894,3 +905,13 @@ function IceCustomBar.prototype:Show(bShouldShow, bForceHide)
 		IceCustomBar.super.prototype.Show(self, bShouldShow)
 	end
 end
+
+function IceCustomBar.prototype:UpdateAuraIcon()
+	if not self.barFrame or not self.barFrame.icon then
+		return
+	end
+
+	local _, _, auraIcon = GetSpellInfo(self.moduleSettings.buffToTrack)
+
+	self.barFrame.icon:SetTexture(auraIcon)
+end

modules/DragonridingVigor.lua

@@ -6,10 +6,15 @@ local DragonridingBuffs = {
 	368896, -- Renewed Proto-Drake
 	368899, -- Windborn Velocidrake
 	368901, -- Cliffside Wylderdrake
+	368893, -- Winding Slitherdrake
+	412088, -- Grotto Netherwing Drake
 }
 
 local vigorWidgetSetID = 283
 local vigorWidgetID = 4460
+local knowsAlternateMountEnum = Enum and Enum.PowerType and Enum.PowerType.AlternateMount
+local unitPowerType = Enum and Enum.PowerType and Enum.PowerType.AlternateMount
+unitPowerType = unitPowerType or ALTERNATE_POWER_INDEX
 
 function DragonridingVigor.prototype:init()
 	DragonridingVigor.super.prototype.init(self, "Vigor")
@@ -18,7 +23,7 @@ function DragonridingVigor.prototype:init()
 
 	self.unit = "player"
 	self.numericColor = "VigorNumeric"
-	self.unitPower = ALTERNATE_POWER_INDEX
+	self.unitPower = unitPowerType
 	self.minLevel = 0
 	self.bTreatEmptyAsFull = false
 	self.runeWidth = self.runeHeight
@@ -26,7 +31,7 @@ function DragonridingVigor.prototype:init()
 end
 
 function DragonridingVigor.prototype:Enable(core)
-	self.numRunes = UnitPowerMax(self.unit, ALTERNATE_POWER_INDEX)
+	self.numRunes = UnitPowerMax(self.unit, unitPowerType)
 	self.runeCoords = { }
 	for i = 1, self.numRunes do
 		self:SetupNewRune(i)
@@ -41,7 +46,7 @@ end
 function DragonridingVigor.prototype:EnteringWorld()
 	DragonridingVigor.super.prototype.EnteringWorld(self)
 
-	self:CheckShouldShow("player")
+	self:CheckShouldShow("PLAYER_ENTERING_WORLD", "player")
 end
 
 function DragonridingVigor.prototype:CheckShouldShow(event, unit, info)
@@ -49,7 +54,9 @@ function DragonridingVigor.prototype:CheckShouldShow(event, unit, info)
 		return
 	end
 
-	if IceHUD:HasAnyBuff("player", DragonridingBuffs) then
+	if knowsAlternateMountEnum and UnitPowerMax(self.unit, unitPowerType) > 0 then
+		self:Show(true)
+	elseif IceHUD:HasAnyBuff("player", DragonridingBuffs) then
 		self:Show(true)
 	else
 		self:Show(false)
@@ -151,6 +158,6 @@ function DragonridingVigor.prototype:HideBlizz()
 end
 
 -- Load us up
-if ALTERNATE_POWER_INDEX and C_UIWidgetManager and C_UIWidgetManager.GetFillUpFramesWidgetVisualizationInfo then
+if unitPowerType and C_UIWidgetManager and C_UIWidgetManager.GetFillUpFramesWidgetVisualizationInfo then
 	IceHUD.DragonridingVigor = DragonridingVigor:new()
 end

modules/TargetCC.lua

@@ -360,7 +360,7 @@ function TargetCC.prototype:GetMaxDebuffDuration(unitName, debuffNames)
 	while debuff do
 		remaining = endTime - GetTime()
 
-		if debuffNames[spellId] and (not self.moduleSettings.onlyShowForMyDebuffs or isMine) then
+		if (debuffNames[spellId] or debuffNames[debuff]) and (not self.moduleSettings.onlyShowForMyDebuffs or isMine) then
 			if result[0] then
 				if result[2] < remaining then
 					result = {debuff, duration, remaining}

this_version.md

@@ -1,5 +1,38 @@
 # Changelog
 
+v1.14.24:
+
+- Fixed an error when targeting a player and right-clicking a module that should show a menu in 10.1.5.
+
+v1.14.23:
+
+- Update Dragonflight TOC for 10.1.5
+
+v1.14.22:
+
+- Fixed reported issue with a Lua error on Wrath Classic clients. https://www.wowace.com/projects/ice-hud/issues/344
+- Fixed Vigor module not working when riding Grotto Netherwing Drake (and theoretically all future Dragonriding mount types).
+- Updated TOC for Wrath-Classic.
+
+v1.14.21:
+
+- Increased maximum scale/zoom to 400%, by request.
+- Fixed TargetCC/FocusCC modules on Wrath Classic.
+- Fixed disabled Buff/Debuff Watchers showing a static gray bar when set to When Missing or Always display modes.
+- Fixed Buff/Debuff Watchers showing an empty bar when set to Missing mode. If the background was disabled, this looked like just a floating spell icon.
+- Fixed spell icons sometimes not showing up for custom bars until the tracked spell had been cast once.
+
+v1.14.20:
+
+- Added Winding Slitherdrake as recognized for the Dragonriding Vigor module
+
+v1.14.19:
+
+- Updated TOCs for 10.1.0
+- Added addon icon for 10.1.0 clients
+- Fixed Dragonriding Vigor charges not showing up in 10.1.0
+- Fixed Vigor not always updating correctly when loading into the game or a new zone
+
 v1.14.18:
 
 - Fixed Runic Power showing on a scale of 0-1000+ instead of 0-100+ with DogTags off