Update changelog

Fix potential nil access
2025-06-16 14:50:13 -05:00 · 2023-01-13 09:34:36 -06:00 · 2022-12-19 12:51:51 -06:00 · 2022-12-19 12:19:10 -06:00 · 2022-12-13 20:48:02 -06:00
14 changed files with 52 additions and 2 deletions
--- a/IceUnitBar.lua
+++ b/IceUnitBar.lua
@ -87,7 +87,7 @@ function IceUnitBar.prototype:GetOptions()
 			self:Redraw()
 		end,
 		disabled = function()
-			return not self.moduleSettings.enabled or not self.moduleSettings.lowThresholdFlash
+			return not self.moduleSettings.enabled or not (self.moduleSettings.lowThresholdFlash or self.moduleSettings.lowThresholdColor)
 		end,
 		min = 0,
 		max = 1,
@ -105,10 +105,14 @@ function IceUnitBar.prototype:GetOptions()
 		end,
 		set = function(info, v)
 			self.moduleSettings.lowThresholdFlash = v
+			self:Redraw()
 		end,
 		disabled = function()
 			return not self.moduleSettings.enabled
 		end,
+		hidden = function()
+			return self.noFlash
+		end,
 		order = 30.092
 	}
 	opts["lowThresholdColor"] = {
@ -123,7 +127,7 @@ function IceUnitBar.prototype:GetOptions()
 			self:Redraw()
 		end,
 		disabled = function()
-			return not self.moduleSettings.enabled or not (self.moduleSettings.scaleHealthColor and self.moduleSettings.scaleManaColor)
+			return not self.moduleSettings.enabled
 		end,
 		order = 30.093
 	}
--- a/changelog.md
+++ b/changelog.md
@ -1,5 +1,17 @@
 # Changelog

+v1.14.11:
+
+- Packaged a new version of LibDogTag-Unit to fix the Guild roster resetting its scroll position every 20 seconds.
+
+v1.14.10:
+
+- Fix an error in TargetTargetHealth/Mana and CustomHealth when Low Threshold Color was checked and Scale by Health % was un-checked.
+
+v1.14.9:
+
+- Fix Low Threshold to be usable even when Color By Health/Mana % is disabled. (ticket #334)
+
 v1.14.8:

 - Fix Color By Health % to work with Low Threshold Color option. Previously, if Low Threshold was set, the color was always either MaxHealth/MaxMana or MinHealth/MinMana, it would never be colored by health %. Now if both are set, it will scale by health % until it reaches the low threshold, at which point it will switch to the Min color.
--- a/modules/CustomHealth.lua
+++ b/modules/CustomHealth.lua
@ -144,6 +144,8 @@ function IceCustomHealth.prototype:Update(unit)

 	if (self.moduleSettings.scaleHealthColor) then
 		self.color = "ScaledHealthColor"
+	elseif self.moduleSettings.lowThresholdColor and self.healthPercentage and self.healthPercentage <= self.moduleSettings.lowThreshold then
+		self.color = "ScaledHealthColor"
 	end

 	if (self.tapped) then
--- a/modules/FocusHealth.lua
+++ b/modules/FocusHealth.lua
@ -364,6 +364,8 @@ function FocusHealth.prototype:Update(unit)

 	if (self.moduleSettings.scaleHealthColor) then
 		self.color = "ScaledHealthColor"
+	elseif self.moduleSettings.lowThresholdColor and self.healthPercentage <= self.moduleSettings.lowThreshold then
+		self.color = "ScaledHealthColor"
 	end

 	if (self.tapped) then
--- a/modules/FocusMana.lua
+++ b/modules/FocusMana.lua
@ -88,6 +88,8 @@ function FocusMana.prototype:Update(unit)
 	local color = "FocusMana"
 	if (self.moduleSettings.scaleManaColor) then
 		color = "ScaledManaColor"
+	elseif self.moduleSettings.lowThresholdColor and self.manaPercentage <= self.moduleSettings.lowThreshold then
+		color = "ScaledManaColor"
 	end
 	if (manaType == SPELL_POWER_RAGE) then
 		color = "FocusRage"
--- a/modules/PetHealth.lua
+++ b/modules/PetHealth.lua
@ -93,6 +93,8 @@ function PetHealth.prototype:Update(unit)

 	if (self.moduleSettings.scaleHealthColor) then
 		color = "ScaledHealthColor"
+	elseif self.moduleSettings.lowThresholdColor and self.healthPercentage <= self.moduleSettings.lowThreshold then
+		color = "ScaledHealthColor"
 	end

 	if not (self.alive) then
--- a/modules/PetMana.lua
+++ b/modules/PetMana.lua
@ -173,6 +173,8 @@ function PetMana.prototype:Update(unit)
 	local color = "PetMana"
 	if (self.moduleSettings.scaleManaColor) then
 		color = "ScaledManaColor"
+	elseif self.moduleSettings.lowThresholdColor and self.manaPercentage <= self.moduleSettings.lowThreshold then
+		color = "ScaledManaColor"
 	end
 	if not (self.alive) then
 		color = "Dead"
--- a/modules/PlayerHealth.lua
+++ b/modules/PlayerHealth.lua
@ -1276,6 +1276,8 @@ function PlayerHealth.prototype:Update(unit)

 	if (self.moduleSettings.scaleHealthColor) then
 		color = "ScaledHealthColor"
+	elseif self.moduleSettings.lowThresholdColor and self.healthPercentage <= self.moduleSettings.lowThreshold then
+		color = "ScaledHealthColor"
 	end

 	if not (self.alive) then
--- a/modules/PlayerMana.lua
+++ b/modules/PlayerMana.lua
@ -344,6 +344,8 @@ function PlayerMana.prototype:Update(unit, powertype)
 		color = "Dead"
 	elseif (self.moduleSettings.scaleManaColor and (UnitPowerType(self.unit) == SPELL_POWER_MANA or self.moduleSettings.scaleManaColorForAll)) then
 		color = "ScaledManaColor"
+	elseif self.moduleSettings.lowThresholdColor and self.manaPercentage <= self.moduleSettings.lowThreshold then
+		color = "ScaledManaColor"
 	else
 		if (self.manaType == SPELL_POWER_RAGE) then
 			color = "PlayerRage"
--- a/modules/TargetHealth.lua
+++ b/modules/TargetHealth.lua
@ -841,6 +841,8 @@ function IceTargetHealth.prototype:Update(unit)

 		if (self.moduleSettings.scaleHealthColor) then
 			self.color = "ScaledHealthColor"
+		elseif self.moduleSettings.lowThresholdColor and self.healthPercentage <= self.moduleSettings.lowThreshold then
+			self.color = "ScaledHealthColor"
 		end

 		if (self.tapped) then
--- a/modules/TargetMana.lua
+++ b/modules/TargetMana.lua
@ -125,6 +125,8 @@ function IceTargetMana.prototype:Update(unit)

 		if (self.moduleSettings.scaleManaColor) then
 			self.color = "ScaledManaColor"
+		elseif self.moduleSettings.lowThresholdColor and self.manaPercentage <= self.moduleSettings.lowThreshold then
+			self.color = "ScaledManaColor"
 		end

 		if (manaType == SPELL_POWER_RAGE) then
--- a/modules/TargetOfTargetHealth.lua
+++ b/modules/TargetOfTargetHealth.lua
@ -136,6 +136,8 @@ function TargetTargetHealth.prototype:Update(unit)

 	if (self.moduleSettings.scaleHealthColor) then
 		self.color = "ScaledHealthColor"
+	elseif self.moduleSettings.lowThresholdColor and self.healthPercentage and self.healthPercentage <= self.moduleSettings.lowThreshold then
+		self.color = "ScaledHealthColor"
 	end

 	if (self.tapped) then
--- a/modules/TargetOfTargetMana.lua
+++ b/modules/TargetOfTargetMana.lua
@ -83,6 +83,8 @@ function TargetTargetMana.prototype:Update(unit)

 	if (self.moduleSettings.scaleManaColor) then
 		self.color = "ScaledManaColor"
+	elseif self.moduleSettings.lowThresholdColor and self.manaPercentage and self.manaPercentage <= self.moduleSettings.lowThreshold then
+		self.color = "ScaledManaColor"
 	end

 	if (manaType == 1) then
--- a/this_version.md
+++ b/this_version.md
@ -1,5 +1,17 @@
 # Changelog

+v1.14.11:
+
+- Packaged a new version of LibDogTag-Unit to fix the Guild roster resetting its scroll position every 20 seconds.
+
+v1.14.10:
+
+- Fix an error in TargetTargetHealth/Mana and CustomHealth when Low Threshold Color was checked and Scale by Health % was un-checked.
+
+v1.14.9:
+
+- Fix Low Threshold to be usable even when Color By Health/Mana % is disabled. (ticket #334)
+
 v1.14.8:

 - Fix Color By Health % to work with Low Threshold Color option. Previously, if Low Threshold was set, the color was always either MaxHealth/MaxMana or MinHealth/MinMana, it would never be colored by health %. Now if both are set, it will scale by health % until it reaches the low threshold, at which point it will switch to the Min color.
Author	SHA1	Message	Date
Parnic	8627ad39d5	Update changelog	2023-01-13 09:34:36 -06:00
Parnic	8c62a841fd	Update changelog	2022-12-19 12:51:51 -06:00
Parnic	7496475ff4	Fix potential nil access I can't reproduce a problem here, but based on some user feedback, this could potentially be an issue. Most other modules are calling the super's Update() first thing, but these modules call them later, so healthPercentage may not be defined at this point.	2022-12-19 12:19:10 -06:00
Parnic	c5c44edf64	Fix several issues with low thresholds This addresses a user-reported issue where Low Threshold was not usable with Color By Health/Mana % disabled, due to some internal technical reasons. This was exacerbated by the recent fix that allowed Low Threshold and Color By Health % to work together. This also fixes the low threshold flash to apply immediately when changing the option, and fixes the Low Threshold % slider to be usable without the Low Flash option set. Finally, it hides the Low Flash option for bars that don't support it (right now that's just PlayerMana, I think because it only sets the low threshold to the Min Mana Color even if the class uses a different power type...something for future me...). Fixes wowace ticket #334	2022-12-13 20:48:02 -06:00