Compare commits

...

2 Commits

Author SHA1 Message Date
8c62a841fd Update changelog 2022-12-19 12:51:51 -06:00
7496475ff4 Fix potential nil access
I can't reproduce a problem here, but based on some user feedback, this could potentially be an issue. Most other modules are calling the super's Update() first thing, but these modules call them later, so healthPercentage may not be defined at this point.
2022-12-19 12:19:10 -06:00
5 changed files with 11 additions and 3 deletions

View File

@ -1,5 +1,9 @@
# Changelog
v1.14.10:
- Fix an error in TargetTargetHealth/Mana and CustomHealth when Low Threshold Color was checked and Scale by Health % was un-checked.
v1.14.9:
- Fix Low Threshold to be usable even when Color By Health/Mana % is disabled. (ticket #334)

View File

@ -144,7 +144,7 @@ function IceCustomHealth.prototype:Update(unit)
if (self.moduleSettings.scaleHealthColor) then
self.color = "ScaledHealthColor"
elseif self.moduleSettings.lowThresholdColor and self.healthPercentage <= self.moduleSettings.lowThreshold then
elseif self.moduleSettings.lowThresholdColor and self.healthPercentage and self.healthPercentage <= self.moduleSettings.lowThreshold then
self.color = "ScaledHealthColor"
end

View File

@ -136,7 +136,7 @@ function TargetTargetHealth.prototype:Update(unit)
if (self.moduleSettings.scaleHealthColor) then
self.color = "ScaledHealthColor"
elseif self.moduleSettings.lowThresholdColor and self.healthPercentage <= self.moduleSettings.lowThreshold then
elseif self.moduleSettings.lowThresholdColor and self.healthPercentage and self.healthPercentage <= self.moduleSettings.lowThreshold then
self.color = "ScaledHealthColor"
end

View File

@ -83,7 +83,7 @@ function TargetTargetMana.prototype:Update(unit)
if (self.moduleSettings.scaleManaColor) then
self.color = "ScaledManaColor"
elseif self.moduleSettings.lowThresholdColor and self.manaPercentage <= self.moduleSettings.lowThreshold then
elseif self.moduleSettings.lowThresholdColor and self.manaPercentage and self.manaPercentage <= self.moduleSettings.lowThreshold then
self.color = "ScaledManaColor"
end

View File

@ -1,5 +1,9 @@
# Changelog
v1.14.10:
- Fix an error in TargetTargetHealth/Mana and CustomHealth when Low Threshold Color was checked and Scale by Health % was un-checked.
v1.14.9:
- Fix Low Threshold to be usable even when Color By Health/Mana % is disabled. (ticket #334)