Compare commits

...

4 Commits

Author SHA1 Message Date
43aa303887 Bump for new dependency versions 2024-08-25 22:46:07 -05:00
30ec3750c1 Fix error when using an invalid spell with a custom bar on 11.x 2024-08-14 11:34:54 -05:00
73891bca4b Update TOC for TWW 2024-08-14 10:20:29 -05:00
66f4492fa7 Fix spell cooldown bars in 11.x
GetSpellCooldown used to return 1 for "has duration", but the new native version returns true. Fun.

Additionally, it looks like the events triggering UpdateCustomBarEvent() are passing a nil argument that the mod thought was supposed to be the affected unit. So I also fixed that, though I don't know if that's an 11.x thing or not.

https://www.wowace.com/projects/ice-hud/issues/363
2024-07-27 15:42:31 -05:00
8 changed files with 67 additions and 11 deletions

View File

@ -1,5 +1,5 @@
## Interface: 110000
## Interface-Retail: 110000
## Interface: 110002
## Interface-Retail: 110002
## Interface-Classic: 11503
## Interface-BCC: 20504
## Interface-Wrath: 30403

View File

@ -1,5 +1,5 @@
## Interface: 110000
## Interface-Retail: 110000
## Interface: 110002
## Interface-Retail: 110002
## Interface-Classic: 11503
## Interface-BCC: 20504
## Interface-Wrath: 30403

View File

@ -1,5 +1,21 @@
# Changelog
v1.15.6:
- Package new version of LibDogTag-Unit to fix an error with some units on 11.0.2
v1.15.5:
- Fix error when using an invalid spell with a custom bar on 11.x
v1.15.4:
- Update TOC for TWW
v1.15.3:
- Fix custom cooldown bars not working in 11.x (wowace issue #363)
v1.15.2:
- Re-enable right-click context menus on 11.x.

View File

@ -20,8 +20,14 @@ end
local GetSpellInfo = GetSpellInfo
if not GetSpellInfo and C_Spell and C_Spell.GetSpellInfo then
GetSpellInfo = function(id)
if not id then
return nil
end
local info = C_Spell.GetSpellInfo(id)
return info.name, nil, info.iconID
if info then
return info.name, nil, info.iconID
end
end
end

View File

@ -30,8 +30,14 @@ end
local GetSpellInfo = GetSpellInfo
if not GetSpellInfo and C_Spell and C_Spell.GetSpellInfo then
GetSpellInfo = function(id)
if not id then
return nil
end
local info = C_Spell.GetSpellInfo(id)
return info.name, nil, info.iconID
if info then
return info.name, nil, info.iconID
end
end
end
@ -637,9 +643,9 @@ function IceCustomCDBar.prototype:GetCooldownDuration(buffName)
local localRemaining = nil
local localStart, localDuration, hasCooldown = GetSpellCooldown(buffName)
if (hasCooldown == 1) then
if hasCooldown then
-- the item has a potential cooldown
if (localDuration <= 1.5) then
if localDuration <= 1.5 then
return nil, nil
end
@ -734,7 +740,7 @@ function IceCustomCDBar.prototype:UpdateItemUnitInventoryChanged(event, unit)
end
function IceCustomCDBar.prototype:UpdateCustomBarEvent(event, unit)
if unit ~= self.unit then
if unit and unit ~= self.unit then
return
end
if not self.moduleSettings.cooldownType or self.moduleSettings.cooldownType == COOLDOWN_TYPE_SPELL then

View File

@ -10,8 +10,14 @@ local DefaultAuraIcon = "Interface\\Icons\\Spell_Frost_Frost"
local GetSpellInfo = GetSpellInfo
if not GetSpellInfo and C_Spell and C_Spell.GetSpellInfo then
GetSpellInfo = function(id)
if not id then
return nil
end
local info = C_Spell.GetSpellInfo(id)
return info.name, nil, info.iconID
if info then
return info.name, nil, info.iconID
end
end
end

View File

@ -9,8 +9,14 @@ end
local GetSpellInfo = GetSpellInfo
if not GetSpellInfo and C_Spell and C_Spell.GetSpellInfo then
GetSpellInfo = function(id)
if not id then
return nil
end
local info = C_Spell.GetSpellInfo(id)
return info.name, nil, info.iconID, info.castTime
if info then
return info.name, nil, info.iconID, info.castTime
end
end
end

View File

@ -1,5 +1,21 @@
# Changelog
v1.15.6:
- Package new version of LibDogTag-Unit to fix an error with some units on 11.0.2
v1.15.5:
- Fix error when using an invalid spell with a custom bar on 11.x
v1.15.4:
- Update TOC for TWW
v1.15.3:
- Fix custom cooldown bars not working in 11.x (wowace issue #363)
v1.15.2:
- Re-enable right-click context menus on 11.x.