Fix 11.1.5 issue, update retail TOC

When a spell is overridden by another, our cooldown bar stops being able to track it. Normally this is fine if the spell completely changes as you probably don't expect a cd bar for Backstab to track Gloomblade.

But when the overridden spell shares the same name as the base spell, such as Fire Breath for Evokers with the Font of Magic talent, you very much would expect the bar to track both.

With this fix, tracking the base spell will show the cd for the overridden version as well.

IceHUD.toc

@@ -1,9 +1,9 @@
-## Interface: 110002
+## Interface: 110105
-## Interface-Retail: 110002
+## Interface-Retail: 110105
-## Interface-Classic: 11503
+## Interface-Classic: 11507
 ## Interface-BCC: 20504
 ## Interface-Wrath: 30403
-## Interface-Cata: 40400
+## Interface-Cata: 40402
 ## Author: Parnic, originally created by Iceroth
 ## Name: IceHUD
 ## Title: IceHUD |cff7fff7f-Ace3-|r
@@ -22,6 +22,18 @@
 ## X-Curse-Project-ID: 5394
 ## X-WoWI-ID: 8149
 ## X-Wago-ID: 5bGolJN0
+## Category-enUS: Unit Frames
+## Category-deDE: Einheitenfenster
+## Category-esES: Marcos de unidades
+## Category-esMX: Marcos de unidades
+## Category-frFR: Portraits d'unités
+## Category-itIT: Riquadri delle unità
+## Category-koKR: 개체창
+## Category-ptBR: Quadros de unidade
+## Category-ruRU: Рамки юнитов
+## Category-zhCN: 单位框体
+## Category-zhTW: 單位框架
+## Group: IceHUD
 
 #@no-lib-strip@
 # Libraries

IceHUD_Options/IceHUD_Options.toc

@@ -1,9 +1,9 @@
-## Interface: 110002
+## Interface: 110105
-## Interface-Retail: 110002
+## Interface-Retail: 110105
-## Interface-Classic: 11503
+## Interface-Classic: 11507
 ## Interface-BCC: 20504
 ## Interface-Wrath: 30403
-## Interface-Cata: 40400
+## Interface-Cata: 40402
 ## Title: IceHUD |cff7fff7f-Options-|r
 ## Author: Parnic
 ## Version: @project-version@
@@ -12,6 +12,18 @@
 ## Dependencies: IceHUD
 ## LoadOnDemand: 1
 ## IconTexture: Interface\Icons\Spell_Frost_Frost
+## Category-enUS: Unit Frames
+## Category-deDE: Einheitenfenster
+## Category-esES: Marcos de unidades
+## Category-esMX: Marcos de unidades
+## Category-frFR: Portraits d'unités
+## Category-itIT: Riquadri delle unità
+## Category-koKR: 개체창
+## Category-ptBR: Quadros de unidade
+## Category-ruRU: Рамки юнитов
+## Category-zhCN: 单位框体
+## Category-zhTW: 單位框架
+## Group: IceHUD
 
 Json.lua
 JsonDecode.lua

IceHUD_Options/Options.lua

@@ -830,10 +830,11 @@ function IceHUD_Options:SetupProfileImportButtons()
 					if err ~= nil then
 						print("failed to import profile: "..err)
 					else
-						print("importing profile")
+						-- print("importing profile")
 						IceHUD:PreProfileChanged()
 						IceHUD:populateDefaults(newTable, IceHUD.IceCore.defaults.profile)
 						IceHUD.db.profile = IceHUD.deepcopy(newTable)
+						IceHUD.db.profiles[IceHUD.db:GetCurrentProfile()] = IceHUD.db.profile
 						IceHUD:PostProfileChanged()
 					end
 					AceGUI:Release(widget)

changelog.md

@@ -1,5 +1,41 @@
 # Changelog
 
+v1.15.14:
+
+- Support WoW 11.1.5
+- Update TWW TOC to 11.1.5
+
+v1.15.13:
+
+- Update TOCs
+
+v1.15.12:
+
+- Update TOCs
+
+v1.15.11:
+
+- Fix imported profiles not saving across reloads
+
+v1.15.10:
+
+- Fix Chi not updating properly when the player's maximum amount of Chi points changes (e.g. via Ascension talent).
+- Update TOCs
+
+v1.15.9:
+
+- Update Cataclysm Classic TOC to 4.4.1
+- Update Classic-era TOC to 1.15.4
+- Update TWW TOC to 11.0.5
+
+v1.15.8:
+
+- Fix reported error with custom cooldown bars set to "when ready" mode due to deprecation in 11.x (wowace issue #368)
+
+v1.15.7:
+
+- Fix cooldown display for overridden spells (such as Evoker spells where Font of Magic replaces the base spell with an override with the same name).
+
 v1.15.6:
 
 - Package new version of LibDogTag-Unit to fix an error with some units on 11.0.2
@@ -117,7 +153,7 @@ v1.14.23:
 
 v1.14.22:
 
-- Fixed reported issue with a Lua error on Wrath Classic clients. https://www.wowace.com/projects/ice-hud/issues/344
+- Fixed reported issue with a Lua error on Wrath Classic clients. <https://www.wowace.com/projects/ice-hud/issues/344>
 - Fixed Vigor module not working when riding Grotto Netherwing Drake (and theoretically all future Dragonriding mount types).
 - Updated TOC for Wrath-Classic.
 
@@ -538,7 +574,7 @@ v1.10.13:
 
 v1.10.12:
 
-- Tweaked a few Druid CCs in the CC modules. If you've got a more up-to-date list of any of the CCs, please send them along to icehud@parnic.com
+- Tweaked a few Druid CCs in the CC modules. If you've got a more up-to-date list of any of the CCs, please send them along to <icehud@parnic.com>
 - Fixed a problem that could cause a custom counter to loop forever and cause framerate problems. (ticket #230)
 - Updated default text values for Health and Mana modules to show values in shortened form so they're more readable. Anyone who has customized their text will not be affected by this change and the shortened form only kicks in once values reach 10,000.
 
@@ -1555,7 +1591,7 @@ v1.3.17:
 - fixed <http://www.wowace.com/projects/ice-hud/tickets/8-module-target-info-long-targetnames-overwrites-the/> : target name in the TargetInfo module no longer spills to the next line or gets cut off if it's too long
 - made the threat module only display while the player is in combat or the player has some threat on his target
 - added an option to only display the threat module while in a group. set by default
-- adding HungerForBlood user-submitted module. I don't have an assassination rogue and don't plan on having one, so this is _untested_ by me. the author is responsible for fixing bugs in it
+- adding HungerForBlood user-submitted module. I don't have an assassination rogue and don't plan on having one, so this is *untested* by me. the author is responsible for fixing bugs in it
 - also updated a few settings in SliceAndDice to conform with the rest of the mod
 - fix for malygos fight where the player uses combo points while in a vehicle
 - made runes flash when they become active whether the cooldown or alpha setting is being used

modules/CustomCDBar.lua

@@ -36,7 +36,7 @@ if not GetSpellInfo and C_Spell and C_Spell.GetSpellInfo then
 
 		local info = C_Spell.GetSpellInfo(id)
 		if info then
-			return info.name, nil, info.iconID
+			return info.name, nil, info.iconID, info.spellID
 		end
 	end
 end
@@ -61,6 +61,11 @@ if not IsUsableSpell and C_Spell then
 	IsUsableSpell = C_Spell.IsSpellUsable
 end
 
+local SpellHasRange = SpellHasRange
+if not SpellHasRange and C_Spell then
+	SpellHasRange = C_Spell.SpellHasRange
+end
+
 IceCustomCDBar.prototype.cooldownDuration = 0
 IceCustomCDBar.prototype.cooldownEndTime = 0
 IceCustomCDBar.prototype.coolingDown = false
@@ -636,8 +641,18 @@ end
 
 -- 'Protected' methods --------------------------------------------------------
 
+function IceCustomCDBar.prototype:GetCooldownDurationOverride(spellID)
+	if spellID and FindSpellOverrideByID then
+		local override = FindSpellOverrideByID(spellID)
+		if override and override ~= spellID then
+			return self:GetCooldownDuration(override)
+		end
+	end
+end
+
 function IceCustomCDBar.prototype:GetCooldownDuration(buffName)
-	buffName = self:GetSpellNameOrId(buffName)
+	local spellID
+	buffName, spellID = self:GetSpellNameOrId(buffName)
 
 	local now = GetTime()
 	local localRemaining = nil
@@ -646,7 +661,7 @@ function IceCustomCDBar.prototype:GetCooldownDuration(buffName)
 	if hasCooldown then
 		-- the item has a potential cooldown
 		if localDuration <= 1.5 then
-			return nil, nil
+			return self:GetCooldownDurationOverride(spellID)
 		end
 
 		localRemaining = localDuration + (localStart - now)
@@ -657,7 +672,7 @@ function IceCustomCDBar.prototype:GetCooldownDuration(buffName)
 
 		return localDuration, localRemaining
 	else
-		return nil, nil
+		return self:GetCooldownDurationOverride(spellID)
 	end
 end
 
@@ -868,7 +883,8 @@ function IceCustomCDBar.prototype:IsReady()
 end
 
 function IceCustomCDBar.prototype:GetSpellNameOrId(spellName)
-	return spellName
+	local id = select(4, GetSpellInfo(spellName))
+	return spellName, id
 end
 
 function IceCustomCDBar.prototype:Show(bShouldShow, bForceHide)

modules/HarmonyPower.lua

@@ -40,6 +40,13 @@ function HarmonyPower.prototype:Enable(core)
 	HarmonyPower.super.prototype.Enable(self, core)
 
 	self:RegisterEvent("UNIT_POWER_FREQUENT", "UpdateRunePower")
+	if IceHUD.EventExistsUnitMaxPower then
+		self:RegisterEvent("UNIT_MAXPOWER", "PlayerChiUpdate")
+	end
+end
+
+function HarmonyPower.prototype:PlayerChiUpdate()
+	self:Redraw()
 end
 
 function HarmonyPower.prototype:UpdateRunePower(event, arg1, arg2)

modules/RollTheBones.lua

@@ -477,7 +477,11 @@ function RollTheBones.prototype:GetItemIdFromItemLink(linkStr)
   local _
 
   if linkStr then
-    _, itemId, _, _, _, _, _, _, _ = strsplit(":", linkStr)
+    _, itemId, itemId2, _, _, _, _, _, _ = strsplit(":", linkStr)
+  end
+
+  if not tonumber(itemId) then
+    itemId = itemId2
   end
 
   return itemId or 0

modules/SliceAndDice.lua

@@ -532,7 +532,11 @@ function SliceAndDice.prototype:GetItemIdFromItemLink(linkStr)
 	local _
 
 	if linkStr then
-		_, itemId, _, _, _, _, _, _, _ = strsplit(":", linkStr)
+		_, itemId, itemId2, _, _, _, _, _, _ = strsplit(":", linkStr)
+	end
+
+	if not tonumber(itemId) then
+		itemId = itemId2
 	end
 
 	return itemId or 0

this_version.md

@@ -1,5 +1,41 @@
 # Changelog
 
+v1.15.14:
+
+- Support WoW 11.1.5
+- Update TWW TOC to 11.1.5
+
+v1.15.13:
+
+- Update TOCs
+
+v1.15.12:
+
+- Update TOCs
+
+v1.15.11:
+
+- Fix imported profiles not saving across reloads
+
+v1.15.10:
+
+- Fix Chi not updating properly when the player's maximum amount of Chi points changes (e.g. via Ascension talent).
+- Update TOCs
+
+v1.15.9:
+
+- Update Cataclysm Classic TOC to 4.4.1
+- Update Classic-era TOC to 1.15.4
+- Update TWW TOC to 11.0.5
+
+v1.15.8:
+
+- Fix reported error with custom cooldown bars set to "when ready" mode due to deprecation in 11.x (wowace issue #368)
+
+v1.15.7:
+
+- Fix cooldown display for overridden spells (such as Evoker spells where Font of Magic replaces the base spell with an override with the same name).
+
 v1.15.6:
 
 - Package new version of LibDogTag-Unit to fix an error with some units on 11.0.2