Fix Charged point support in ComboPointsBar

There are controls on the player castbar module for flashing when a spell succeeds or fails, and separate controls for flashing when an instant cast completes. Those were broken (flashing never happened), but now work again.

UpdateBar() was necessary in MyOnUpdate() in the event that no other spell has been cast (in order to set the alpha so that the bottom text displays). The spellId is being passed along so that spells that aren't currently being cast can have their name and icon displayed appropriately, and so the early-out for "no known spell" doesn't trigger (which allows the Flash to actually work). The self.current reset fixes instant casts after a normal cast (we were only clearing the "current" spell conditionally when we only meant to filter StopBar, so if it wasn't cleared, future successful casts thought they were for a different spell than was currently being cast.

.pkgmeta

@@ -37,6 +37,9 @@ externals:
     libs/AceLocale-3.0:
         url: svn://svn.wowace.com/wow/ace3/mainline/trunk/AceLocale-3.0
         tag: latest
+    libs/AceHook-3.0:
+        url: svn://svn.wowace.com/wow/ace3/mainline/trunk/AceHook-3.0
+        tag: latest
     libs/LibRangeCheck-2.0:
         url: https://github.com/WeakAuras/LibRangeCheck-2.0/
     libs/LibSharedMedia-3.0:
@@ -65,6 +68,8 @@ tools-used:
 
 ignore:
     - readme.md
+    - FUNDING.yml
+    - this_version.md
 
 manual-changelog: this_version.md
 

FUNDING.yml

@@ -0,0 +1,3 @@
+github: parnic
+ko_fi: parnic
+custom: "https://www.paypal.me/parnic"

IceCastBar.lua

@@ -3,7 +3,7 @@ IceCastBar = IceCore_CreateClass(IceBarElement)
 
 local IceHUD = _G.IceHUD
 
-IceCastBar.Actions = { None = 0, Cast = 1, Channel = 2, Instant = 3, Success = 4, Failure = 5 }
+IceCastBar.Actions = { None = 0, Cast = 1, Channel = 2, Instant = 3, Success = 4, Failure = 5, ReverseChannel = 6 }
 
 IceCastBar.prototype.action = nil
 IceCastBar.prototype.actionStartTime = nil
@@ -49,6 +49,13 @@ function IceCastBar.prototype:init(name)
 	self:SetDefaultColor("CastChanneling", 242, 242, 10)
 	self:SetDefaultColor("CastSuccess", 242, 242, 70)
 	self:SetDefaultColor("CastFail", 1, 0, 0)
+	if GetUnitEmpowerMinHoldTime then
+		self:SetDefaultColor("EmpowerStage0", 165, 165, 165)
+		self:SetDefaultColor("EmpowerStage1", 242, 42, 10)
+		self:SetDefaultColor("EmpowerStage2", 242, 142, 10)
+		self:SetDefaultColor("EmpowerStage3", 242, 242, 10)
+		self:SetDefaultColor("EmpowerStage4", 242, 242, 242)
+	end
 	self.unit = "player"
 
 	self.delay = 0
@@ -109,6 +116,12 @@ function IceCastBar.prototype:Enable(core)
 		self:RegisterEvent("UNIT_SPELLCAST_CHANNEL_UPDATE", "SpellCastChannelUpdate") -- unit, spell, rank
 		self:RegisterEvent("UNIT_SPELLCAST_CHANNEL_STOP", "SpellCastChannelStop") -- unit, spell, rank
 
+		if GetUnitEmpowerHoldAtMaxTime then
+			self:RegisterEvent("UNIT_SPELLCAST_EMPOWER_START", "SpellCastChannelStart")
+			self:RegisterEvent("UNIT_SPELLCAST_EMPOWER_UPDATE", "SpellCastChannelUpdate")
+			self:RegisterEvent("UNIT_SPELLCAST_EMPOWER_STOP", "SpellCastChannelStop")
+		end
+
 	end
 	self:Show(false)
 end
@@ -311,7 +324,13 @@ function IceCastBar.prototype:PositionIcons()
 	self.barFrame.icon:SetHeight(AuraIconHeight * self.moduleSettings.auraIconScale)
 end
 
+function IceCastBar.prototype:GetRemainingCastTime()
+	return self.actionStartTime + self.actionDuration - GetTime()
+end
 
+function IceCastBar.prototype:GetCurrentCastDurationMs()
+	return (GetTime() - (self.actionStartTime or GetTime())) * 1000
+end
 
 -- OnUpdate handler
 function IceCastBar.prototype:MyOnUpdate()
@@ -322,17 +341,15 @@ function IceCastBar.prototype:MyOnUpdate()
 		return
 	end
 
-	local time = GetTime()
-
 	self:Update()
 	self:SetTextAlpha()
 
 	-- handle casting and channeling
-	if (self.action == IceCastBar.Actions.Cast or self.action == IceCastBar.Actions.Channel) then
-		local remainingTime = self.actionStartTime + self.actionDuration - time
+	if (self.action == IceCastBar.Actions.Cast or self.action == IceCastBar.Actions.Channel or self.action == IceCastBar.Actions.ReverseChannel) then
+		local remainingTime = self:GetRemainingCastTime()
 		local scale = 1 - (self.actionDuration ~= 0 and remainingTime / self.actionDuration or 0)
 
-		if (self.moduleSettings.reverseChannel and self.action == IceCastBar.Actions.Channel) then
+		if self.action == IceCastBar.Actions.ReverseChannel then
 			scale = self.actionDuration ~= 0 and remainingTime / self.actionDuration or 0
 		end
 
@@ -343,14 +360,22 @@ function IceCastBar.prototype:MyOnUpdate()
 		end
 
 		local timeString = self.moduleSettings.showCastTime and string.format("%.1fs ", remainingTime) or ""
-		self:SetBottomText1(timeString .. self.actionMessage)
+		local empowerString = self.NumStages ~= nil and (L["Stage %d"]):format(self:GetCurrentStage()) or ""
+		local line1 = timeString .. self.actionMessage
+		if self.moduleSettings.empowerStageTextDisplay == "TOPLINE" then
+			line1 = line1 .. " " .. empowerString
+		end
+		if self.moduleSettings.empowerStageTextDisplay == "BOTTOMLINE" then
+			self:SetBottomText2(empowerString)
+		end
+		self:SetBottomText1(line1)
 
 		return
 	end
 
 
 	-- stop bar if casting or channeling is done (in theory this should not be needed)
-	if (self.action == IceCastBar.Actions.Cast or self.action == IceCastBar.Actions.Channel) then
+	if (self.action == IceCastBar.Actions.Cast or self.action == IceCastBar.Actions.Channel or self.action == IceCastBar.Actions.ReverseChannel) then
 		self:StopBar()
 		return
 	end
@@ -361,13 +386,15 @@ function IceCastBar.prototype:MyOnUpdate()
 		self.action == IceCastBar.Actions.Success or
 		self.action == IceCastBar.Actions.Failure)
 	then
-		local scale = time - self.actionStartTime
+		local scale = GetTime() - self.actionStartTime
 
 		if (scale > 1) then
 			self:StopBar()
 			return
 		end
 
+		self:UpdateBar(1, self:GetCurrentCastingColor())
+
 		if (self.action == IceCastBar.Actions.Failure) then
 			self:FlashBar("CastFail", 1-scale, self.actionMessage, "CastFail")
 		else
@@ -381,12 +408,60 @@ function IceCastBar.prototype:MyOnUpdate()
 	self:StopBar()
 end
 
-function IceCastBar.prototype:GetCurrentCastingColor()
-	local updateColor = "CastCasting"
-	if self.action == IceCastBar.Actions.Channel then
-		updateColor = "CastChanneling"
+function IceCastBar.prototype:GetStageDuration(stage)
+	if not GetUnitEmpowerMinHoldTime then
+		return 0
 	end
-	return updateColor
+
+	if stage == 0 then
+		return GetUnitEmpowerMinHoldTime(self.unit)
+	end
+
+	return GetUnitEmpowerStageDuration(self.unit, stage);
+end
+
+function IceCastBar.prototype:GetDurationUpToStage(stage)
+	if stage == nil or stage < 0 then
+		return 0
+	end
+
+	local total = 0
+	for i=0,stage-1 do
+		total = total + self:GetStageDuration(i)
+	end
+
+	return total
+end
+
+function IceCastBar.prototype:GetCurrentStage()
+	if not GetUnitEmpowerMinHoldTime then
+		return 0
+	end
+
+	local castDuration = self:GetCurrentCastDurationMs()
+	for i=1,self.NumStages do
+		if castDuration < self:GetDurationUpToStage(i) then
+			return i - 1
+		end
+	end
+
+	return self.NumStages
+end
+
+function IceCastBar.prototype:IsCastingEmpowerSpell()
+	return self.NumStages ~= nil
+end
+
+function IceCastBar.prototype:GetCurrentCastingColor()
+	if self:IsCastingEmpowerSpell() then
+		return ("EmpowerStage%d"):format(self:GetCurrentStage())
+	end
+
+	if self.action == IceCastBar.Actions.Channel or self.action == IceCastBar.Actions.ReverseChannel then
+		return "CastChanneling"
+	end
+
+	return "CastCasting"
 end
 
 function IceCastBar.prototype:FlashBar(color, alpha, text, textColor)
@@ -405,8 +480,8 @@ function IceCastBar.prototype:FlashBar(color, alpha, text, textColor)
 end
 
 
-function IceCastBar.prototype:StartBar(action, message)
-	local spell, rank, displayName, icon, startTime, endTime, isTradeSkill
+function IceCastBar.prototype:StartBar(action, message, spellId)
+	local spell, rank, displayName, icon, startTime, endTime, isTradeSkill, numStages
 	if IceHUD.SpellFunctionsReturnRank then
 		spell, rank, displayName, icon, startTime, endTime, isTradeSkill = UnitCastingInfo(self.unit)
 	else
@@ -416,7 +491,28 @@ function IceCastBar.prototype:StartBar(action, message)
 		if IceHUD.SpellFunctionsReturnRank then
 			spell, rank, displayName, icon, startTime, endTime = UnitChannelInfo(self.unit)
 		else
-			spell, displayName, icon, startTime, endTime = UnitChannelInfo(self.unit)
+			spell, displayName, icon, startTime, endTime, isTradeSkill, _, _, _, numStages = UnitChannelInfo(self.unit)
+		end
+	end
+
+	if spellId and not spell then
+		spell, rank, icon = GetSpellInfo(spellId)
+	end
+
+	local isChargeSpell = numStages and numStages > 0
+	if isChargeSpell then
+		self.NumStages = numStages
+		endTime = endTime + GetUnitEmpowerHoldAtMaxTime(self.unit)
+		action = IceCastBar.Actions.ReverseChannel
+	else
+		self.NumStages = nil
+	end
+
+	if self.moduleSettings.reverseChannel then
+		if action == IceCastBar.Actions.Channel then
+			action = IceCastBar.Actions.ReverseChannel
+		elseif action == IceCastBar.Actions.ReverseChannel then
+			action = IceCastBar.Actions.Channel
 		end
 	end
 
@@ -424,7 +520,7 @@ function IceCastBar.prototype:StartBar(action, message)
 	if LibClassicCasterino and not spell then
 		self:StopBar()
 	elseif not spell then
-	  return
+		return
 	end
 
 	if icon ~= nil then
@@ -465,6 +561,7 @@ function IceCastBar.prototype:StopBar()
 	self.actionDuration = nil
 
 	self:SetBottomText1()
+	self:SetBottomText2()
 	self:SetScale(0)
 	self:Show(false)
 end
@@ -499,7 +596,7 @@ function IceCastBar.prototype:SpellCastStart(event, unit, castGuid, spellId)
 	IceHUD:Debug("SpellCastStart", unit, castGuid, spellId)
 	--UnitCastingInfo(unit)
 
-	self:StartBar(IceCastBar.Actions.Cast)
+	self:StartBar(IceCastBar.Actions.Cast, nil, spellId)
 	self.current = castGuid
 end
 
@@ -514,11 +611,13 @@ function IceCastBar.prototype:SpellCastStop(event, unit, castGuid, spellId)
 
 	if (self.action ~= IceCastBar.Actions.Success and
 		self.action ~= IceCastBar.Actions.Failure and
-		self.action ~= IceCastBar.Actions.Channel)
+		self.action ~= IceCastBar.Actions.Channel and
+		self.action ~= IceCastBar.Actions.ReverseChannel)
 	then
 		self:StopBar()
-		self.current = nil
 	end
+
+	self.current = nil
 end
 
 
@@ -532,7 +631,7 @@ function IceCastBar.prototype:SpellCastFailed(event, unit, castGuid, spellId)
 	end
 
 	-- channeled spells will call ChannelStop, not cast failed
-	if self.action == IceCastBar.Actions.Channel then
+	if self.action == IceCastBar.Actions.Channel or self.action == IceCastBar.Actions.ReverseChannel then
 		return
 	end
 
@@ -547,7 +646,7 @@ function IceCastBar.prototype:SpellCastFailed(event, unit, castGuid, spellId)
 		end
 	end
 
-	self:StartBar(IceCastBar.Actions.Failure, "Failed")
+	self:StartBar(IceCastBar.Actions.Failure, "Failed", nil, spellId)
 end
 
 function IceCastBar.prototype:SpellCastInterrupted(event, unit, castGuid, spellId)
@@ -561,7 +660,7 @@ function IceCastBar.prototype:SpellCastInterrupted(event, unit, castGuid, spellI
 
 	self.current = nil
 
-	self:StartBar(IceCastBar.Actions.Failure, "Interrupted")
+	self:StartBar(IceCastBar.Actions.Failure, "Interrupted", spellId)
 end
 
 function IceCastBar.prototype:SpellCastDelayed(event, unit, castGuid, spellId)
@@ -582,7 +681,7 @@ function IceCastBar.prototype:SpellCastSucceeded(event, unit, castGuid, spellId)
 	--IceHUD:Debug("SpellCastSucceeded", unit, castGuid, spellId)
 
 	-- never show on channeled (why on earth does this event even fire when channeling starts?)
-	if (self.action == IceCastBar.Actions.Channel) then
+	if (self.action == IceCastBar.Actions.Channel or self.action == IceCastBar.Actions.ReverseChannel) then
 		return
 	end
 
@@ -595,7 +694,7 @@ function IceCastBar.prototype:SpellCastSucceeded(event, unit, castGuid, spellId)
 
 	-- show after normal successfull cast
 	if (self.action == IceCastBar.Actions.Cast) then
-		self:StartBar(IceCastBar.Actions.Success, spell.. self:GetShortRank(rank))
+		self:StartBar(IceCastBar.Actions.Success, spell.. self:GetShortRank(rank), spellId)
 		return
 	end
 
@@ -608,7 +707,7 @@ function IceCastBar.prototype:SpellCastSucceeded(event, unit, castGuid, spellId)
 		end
 	end
 
-	self:StartBar(IceCastBar.Actions.Success, spell.. self:GetShortRank(rank))
+	self:StartBar(IceCastBar.Actions.Success, spell.. self:GetShortRank(rank), spellId)
 end
 
 

IceCore.lua

@@ -284,6 +284,8 @@ function IceCore.prototype:Enable(userToggle)
 		self.IceHUDFrame:RegisterEvent("ZONE_CHANGED")
 	end
 	self.IceHUDFrame:RegisterEvent("UNIT_AURA")
+	self.IceHUDFrame:RegisterEvent("PLAYER_REGEN_ENABLED", IceHUD.PLAYER_REGEN_ENABLED)
+	self.IceHUDFrame:RegisterEvent("PLAYER_REGEN_DISABLED", IceHUD.PLAYER_REGEN_DISABLED)
 	self.IceHUDFrame:SetScript("OnEvent", function(self, event, ...)
 		if (event == "PET_BATTLE_OPENING_START") then
 			if IceHUD.IceCore.settings.bHideDuringPetBattles then

IceHUD.lua

@@ -1,5 +1,5 @@
 local L = LibStub("AceLocale-3.0"):GetLocale("IceHUD", false)
-IceHUD = LibStub("AceAddon-3.0"):NewAddon("IceHUD", "AceConsole-3.0")
+IceHUD = LibStub("AceAddon-3.0"):NewAddon("IceHUD", "AceConsole-3.0", "AceHook-3.0")
 
 local IceHUD = IceHUD
 
@@ -36,6 +36,7 @@ else
 end
 
 -- compatibility/feature flags
+IceHUD.GetPlayerAuraBySpellID = _G["C_UnitAuras"] and C_UnitAuras.GetPlayerAuraBySpellID
 IceHUD.SpellFunctionsReturnRank = IceHUD.WowMain and IceHUD.WowVer < 80000
 IceHUD.EventExistsPlayerPetChanged = IceHUD.WowMain and IceHUD.WowVer < 80000
 IceHUD.EventExistsPetBarChanged = IceHUD.WowMain and IceHUD.WowVer < 80000
@@ -494,6 +495,16 @@ function IceHUD:GetAuraCount(auraType, unit, ability, onlyMine, matchByName)
 		return 0
 	end
 
+	-- Support for Spell IDs
+	if (IceHUD.GetPlayerAuraBySpellID and tonumber(ability) ~= nil) then
+		local aura = C_UnitAuras.GetPlayerAuraBySpellID(ability)
+		if aura ~= nil then
+			return aura.applications
+		else
+			return 0
+		end
+	end
+
 	local i = 1
 	local name, _, texture, applications
 	if IceHUD.SpellFunctionsReturnRank then
@@ -963,3 +974,53 @@ UIDropDownMenu_Initialize(IceHUD_UnitFrame_DropDown, function()
 		UnitPopup_ShowMenu(IceHUD_UnitFrame_DropDown, menu, IceHUD.DropdownUnit, nil, id)
 	end
 end, "MENU", nil)
+
+function IceHUD:OutOfCombatWrapper(func)
+	return function(...)
+		return IceHUD:RunOnLeaveCombat(func, ...)
+	end
+end
+
+do
+	local in_combat = false
+	local in_lockdown = false
+	local actions_to_perform = {}
+	local pool = setmetatable({}, {__mode='k'})
+	function IceHUD:PLAYER_REGEN_ENABLED()
+		in_combat = false
+		in_lockdown = false
+		for i, t in ipairs(actions_to_perform) do
+			t.f(unpack(t, 1, t.n))
+			actions_to_perform[i] = nil
+			wipe(t)
+			pool[t] = true
+		end
+	end
+	function IceHUD:PLAYER_REGEN_DISABLED()
+		in_combat = true
+	end
+	function IceHUD:RunOnLeaveCombat(func, ...)
+		if not in_combat then
+			-- out of combat, call right away and return
+			func(...)
+			return
+		end
+		if not in_lockdown then
+			in_lockdown = InCombatLockdown() -- still in PLAYER_REGEN_DISABLED
+			if not in_lockdown then
+				func(...)
+				return
+			end
+		end
+		local t = next(pool) or {}
+		pool[t] = nil
+
+		t.f = func
+		local n = select('#', ...)
+		t.n = n
+		for i = 1, n do
+			t[i] = select(i, ...)
+		end
+		actions_to_perform[#actions_to_perform+1] = t
+	end
+end

IceHUD.toc

@@ -1,5 +1,5 @@
-## Interface: 100000
-## Interface-Retail: 100000
+## Interface: 100002
+## Interface-Retail: 100002
 ## Interface-Classic: 11403
 ## Interface-BCC: 20504
 ## Interface-Wrath: 30400
@@ -99,6 +99,7 @@ modules\Stagger.lua
 modules\PlayerAltMana.lua
 modules\ArcaneCharges.lua
 modules\RollTheBones.lua
+modules\EssencePower.lua
 
 #@do-not-package@
 IceHUD_Options\Json.lua

IceHUD_Options/IceHUD_Options.toc

@@ -1,5 +1,5 @@
-## Interface: 100000
-## Interface-Retail: 100000
+## Interface: 100002
+## Interface-Retail: 100002
 ## Interface-Classic: 11403
 ## Interface-BCC: 20504
 ## Interface-Wrath: 30400

IceHUD_Options/Options.lua

@@ -85,13 +85,13 @@ If you have |cff42ffffDogTags|r enabled, you can open the Text Settings for the
 This is a side effect of the animation API that I'm co-opting to force a rotation without having to provide duplicates of every bar texture in the mod. Any bar moving sufficiently quickly and updating rapidly will cause this. |cff9999ffIceHUD|r is intended to be a vertically-oriented mod, so the rotation feature is there for people who are willing to accept the side effects that come with it. My suggestion is to use one of the many horizontally-oriented bar mods out there if you're wanting horizontal bars. |cff42ffffQuartz|r is a good castbar replacement that you can use and disable |cff9999ffIceHUD|r's built-in castbar, for example.
 
 |cff9999ff18. How do I get rid of the bars that showed up beneath the player in the 7.0 patch?|r
-Blizzard added a "Personal Resource Display" feature in the 7.0 game client. You can disable it in the Game options -> Interface -> Names -> Personal Resource Display.
+Blizzard added a "Personal Resource Display" feature in the 7.0 game client. You can disable it in the Game options -> |cffffdc42Interface|r -> |cffffdc42Names|r -> |cffffdc42Personal Resource Display|r (or Options -> |cffffdc42Combat|r -> |cffffdc42Personal Resource Display|r, in 10.0+).
 
 |cff9999ff19. Why is there no target castbar for Classic?|r
-The Classic game client doesn't offer a reliable way to show castbars for anyone except the player. You can install the LibCasterCasterino addon to enable support, but it's a best guess and not at all accurate.
+The Classic game client doesn't offer a reliable way to show castbars for anyone except the player. You can install the |cff42ffffLibCasterCasterino|r addon to enable support, but it's a best guess and not at all accurate.
 
 |cff9999ff20. Why do buff/debuff timers not work in Classic?|r
-The Classic game client doesn't provide this information to addons because it wasn't a feature when the game first released. You can install the LibClassicDurations addon to enable support, but it's a best guess and not at all accurate.]]
+The Classic game client doesn't provide this information to addons because it wasn't a feature when the game first released. You can install the |cff42ffffLibClassicDurations|r addon to enable support, but it's a best guess and not at all accurate.]]
 				}
 			}
 		},

IceStackCounter.lua

@@ -52,7 +52,13 @@ function IceStackCounter_GetOptions(frame, opts)
 	opts["auraName"] = {
 		type = 'input',
 		name = L["Aura to track"],
-		desc = L["Which buff/debuff this counter will be tracking. \n\nRemember to press ENTER after filling out this box with the name you want or it will not save."],
+		desc = function()
+			if IceHUD.GetPlayerAuraBySpellID then
+				return L["Which buff/debuff this counter will be tracking. Can use the name or spell id. \n\nRemember to press ENTER after filling out this box with the name you want or it will not save."]
+			else
+				return L["Which buff/debuff this counter will be tracking. \n\nRemember to press ENTER after filling out this box with the name you want or it will not save."]
+			end
+		end,
 		get = function()
 			return frame.moduleSettings.auraName
 		end,

LICENSE

@@ -1,6 +1,6 @@
 MIT License
 
-Copyright (c) 2021 parnic
+Copyright (c) 2021-2022 parnic
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal

changelog.md

@@ -1,5 +1,34 @@
 # Changelog
 
+v1.14.5:
+
+- Fix castbar flashing. There are controls on the player castbar module for flashing when a spell succeeds or fails, and separate controls for flashing when an instant cast completes. Those were broken, but now work again.
+- Add "@" after the number when the Combo Points module is in Numeric mode, "Show Charged points" is enabled, and the current combo point is charged.
+- Fix Charged point support in the ComboPointsBar module.
+
+v1.14.4:
+
+- Update TOC for 10.0.2
+
+v1.14.3:
+
+- Add Spell ID support for aura tracking.
+- Add Evoker support.
+- Add Empowered Casting (hold-to-cast levels) support.
+
+v1.14.2:
+
+- Fix CC and Invuln modules not showing immediately when they should.
+
+v1.14.1:
+
+- Fix Hide Party feature on pre-10.0 clients.
+
+v1.14.0:
+
+- 10.0 compatibility
+- Renamed Anima Charged combo points to Charged, and removed specific references to Kyrian.
+
 v1.13.17.3:
 
 - Packaged latest LibDogTag-Unit to work around crash in Wrath Classic client.

embeds.xml

@@ -11,6 +11,7 @@
 	<Include file="libs\AceConsole-3.0\AceConsole-3.0.xml"/>
 	<Include file="libs\AceAddon-3.0\AceAddon-3.0.xml"/>
 	<Include file="libs\AceLocale-3.0\AceLocale-3.0.xml"/>
+	<Include file="libs\AceHook-3.0\AceHook-3.0.xml"/>
 	<Include file="libs\LibDogTag-3.0\lib.xml"/>
 	<Include file="libs\LibDogTag-Unit-3.0\lib.xml"/>
 	<Script file="libs\LibRangeCheck-2.0\LibRangeCheck-2.0.lua"/>

modules/CastBar.lua

@@ -39,6 +39,9 @@ function CastBar.prototype:GetDefaultSettings()
 	settings["rangeColor"] = true
 	settings["bAllowExpand"] = false
 	settings["respectLagTolerance"] = true
+	settings["lockUpperTextAlpha"] = true
+	settings["lockLowerTextAlpha"] = true
+	settings["empowerStageTextDisplay"] = "TOPLINE"
 
 	return settings
 end
@@ -236,6 +239,7 @@ function CastBar.prototype:GetOptions()
 				end,
 				set = function(info, v)
 					self.moduleSettings.lockUpperTextAlpha = v
+					self.moduleSettings.lockLowerTextAlpha = v
 					self:Redraw()
 				end,
 				order = 13
@@ -308,7 +312,26 @@ function CastBar.prototype:GetOptions()
 				disabled = function()
 					return not self.moduleSettings.enabled
 				end,
-			}
+			},
+
+			empowerStageText = {
+				type = 'select',
+				name = L["Empower stage label display"],
+				desc = L["How to display the stage of an empowered spell"],
+				get = function()
+					return self.moduleSettings.empowerStageTextDisplay
+				end,
+				set = function(info, value)
+					self.moduleSettings.empowerStageTextDisplay = value
+				end,
+				values = { NONE = L["Don't show"], TOPLINE = L["After spell name"], BOTTOMLINE = L["Below spell name"] },
+				disabled = function()
+					return not self.moduleSettings.enabled
+				end,
+				hidden = function()
+					return not GetUnitEmpowerMinHoldTime
+				end,
+			},
 		}
 	}
 

modules/ClassPowerCounter.lua

@@ -462,10 +462,14 @@ function IceClassPowerCounter.prototype:CheckValidSpec()
 	end
 end
 
+function IceClassPowerCounter.prototype:GetPowerEvent()
+	return IceHUD.UnitPowerEvent
+end
+
 function IceClassPowerCounter.prototype:DisplayCounter()
 	self:UnregisterEvent("PLAYER_LEVEL_UP")
 
-	self:RegisterEvent(IceHUD.UnitPowerEvent, "UpdateRunePower")
+	self:RegisterEvent(self:GetPowerEvent(), "UpdateRunePower")
 	self:RegisterEvent("UNIT_DISPLAYPOWER", "UpdateRunePower")
 	self:RegisterEvent("PLAYER_ENTERING_WORLD", "EnteringWorld")
 	if IceHUD.EventExistsUnitMaxPower then
@@ -493,7 +497,7 @@ function IceClassPowerCounter.prototype:EnteringWorld()
 end
 
 function IceClassPowerCounter.prototype:UpdateRunePower(event, arg1, arg2)
-	if event and (event == IceHUD.UnitPowerEvent or event == "UNIT_POWER_FREQUENT") and arg1 ~= "player" and arg1 ~= "vehicle" then
+	if event and (event == self:GetPowerEvent() or event == "UNIT_POWER_FREQUENT") and arg1 ~= "player" and arg1 ~= "vehicle" then
 		return
 	end
 

modules/ComboPoints.lua

@@ -545,6 +545,9 @@ function ComboPoints.prototype:UpdateComboPoints(...)
 		self.frame.numeric:SetTextColor(r, g, b, 0.7)
 
 		local pointsText = tostring(points)
+		if self.moduleSettings.bShowCharged and self:IsChargedPoint(points) then
+			pointsText = pointsText.."@"
+		end
 		if anticipate > 0 then
 			pointsText = pointsText.."+"..tostring(anticipate)
 		end

modules/ComboPointsBar.lua

@@ -11,6 +11,7 @@ function ComboPointsBar.prototype:init()
 
 	self:SetDefaultColor("ComboPointsBarMin", 1, 1, 0)
 	self:SetDefaultColor("ComboPointsBarMax", 0, 1, 0)
+	self:SetDefaultColor("ChargedComboPointBar", 0.3137254901960784, 0.3725490196078432, 1)
 
 	self.bTreatEmptyAsFull = true
 end
@@ -52,6 +53,26 @@ function ComboPointsBar.prototype:GetOptions()
 		end,
 	}
 
+	opts["bShowCharged"] = {
+		type = 'toggle',
+		width = 'double',
+		name = L["Show Charged points"],
+		desc = L["Whether or not to color a charged combo point a separate color and append an @ sign to the number. Set the ChargedComboPointBar color to the color you would like it to be."],
+		get = function()
+			return self.moduleSettings.bShowCharged
+		end,
+		set = function(info, v)
+			self.moduleSettings.bShowCharged = v
+			self:UpdateComboPoints()
+		end,
+		disabled = function()
+			return not self.moduleSettings.enabled
+		end,
+		hidden = function()
+			return not GetUnitChargedPowerPoints
+		end,
+	}
+
 	return opts
 end
 
@@ -62,6 +83,7 @@ function ComboPointsBar.prototype:GetDefaultSettings()
 	defaults.alwaysDisplay = false
 	defaults.desiredLerpTime = 0.05
 	defaults.bShowWithNoTarget = true
+	defaults.bShowCharged = true
 	return defaults
 end
 
@@ -84,17 +106,7 @@ function ComboPointsBar.prototype:Enable(core)
 	end
 
 	if GetUnitChargedPowerPoints then
-		self:RegisterEvent("UNIT_POWER_POINT_CHARGE", "UpdateChargedComboPoints")
-	end
-
-	self:UpdateChargedComboPoints()
-end
-
-function ComboPointsBar.prototype:UpdateChargedComboPoints()
-	if GetUnitChargedPowerPoints then
-		local chargedPowerPoints = GetUnitChargedPowerPoints("player")
-		self.chargedPowerPointIndex = chargedPowerPoints and chargedPowerPoints[1]
-		self:UpdateComboPoints()
+		self:RegisterEvent("UNIT_POWER_POINT_CHARGE", "UpdateComboPoints")
 	end
 end
 
@@ -131,20 +143,46 @@ function ComboPointsBar.prototype:UpdateComboPoints(...)
 		points = nil
 	end
 
+	local isCharged = self:IsChargedPoint(points) and self.moduleSettings.bShowCharged
+
 	if points == nil or points == 0 or (not UnitExists("target") and not self.moduleSettings.bShowWithNoTarget) then
 		self:Show(self.moduleSettings.alwaysDisplay)
 		self:UpdateBar(0, "undef")
 	else
 		self:Show(true)
-		self:SetScaledColor(color, (points - 1) / 4.0, self.settings.colors["ComboPointsBarMax"], self.settings.colors["ComboPointsBarMin"])
+		if isCharged then
+			color.r, color.g, color.b = self:GetColor("ChargedComboPointBar")
+		else
+			self:SetScaledColor(color, (points - 1) / 4.0, self.settings.colors["ComboPointsBarMax"], self.settings.colors["ComboPointsBarMin"])
+		end
 		self:UpdateBar(points / UnitPowerMax("player", SPELL_POWER_COMBO_POINTS), "undef")
 		self.barFrame.bar:SetVertexColor(color.r, color.g, color.b, self.alpha)
 	end
 
-	self:SetBottomText1(points or "0")
-	if self.chargedPowerPointIndex then
-		self:SetBottomText2(self.chargedPowerPointIndex)
+	local pointsText = tostring(points or 0)
+	if isCharged then
+		pointsText = pointsText .. "@"
 	end
+	self:SetBottomText1(pointsText or "0")
+end
+
+function ComboPointsBar.prototype:IsChargedPoint(point)
+	if not GetUnitChargedPowerPoints or not point then
+		return false
+	end
+
+	local chargedPoints = GetUnitChargedPowerPoints("player")
+	if not chargedPoints then
+		return false
+	end
+
+	for i=1, #chargedPoints do
+		if chargedPoints[i] == point then
+			return true
+		end
+	end
+
+	return false
 end
 
 function ComboPointsBar.prototype:Update()

modules/CustomBar.lua

@@ -329,16 +329,18 @@ function IceCustomBar.prototype:GetOptions()
 	opts["buffToTrack"] = {
 		type = 'input',
 		name = L["Aura to track"],
-		desc = L["Which buff/debuff this bar will be tracking.\n\nRemember to press ENTER after filling out this box with the name you want or it will not save."],
+		desc = function()
+			if IceHUD.GetPlayerAuraBySpellID then
+				return L["Which buff/debuff this bar will be tracking. Can use the name or spell id. \n\nRemember to press ENTER after filling out this box with the name you want or it will not save."]
+			else
+				return L["Which buff/debuff this bar will be tracking.\n\nRemember to press ENTER after filling out this box with the name you want or it will not save."]
+			end
+		end,
 		get = function()
 			return self.moduleSettings.buffToTrack
 		end,
 		set = function(info, v)
 			local orig = v
-			--Parnic: we now allow spell IDs to be used directly
-			--if tonumber(v) ~= nil then
-			--	v = GetSpellInfo(tonumber(v))
-			--end
 			if v == nil then
 				v = orig
 			end

modules/EssencePower.lua

@@ -0,0 +1,74 @@
+local L = LibStub("AceLocale-3.0"):GetLocale("IceHUD", false)
+local EssencePower = IceCore_CreateClass(IceClassPowerCounter)
+
+local SPELL_POWER_ESSENCE = SPELL_POWER_ESSENCE
+if Enum and Enum.PowerType then
+	SPELL_POWER_ESSENCE = Enum.PowerType.Essence
+end
+
+function EssencePower.prototype:init()
+	EssencePower.super.prototype.init(self, "EssencePower")
+
+	self:SetDefaultColor("EssencePowerNumeric", 150, 150, 255)
+
+	self.unit = "player"
+	self.numericColor = "EssencePowerNumeric"
+	self.unitPower = SPELL_POWER_ESSENCE
+	self.minLevel = 0
+	self.bTreatEmptyAsFull = false
+	self.runeWidth = self.runeHeight
+end
+
+function EssencePower.prototype:Enable(core)
+	self.numRunes = UnitPowerMax(self.unit, SPELL_POWER_ESSENCE)
+	self.runeCoords = { }
+	for i = 1, self.numRunes do
+		self:SetupNewRune(i)
+	end
+
+	EssencePower.super.prototype.Enable(self, core)
+end
+
+function EssencePower.prototype:SetupNewRune(rune)
+    self.runeCoords[rune] = {0, 1, 0, 1}
+end
+
+function EssencePower.prototype:GetPowerEvent()
+	return "UNIT_POWER_FREQUENT"
+end
+
+function EssencePower.prototype:GetDefaultSettings()
+	local defaults =  EssencePower.super.prototype.GetDefaultSettings(self)
+
+	defaults["pulseWhenFull"] = false
+
+	return defaults
+end
+
+function EssencePower.prototype:GetOptions()
+	local opts = EssencePower.super.prototype.GetOptions(self)
+
+	opts.hideBlizz.hidden = function() return true end
+
+	return opts
+end
+
+function EssencePower.prototype:GetRuneAtlas(rune)
+	return "UF-Essence-Icon"
+end
+
+function EssencePower.prototype:GetShineAtlas(rune)
+	return "Mage-ArcaneCharge-SmallSpark"
+end
+
+function EssencePower.prototype:ShowBlizz()
+end
+
+function EssencePower.prototype:HideBlizz()
+end
+
+-- Load us up
+local _, unitClass = UnitClass("player")
+if unitClass == "EVOKER" then
+	IceHUD.EssencePower = EssencePower:new()
+end

modules/PlayerHealth.lua

@@ -1418,6 +1418,44 @@ function PlayerHealth.prototype:HideBlizz()
 	PlayerFrame:SetParent(self.PlayerFrameParent)
 end
 
+local parents = {}
+local hide_frame = IceHUD:OutOfCombatWrapper(function(self) self:Hide() end)
+
+local function hook_frames(...)
+	for i = 1, select("#", ...) do
+		local frame = select(i, ...)
+		frame:UnregisterAllEvents()
+		if not IceHUD:IsHooked(frame, "OnShow") then
+			IceHUD:SecureHookScript(frame, "OnShow", hide_frame)
+		end
+		frame:Hide()
+	end
+end
+
+local function unhook_frame(frame)
+	if IceHUD:IsHooked(frame, "OnShow") then
+		IceHUD:Unhook(frame, "OnShow")
+		local parent = parents[frame]
+		if parent then
+			frame:SetParent(parent)
+		end
+	elseif IceHUD:IsHooked(frame, "Show") then
+		IceHUD:Unhook(frame, "Show")
+		IceHUD:Unhook(frame, "SetPoint")
+	end
+end
+
+local function unhook_frames(...)
+	for i = 1, select("#", ...) do
+		local frame = select(i, ...)
+		unhook_frame(frame)
+		local handler = frame:GetScript("OnLoad")
+		if handler then
+			handler(frame)
+		end
+	end
+end
+
 function PlayerHealth.prototype:HideBlizzardParty()
 	if self.combat then
 		self.pendingBlizzardPartyHide = true

modules/PlayerInfo.lua

@@ -115,7 +115,9 @@ end
 
 function PlayerInfo.prototype:ShowBlizz()
 	BuffFrame:Show()
-	TemporaryEnchantFrame:Show()
+	if TemporaryEnchantFrame then
+		TemporaryEnchantFrame:Show()
+	end
 
 	BuffFrame:GetScript("OnLoad")(BuffFrame)
 end
@@ -123,7 +125,9 @@ end
 
 function PlayerInfo.prototype:HideBlizz()
 	BuffFrame:Hide()
-	TemporaryEnchantFrame:Hide()
+	if TemporaryEnchantFrame then
+		TemporaryEnchantFrame:Hide()
+	end
 
 	BuffFrame:UnregisterAllEvents()
 end

modules/RollTheBones.lua

@@ -274,7 +274,7 @@ end
 function RollTheBones.prototype:MyOnUpdate()
   RollTheBones.super.prototype.MyOnUpdate(self)
   if self.bUpdateRtb then
-    self:UpdateRollTheBones(nil, self.unit, true)
+    self:UpdateRollTheBones("internal", self.unit)
   end
   if self.target or self.moduleSettings.bShowWithNoTarget then
     self:UpdateDurationBar()
@@ -296,13 +296,14 @@ local function ShouldHide()
   return not HasSpell(193316)
 end
 
-function RollTheBones.prototype:UpdateRollTheBones(event, unit, fromUpdate)
+function RollTheBones.prototype:UpdateRollTheBones(event, unit)
   if unit and unit ~= self.unit then
     return
   end
 
   local now = GetTime()
   local remaining = nil
+  local fromUpdate = event == "internal"
 
   if not fromUpdate then
     rtbDuration, remaining, rtbCount = self:GetBuffDuration(self.unit, RtBSet)

modules/SliceAndDice.lua

@@ -277,7 +277,7 @@ end
 function SliceAndDice.prototype:MyOnUpdate()
 	SliceAndDice.super.prototype.MyOnUpdate(self)
 	if self.bUpdateSnd then
-		self:UpdateSliceAndDice(nil, self.unit, true)
+		self:UpdateSliceAndDice("internal", self.unit)
 	end
 	if self.target or self.moduleSettings.bShowWithNoTarget then
 		self:UpdateDurationBar()
@@ -312,13 +312,14 @@ local function ShouldHide()
 	-- with different durations
 end
 
-function SliceAndDice.prototype:UpdateSliceAndDice(event, unit, fromUpdate)
+function SliceAndDice.prototype:UpdateSliceAndDice(event, unit)
 	if unit and unit ~= self.unit then
 		return
 	end
 
 	local now = GetTime()
 	local remaining = nil
+	local fromUpdate = event == "internal"
 
 	if not fromUpdate or IceHUD.WowVer < 30000 then
 		sndDuration, remaining = self:GetBuffDuration(self.unit, sndBuffName)

modules/TargetCC.lua

@@ -375,11 +375,12 @@ end
 
 function TargetCC.prototype:MyOnUpdate()
 	TargetCC.super.prototype.MyOnUpdate(self)
-	self:UpdateTargetDebuffs(nil, self.unit, true)
+	self:UpdateTargetDebuffs("internal", self.unit)
 end
 
-function TargetCC.prototype:UpdateTargetDebuffs(event, unit, isUpdate)
+function TargetCC.prototype:UpdateTargetDebuffs(event, unit)
 	local name, duration, remaining
+	local isUpdate = event == "internal"
 
 	if not isUpdate or not self.lastUpdateTime then
 		self.debuffName, self.debuffDuration, self.debuffRemaining = self:GetMaxDebuffDuration(self.unit, self.debuffList)

modules/TargetInvuln.lua

@@ -191,11 +191,12 @@ end
 
 function TargetInvuln.prototype:MyOnUpdate()
 	TargetInvuln.super.prototype.MyOnUpdate(self)
-	self:UpdateTargetBuffs(nil, self.unit, true)
+	self:UpdateTargetBuffs("internal", self.unit)
 end
 
-function TargetInvuln.prototype:UpdateTargetBuffs(event, unit, isUpdate)
+function TargetInvuln.prototype:UpdateTargetBuffs(event, unit)
 	local name, duration, remaining
+	local isUpdate = event == "internal"
 
 	if not isUpdate or not self.lastUpdateTime then
 		self.buffName, self.buffDuration, self.buffRemaining = self:GetMaxbuffDuration(self.unit, self.buffList)

this_version.md

@@ -1,22 +1,30 @@
 # Changelog
 
-v1.13.17.3:
+v1.14.5:
 
-- Packaged latest LibDogTag-Unit to work around crash in Wrath Classic client.
+- Fix castbar flashing. There are controls on the player castbar module for flashing when a spell succeeds or fails, and separate controls for flashing when an instant cast completes. Those were broken, but now work again.
+- Add "@" after the number when the Combo Points module is in Numeric mode, "Show Charged points" is enabled, and the current combo point is charged.
+- Fix Charged point support in the ComboPointsBar module.
 
-v1.13.17.2:
+v1.14.4:
 
-- Fixed Runes disappearing for Death Knights on Wrath Classic when using the dual spec feature.
+- Update TOC for 10.0.2
 
-v1.13.17.1:
+v1.14.3:
 
-- Fixed Priests hanging on login on the retail client.
+- Add Spell ID support for aura tracking.
+- Add Evoker support.
+- Add Empowered Casting (hold-to-cast levels) support.
 
-v1.13.17:
+v1.14.2:
 
-- Internal maintainability updates. There are so many versions of the game now, updates need to be as easy and safe as possible.
-- Improved reliability of Slice-n-Dice predicted length when changing talents.
-- Improved various modules's ability to respond to the player's maximum power type changing (going from 5 max combo points to 6, for example).
-- Fixed invalid texture layers specified on a variety of textures (10.0 fix).
-- Removed HolyPowerNumeric text from the configuration options of several modules that it didn't belong with.
-- Fixed combo points in Classic Era clients.
+- Fix CC and Invuln modules not showing immediately when they should.
+
+v1.14.1:
+
+- Fix Hide Party feature on pre-10.0 clients.
+
+v1.14.0:
+
+- 10.0 compatibility
+- Renamed Anima Charged combo points to Charged, and removed specific references to Kyrian.