Commit Graph

867 Commits

Author SHA1 Message Date
b1adbe8090 Add Dragonriding Vigor module
This displays the Vigor charges for the player whenever they're on a Dragonriding mount (which is detected via explicit buff ID scanning from a hardcoded list...I'd like to make that more robust so I don't have to keep up with new mounts being added, but I'm not sure how to do it another way just yet). The Alternate Power bar is hidden if the Vigor module is enabled so that we don't end up with duplicate Vigor trackers (although right now it flashes on the screen before the mount buff is detected, so I'd also like to fix that...).

I've effectively had to implement my own Vigor module from scratch by poking into the internals of the Vigor widget by its ID in order to determine the recharge amount on the final Vigor charge because there's currently no API to get this information otherwise. Hopefully this gets added; if it does, I'll happily rip out this widget inspection junk. Aside from the partial charge stuff, this is just a skinned version of an Alternate Power indicator that only shows when the user is on a dragonriding mount. ClassPowerCounter doesn't sound like a particularly appropriate base class for this, but since Vigor is implemented as Alternate Power, it worked out nicely.
2023-01-15 13:03:18 -06:00
01a017c179 Add support for background and frame
This adds more robust visuals on the power counters where we can (finally) display artwork similar to the default UI where the charges are sometimes framed by something and sometimes have a textured background behind empty charges. This doesn't yet add support for animations. Child classes can take advantage of this simply by implementing GetFrameAtlas() and/or GetBackgroundAtlas().

Note: as part of this, I moved the rune texture's layer to "BORDER" which doesn't feel quite appropriate, but does allow the layering to work as I want. I don't think this is going to be an issue since texture layers should only apply internal to a frame's strata (meaning this shouldn't suddenly cause an existing power counter to display above/below something else), but I wanted to document it in case something weird does come up later.

I also hardcoded a + 10 on the width/height for the frame since that's what works for Vigor. If those values don't work for any future users of this, it's easily adjusted.
2023-01-15 12:57:58 -06:00
b8aece0da3 Add support for a partially-ready final rune
This adds support for a class power counter that has a visible recharge on the final "rune." Most power counters are either fully ready or full un-ready (where the recharge is hidden away), but Dragonriding's Vigor resource does show the recharge of the final point, which this now supports.

Child classes can support this by setting self.partialReady to the index of the rune that's partially ready, and self.partialReadyPercent to the percentage that that final rune is ready (0.0-1.0). If the partially-charged point uses a different texture, the child can also implement GetPartialRuneAtlas() and it will be used only for the partially-ready rune.

If we ever need to be able to show multiple partially-ready runes, this will need a small refactor.
2023-01-15 12:52:22 -06:00
6b9b4a358c Move altpower to a local variable
This isn't used anywhere else, so there's no reason for it to pollute the global namespace. And being local now, it also doesn't need the IceHUD prefix on its name.
2023-01-15 12:46:20 -06:00
72adca99f9 Fix whitespace 2023-01-15 12:45:19 -06:00
f8e7cf06d6 Combine rune texture/color set into one method
This enables a simpler method of making sure the appropriate texture is set and using the appropriate color (for after a rune was modified to darkened/hidden).
2023-01-15 12:43:56 -06:00
059808c980 Add ability to opt out of displaypower event 2023-01-15 12:41:16 -06:00
689df94d55 Refactor repeated code into a function
I need this for an upcoming feature, and it turns out that the "new rune just became ready" feature didn't cooperate with width-growing runes anyway, so this is also a bugfix for that (I don't know that we have any width-growing power types in the game today, but still).
2023-01-15 12:40:51 -06:00
d49884198d Only apply numeric offset when not in numeric mode
This offset is an additional offset meant to apply only when a class power counter is in a non-Numeric mode with the "also show numeric" checkbox checked. This offset is hidden when in Numeric mode, but was still being applied, therefore making it an option you could not change without going through multiple other steps first.
2023-01-15 12:35:14 -06:00
7496475ff4 Fix potential nil access
I can't reproduce a problem here, but based on some user feedback, this could potentially be an issue. Most other modules are calling the super's Update() first thing, but these modules call them later, so healthPercentage may not be defined at this point.
2022-12-19 12:19:10 -06:00
c5c44edf64 Fix several issues with low thresholds
This addresses a user-reported issue where Low Threshold was not usable with Color By Health/Mana % disabled, due to some internal technical reasons. This was exacerbated by the recent fix that allowed Low Threshold and Color By Health % to work together.

This also fixes the low threshold flash to apply immediately when changing the option, and fixes the Low Threshold % slider to be usable without the Low Flash option set.

Finally, it hides the Low Flash option for bars that don't support it (right now that's just PlayerMana, I think because it only sets the low threshold to the Min Mana Color even if the class uses a different power type...something for future me...).

Fixes wowace ticket #334
2022-12-13 20:48:02 -06:00
8fc2e326aa Add option to scale absorb bar by health
By user request.
2022-11-23 18:50:52 -06:00
d775603ec0 Add module showing Energy for Druids
This shows the player's current Energy amount when they're in a form that doesn't use Energy. For example, this could show the user how much energy they currently have while they're in Bear form so that they can shift away and wait on their energy to refill.

Note: requires a new version of LibDogTag-Unit for the bar text tags to function if DogTags are enabled.
2022-11-18 17:08:26 -06:00
07bda8e84d Add more Custom Bar display controls
Add ability for buff/debuff watchers to only display when the specified buff/debuff is missing. This also adds the ability to require that the given unit exists. So if you had Unit set to Target, Display mode set to Missing, and Only if unit exists checked, you'd show the bar if you have a target and they don't have the given buff/debuff.
2022-11-17 17:14:49 -06:00
5712114eb8 Fix Charged point support in ComboPointsBar 2022-11-16 21:14:51 -06:00
2a0db2eb01 Show charged combo point in Numeric mode 2022-11-16 21:09:44 -06:00
6a985bc67a Add Evoker, empowered casting support 2022-11-11 11:29:15 -06:00
3a5e58bf34 Add Spell ID support for aura tracking (#31) 2022-11-06 08:34:01 -06:00
b467af21c0 Fix CC and Invuln not showing immediately
This is the same fix as was applied to RollTheBones in commit 46883e355b but I failed to audit the rest of the mod for places where this was possible. This one was reported over on the Curse addon page comments.
2022-10-31 23:36:38 -05:00
acc400de6e Fix error on Classic with Hide Party
I neglected to test the new party-hide implementation on pre-10.0. It was not fully implemented. This implementation is from Pitbull4 and is more complicated than I need, but certainly does the job and allows for some future usage if needed.

Fixes wowace ticket #330
2022-10-30 23:21:31 -05:00
46883e355b Fix RollTheBones not showing immediately when cast
I guess UNIT_AURA now provides a third argument that it wasn't before. So instead of relying on a third argument, just override the event name to something we control and key off that for avoiding updates.
2022-10-28 22:44:38 -05:00
b8cf6e90b0 Fix error on 10.0
I guess this frame is gone. I don't remember why this was necessary.
2022-10-27 20:32:47 -05:00
8858459b10 Disable Runes Hide Blizzard option
This is no longer functional in 10.0 and I can't find an easy replacement, so I'm removing the functionality for 10.0+ for now. The entire player frame can still be hidden, which also hides the runes, so I don't feel like this is super critical to have.

Fixes #26
2022-10-27 08:56:53 -05:00
86e40187a2 Update Party hide feature for 10.0 compatibility 2022-10-25 22:42:46 -05:00
52c9b51e8d Temp fix for error in 10.0
I need to find the new way to disable party frames, but this gets the addon loaded for now.
2022-10-25 21:43:13 -05:00
aa03a0b332 Add support for max power changing
Evokers can spec into an additional Essence, so we need to handle the power counter increasing/decreasing. This was a fundamental change to the class power counter, so I'm sure something else broke somewhere. A casual glance at other classes/specs seems fine, though...
2022-10-25 21:43:05 -05:00
3017b5dd18 Rename Anima Charged to Charged
Charged combo points are still a thing, but they're no longer called "Anima-charged" or relate to Kyrian.
2022-10-25 21:42:32 -05:00
1f54f7d41d Use new player castbar frame name 2022-10-25 21:42:13 -05:00
701fb1373f Fix Runes disappearing for DK on Wrath
MaxPower events fire, but I guess only Legion+ actually returns rune counts from this function. On Wrath it always returns 0, so the CheckMaxNumRunes logic was hiding all runes.
2022-09-20 14:27:31 -05:00
5a41d9a7f4 Fix ShadowOrbs causing priests to freeze/hang on login
I would still like to find a way to feature-flag this instead of WowVer-flag it, but it's not super important for now.
2022-09-19 10:21:02 -05:00
7ceb70737a Fix combo points display in Classic Era 2022-09-18 22:57:01 -05:00
faa3d326aa Replace WowVer checks in class power counters 2022-09-18 22:43:04 -05:00
9fc90551e2 Fix Charged combo points feature flag 2022-09-18 22:35:19 -05:00
0af47119e3 Continue replacement of WowVer checks 2022-09-18 21:49:53 -05:00
955fa6efdc Continue replacement of WowVer checks 2022-09-18 17:54:35 -05:00
41ae17ba9a Continue replacement of WowVer checks 2022-09-18 17:50:37 -05:00
5bc1f04504 Remove HolyPower reference from most power modules 2022-09-18 15:37:01 -05:00
09e1832fbe Fix more invalid texture layers 2022-09-18 15:36:45 -05:00
7c3fc54d26 Fix invalid texture layer
This is an error in 10.0 and was wrong before that.
2022-09-18 15:36:34 -05:00
9e68edbc43 Detect SnD max changing more reliably 2022-09-18 15:34:36 -05:00
a259db6b8a Use UnitPowerMax where available 2022-09-18 15:34:27 -05:00
d10586d477 More culling of WowVer checks 2022-09-18 13:33:51 -05:00
c804ba178b Convert a few more checks into feature flags 2022-09-18 08:30:06 -05:00
ee72cd1f33 Add feature flag for UnitGroupRolesAssigned 2022-09-02 14:31:51 -05:00
777cf01174 Add feature flag for Heal Prediction
And turn it on for Wrath Classic, because apparently it works there.
2022-09-02 14:27:33 -05:00
b65909c570 Wrath updates for Paladin GCD, Rogue SnD 2022-08-30 22:25:16 -05:00
6c623d6965 Initial Wrath-Classic compatibility
Briefly fought a training dummy with a Death Knight and a Shaman. I'm sure stuff like Slice-and-dice will need attention for talents moving around and such.
2022-08-30 21:59:58 -05:00
611f37a1f3 Add reported missing nil check
Fixes #20 (github)
2022-03-25 21:30:54 -05:00
53fdb48b05 Fix reported TBC issue of target health updates
For some reason, on TBC classic target health is not updating frequently. I waded through the official TBC source code, and it looks like if predictedHealth is enabled (which it is by default), then the default UI uses an OnUpdate handler to update the target's health bar. So now I'm doing the same.
2022-03-24 11:51:58 -05:00
eee20f17b4 Change method of hiding the target frame
See 51e2debc4d for the PlayerFrame version of this (and reasoning for this)
2022-03-22 22:57:36 -05:00