Fix Charged point support in ComboPointsBar

There are controls on the player castbar module for flashing when a spell succeeds or fails, and separate controls for flashing when an instant cast completes. Those were broken (flashing never happened), but now work again.

UpdateBar() was necessary in MyOnUpdate() in the event that no other spell has been cast (in order to set the alpha so that the bottom text displays). The spellId is being passed along so that spells that aren't currently being cast can have their name and icon displayed appropriately, and so the early-out for "no known spell" doesn't trigger (which allows the Flash to actually work). The self.current reset fixes instant casts after a normal cast (we were only clearing the "current" spell conditionally when we only meant to filter StopBar, so if it wasn't cleared, future successful casts thought they were for a different spell than was currently being cast.

.github/workflows/release.yml

@@ -23,6 +23,7 @@ jobs:
     env:
       CF_API_KEY: ${{ secrets.CF_API_KEY }}
       WOWI_API_TOKEN: ${{ secrets.WOWI_API_TOKEN }}
+      WAGO_API_TOKEN: ${{ secrets.WAGO_API_TOKEN }}
       GITHUB_OAUTH: ${{ secrets.GITHUB_TOKEN }}  # "GITHUB_TOKEN" is a secret always provided to the workflow
                                                  # for your own token, the name cannot start with "GITHUB_"
 
@@ -31,20 +32,27 @@ jobs:
 
       # we first have to clone the AddOn project, this is a required step
       - name: Clone project
-        uses: actions/checkout@v1
+        uses: actions/checkout@v3
+        with:
+          fetch-depth: 0  # gets git history for changelogs
 
       # once cloned, we just run the GitHub Action for the packager project
       - name: Package and release
-        uses: BigWigsMods/packager@master
+        uses: BigWigsMods/packager@v2
 
       # another example where we supply additional arguments, this example is specifically to release
       # for the Classic version of the game
       - name: Package and release for Classic
-        uses: BigWigsMods/packager@master
+        uses: BigWigsMods/packager@v2
         with:
           args: -g classic -w 0
 
       - name: Package and release for TBC
-        uses: BigWigsMods/packager@master
+        uses: BigWigsMods/packager@v2
         with:
           args: -g bcc -w 0
+
+      - name: Package and release for Wrath
+        uses: BigWigsMods/packager@v2
+        with:
+          args: -g wrath -w 0

.pkgmeta

@@ -37,15 +37,18 @@ externals:
     libs/AceLocale-3.0:
         url: svn://svn.wowace.com/wow/ace3/mainline/trunk/AceLocale-3.0
         tag: latest
+    libs/AceHook-3.0:
+        url: svn://svn.wowace.com/wow/ace3/mainline/trunk/AceHook-3.0
+        tag: latest
     libs/LibRangeCheck-2.0:
         url: https://github.com/WeakAuras/LibRangeCheck-2.0/
     libs/LibSharedMedia-3.0:
         url: svn://svn.wowace.com/wow/libsharedmedia-3-0/mainline/trunk
         tag: latest
     libs/LibDogTag-3.0:
-        url: git://git.wowace.com/wow/libdogtag-3-0/mainline.git
+        url: https://github.com/parnic/LibDogTag-3.0
     libs/LibDogTag-Unit-3.0:
-        url: git://git.wowace.com/wow/libdogtag-unit-3-0/mainline.git
+        url: https://github.com/parnic/LibDogTag-Unit-3.0
     libs/LibDBIcon-1.0:
         url: svn://svn.wowace.com/wow/libdbicon-1-0/mainline/trunk/LibDBIcon-1.0
     libs/LibDualSpec-1.0:
@@ -65,6 +68,8 @@ tools-used:
 
 ignore:
     - readme.md
+    - FUNDING.yml
+    - this_version.md
 
 manual-changelog: this_version.md
 

FUNDING.yml

@@ -0,0 +1,3 @@
+github: parnic
+ko_fi: parnic
+custom: "https://www.paypal.me/parnic"

IceCastBar.lua

@@ -3,7 +3,7 @@ IceCastBar = IceCore_CreateClass(IceBarElement)
 
 local IceHUD = _G.IceHUD
 
-IceCastBar.Actions = { None = 0, Cast = 1, Channel = 2, Instant = 3, Success = 4, Failure = 5 }
+IceCastBar.Actions = { None = 0, Cast = 1, Channel = 2, Instant = 3, Success = 4, Failure = 5, ReverseChannel = 6 }
 
 IceCastBar.prototype.action = nil
 IceCastBar.prototype.actionStartTime = nil
@@ -49,6 +49,13 @@ function IceCastBar.prototype:init(name)
 	self:SetDefaultColor("CastChanneling", 242, 242, 10)
 	self:SetDefaultColor("CastSuccess", 242, 242, 70)
 	self:SetDefaultColor("CastFail", 1, 0, 0)
+	if GetUnitEmpowerMinHoldTime then
+		self:SetDefaultColor("EmpowerStage0", 165, 165, 165)
+		self:SetDefaultColor("EmpowerStage1", 242, 42, 10)
+		self:SetDefaultColor("EmpowerStage2", 242, 142, 10)
+		self:SetDefaultColor("EmpowerStage3", 242, 242, 10)
+		self:SetDefaultColor("EmpowerStage4", 242, 242, 242)
+	end
 	self.unit = "player"
 
 	self.delay = 0
@@ -109,6 +116,12 @@ function IceCastBar.prototype:Enable(core)
 		self:RegisterEvent("UNIT_SPELLCAST_CHANNEL_UPDATE", "SpellCastChannelUpdate") -- unit, spell, rank
 		self:RegisterEvent("UNIT_SPELLCAST_CHANNEL_STOP", "SpellCastChannelStop") -- unit, spell, rank
 
+		if GetUnitEmpowerHoldAtMaxTime then
+			self:RegisterEvent("UNIT_SPELLCAST_EMPOWER_START", "SpellCastChannelStart")
+			self:RegisterEvent("UNIT_SPELLCAST_EMPOWER_UPDATE", "SpellCastChannelUpdate")
+			self:RegisterEvent("UNIT_SPELLCAST_EMPOWER_STOP", "SpellCastChannelStop")
+		end
+
 	end
 	self:Show(false)
 end
@@ -146,7 +159,7 @@ function IceCastBar.prototype:GetOptions()
 		end,
 		order = 39.998
 	}
-if IceHUD.WowVer < 80000 then
+if IceHUD.SpellFunctionsReturnRank then
 	opts["showSpellRank"] =
 	{
 		type = 'toggle',
@@ -311,7 +324,13 @@ function IceCastBar.prototype:PositionIcons()
 	self.barFrame.icon:SetHeight(AuraIconHeight * self.moduleSettings.auraIconScale)
 end
 
+function IceCastBar.prototype:GetRemainingCastTime()
+	return self.actionStartTime + self.actionDuration - GetTime()
+end
 
+function IceCastBar.prototype:GetCurrentCastDurationMs()
+	return (GetTime() - (self.actionStartTime or GetTime())) * 1000
+end
 
 -- OnUpdate handler
 function IceCastBar.prototype:MyOnUpdate()
@@ -322,17 +341,15 @@ function IceCastBar.prototype:MyOnUpdate()
 		return
 	end
 
-	local time = GetTime()
-
 	self:Update()
 	self:SetTextAlpha()
 
 	-- handle casting and channeling
-	if (self.action == IceCastBar.Actions.Cast or self.action == IceCastBar.Actions.Channel) then
+	if (self.action == IceCastBar.Actions.Cast or self.action == IceCastBar.Actions.Channel or self.action == IceCastBar.Actions.ReverseChannel) then
-		local remainingTime = self.actionStartTime + self.actionDuration - time
+		local remainingTime = self:GetRemainingCastTime()
 		local scale = 1 - (self.actionDuration ~= 0 and remainingTime / self.actionDuration or 0)
 
-		if (self.moduleSettings.reverseChannel and self.action == IceCastBar.Actions.Channel) then
+		if self.action == IceCastBar.Actions.ReverseChannel then
 			scale = self.actionDuration ~= 0 and remainingTime / self.actionDuration or 0
 		end
 
@@ -343,14 +360,22 @@ function IceCastBar.prototype:MyOnUpdate()
 		end
 
 		local timeString = self.moduleSettings.showCastTime and string.format("%.1fs ", remainingTime) or ""
-		self:SetBottomText1(timeString .. self.actionMessage)
+		local empowerString = self.NumStages ~= nil and (L["Stage %d"]):format(self:GetCurrentStage()) or ""
+		local line1 = timeString .. self.actionMessage
+		if self.moduleSettings.empowerStageTextDisplay == "TOPLINE" then
+			line1 = line1 .. " " .. empowerString
+		end
+		if self.moduleSettings.empowerStageTextDisplay == "BOTTOMLINE" then
+			self:SetBottomText2(empowerString)
+		end
+		self:SetBottomText1(line1)
 
 		return
 	end
 
 
 	-- stop bar if casting or channeling is done (in theory this should not be needed)
-	if (self.action == IceCastBar.Actions.Cast or self.action == IceCastBar.Actions.Channel) then
+	if (self.action == IceCastBar.Actions.Cast or self.action == IceCastBar.Actions.Channel or self.action == IceCastBar.Actions.ReverseChannel) then
 		self:StopBar()
 		return
 	end
@@ -361,13 +386,15 @@ function IceCastBar.prototype:MyOnUpdate()
 		self.action == IceCastBar.Actions.Success or
 		self.action == IceCastBar.Actions.Failure)
 	then
-		local scale = time - self.actionStartTime
+		local scale = GetTime() - self.actionStartTime
 
 		if (scale > 1) then
 			self:StopBar()
 			return
 		end
 
+		self:UpdateBar(1, self:GetCurrentCastingColor())
+
 		if (self.action == IceCastBar.Actions.Failure) then
 			self:FlashBar("CastFail", 1-scale, self.actionMessage, "CastFail")
 		else
@@ -381,12 +408,60 @@ function IceCastBar.prototype:MyOnUpdate()
 	self:StopBar()
 end
 
-function IceCastBar.prototype:GetCurrentCastingColor()
+function IceCastBar.prototype:GetStageDuration(stage)
-	local updateColor = "CastCasting"
+	if not GetUnitEmpowerMinHoldTime then
-	if self.action == IceCastBar.Actions.Channel then
+		return 0
-		updateColor = "CastChanneling"
 	end
-	return updateColor
+
+	if stage == 0 then
+		return GetUnitEmpowerMinHoldTime(self.unit)
+	end
+
+	return GetUnitEmpowerStageDuration(self.unit, stage);
+end
+
+function IceCastBar.prototype:GetDurationUpToStage(stage)
+	if stage == nil or stage < 0 then
+		return 0
+	end
+
+	local total = 0
+	for i=0,stage-1 do
+		total = total + self:GetStageDuration(i)
+	end
+
+	return total
+end
+
+function IceCastBar.prototype:GetCurrentStage()
+	if not GetUnitEmpowerMinHoldTime then
+		return 0
+	end
+
+	local castDuration = self:GetCurrentCastDurationMs()
+	for i=1,self.NumStages do
+		if castDuration < self:GetDurationUpToStage(i) then
+			return i - 1
+		end
+	end
+
+	return self.NumStages
+end
+
+function IceCastBar.prototype:IsCastingEmpowerSpell()
+	return self.NumStages ~= nil
+end
+
+function IceCastBar.prototype:GetCurrentCastingColor()
+	if self:IsCastingEmpowerSpell() then
+		return ("EmpowerStage%d"):format(self:GetCurrentStage())
+	end
+
+	if self.action == IceCastBar.Actions.Channel or self.action == IceCastBar.Actions.ReverseChannel then
+		return "CastChanneling"
+	end
+
+	return "CastCasting"
 end
 
 function IceCastBar.prototype:FlashBar(color, alpha, text, textColor)
@@ -405,8 +480,8 @@ function IceCastBar.prototype:FlashBar(color, alpha, text, textColor)
 end
 
 
-function IceCastBar.prototype:StartBar(action, message)
+function IceCastBar.prototype:StartBar(action, message, spellId)
-	local spell, rank, displayName, icon, startTime, endTime, isTradeSkill
+	local spell, rank, displayName, icon, startTime, endTime, isTradeSkill, numStages
 	if IceHUD.SpellFunctionsReturnRank then
 		spell, rank, displayName, icon, startTime, endTime, isTradeSkill = UnitCastingInfo(self.unit)
 	else
@@ -416,7 +491,28 @@ function IceCastBar.prototype:StartBar(action, message)
 		if IceHUD.SpellFunctionsReturnRank then
 			spell, rank, displayName, icon, startTime, endTime = UnitChannelInfo(self.unit)
 		else
-			spell, displayName, icon, startTime, endTime = UnitChannelInfo(self.unit)
+			spell, displayName, icon, startTime, endTime, isTradeSkill, _, _, _, numStages = UnitChannelInfo(self.unit)
+		end
+	end
+
+	if spellId and not spell then
+		spell, rank, icon = GetSpellInfo(spellId)
+	end
+
+	local isChargeSpell = numStages and numStages > 0
+	if isChargeSpell then
+		self.NumStages = numStages
+		endTime = endTime + GetUnitEmpowerHoldAtMaxTime(self.unit)
+		action = IceCastBar.Actions.ReverseChannel
+	else
+		self.NumStages = nil
+	end
+
+	if self.moduleSettings.reverseChannel then
+		if action == IceCastBar.Actions.Channel then
+			action = IceCastBar.Actions.ReverseChannel
+		elseif action == IceCastBar.Actions.ReverseChannel then
+			action = IceCastBar.Actions.Channel
 		end
 	end
 
@@ -424,7 +520,7 @@ function IceCastBar.prototype:StartBar(action, message)
 	if LibClassicCasterino and not spell then
 		self:StopBar()
 	elseif not spell then
-	  return
+		return
 	end
 
 	if icon ~= nil then
@@ -465,12 +561,13 @@ function IceCastBar.prototype:StopBar()
 	self.actionDuration = nil
 
 	self:SetBottomText1()
+	self:SetBottomText2()
 	self:SetScale(0)
 	self:Show(false)
 end
 
 function IceCastBar.prototype:GetShortRank(rank)
-	if IceHUD.WowVer < 80000 and rank then
+	if IceHUD.SpellFunctionsReturnRank and rank then
 		local _, _, sRank = string.find(rank, "(%d+)")
 		if (sRank) then
 			return " (" .. sRank .. ")"
@@ -499,7 +596,7 @@ function IceCastBar.prototype:SpellCastStart(event, unit, castGuid, spellId)
 	IceHUD:Debug("SpellCastStart", unit, castGuid, spellId)
 	--UnitCastingInfo(unit)
 
-	self:StartBar(IceCastBar.Actions.Cast)
+	self:StartBar(IceCastBar.Actions.Cast, nil, spellId)
 	self.current = castGuid
 end
 
@@ -514,11 +611,13 @@ function IceCastBar.prototype:SpellCastStop(event, unit, castGuid, spellId)
 
 	if (self.action ~= IceCastBar.Actions.Success and
 		self.action ~= IceCastBar.Actions.Failure and
-		self.action ~= IceCastBar.Actions.Channel)
+		self.action ~= IceCastBar.Actions.Channel and
+		self.action ~= IceCastBar.Actions.ReverseChannel)
 	then
 		self:StopBar()
-		self.current = nil
 	end
+
+	self.current = nil
 end
 
 
@@ -532,7 +631,7 @@ function IceCastBar.prototype:SpellCastFailed(event, unit, castGuid, spellId)
 	end
 
 	-- channeled spells will call ChannelStop, not cast failed
-	if self.action == IceCastBar.Actions.Channel then
+	if self.action == IceCastBar.Actions.Channel or self.action == IceCastBar.Actions.ReverseChannel then
 		return
 	end
 
@@ -547,7 +646,7 @@ function IceCastBar.prototype:SpellCastFailed(event, unit, castGuid, spellId)
 		end
 	end
 
-	self:StartBar(IceCastBar.Actions.Failure, "Failed")
+	self:StartBar(IceCastBar.Actions.Failure, "Failed", nil, spellId)
 end
 
 function IceCastBar.prototype:SpellCastInterrupted(event, unit, castGuid, spellId)
@@ -561,7 +660,7 @@ function IceCastBar.prototype:SpellCastInterrupted(event, unit, castGuid, spellI
 
 	self.current = nil
 
-	self:StartBar(IceCastBar.Actions.Failure, "Interrupted")
+	self:StartBar(IceCastBar.Actions.Failure, "Interrupted", spellId)
 end
 
 function IceCastBar.prototype:SpellCastDelayed(event, unit, castGuid, spellId)
@@ -582,7 +681,7 @@ function IceCastBar.prototype:SpellCastSucceeded(event, unit, castGuid, spellId)
 	--IceHUD:Debug("SpellCastSucceeded", unit, castGuid, spellId)
 
 	-- never show on channeled (why on earth does this event even fire when channeling starts?)
-	if (self.action == IceCastBar.Actions.Channel) then
+	if (self.action == IceCastBar.Actions.Channel or self.action == IceCastBar.Actions.ReverseChannel) then
 		return
 	end
 
@@ -595,7 +694,7 @@ function IceCastBar.prototype:SpellCastSucceeded(event, unit, castGuid, spellId)
 
 	-- show after normal successfull cast
 	if (self.action == IceCastBar.Actions.Cast) then
-		self:StartBar(IceCastBar.Actions.Success, spell.. self:GetShortRank(rank))
+		self:StartBar(IceCastBar.Actions.Success, spell.. self:GetShortRank(rank), spellId)
 		return
 	end
 
@@ -608,7 +707,7 @@ function IceCastBar.prototype:SpellCastSucceeded(event, unit, castGuid, spellId)
 		end
 	end
 
-	self:StartBar(IceCastBar.Actions.Success, spell.. self:GetShortRank(rank))
+	self:StartBar(IceCastBar.Actions.Success, spell.. self:GetShortRank(rank), spellId)
 end
 
 

IceCore.lua

@@ -41,6 +41,26 @@ IceCore.TextDecorationStyle = {
 	NoDecoration = L["No decoration"],
 }
 
+local ZM_MAP_ID = 1970
+IceCore.zmPuzzleIds = {
+	--Fugueal Protolock
+	366046,
+	366108,
+	359488,
+	--Mezzonic Protolock
+	366042,
+	366106,
+	351405,
+	--Cantaric Protolock
+	365840,
+	366107,
+	348792,
+}
+IceCore.zmPuzzleMap = {}
+for i=1, #IceCore.zmPuzzleIds do
+	IceCore.zmPuzzleMap[IceCore.zmPuzzleIds[i]] = true
+end
+
 local SUNDER_SPELL_ID = 7386
 local LACERATE_SPELL_ID = 33745
 local MAELSTROM_SPELL_ID = 53817
@@ -259,7 +279,13 @@ function IceCore.prototype:Enable(userToggle)
 		self.IceHUDFrame:RegisterEvent("BARBER_SHOP_OPEN")
 		self.IceHUDFrame:RegisterEvent("BARBER_SHOP_CLOSE")
 	end
+	if C_Map then
+		self.IceHUDFrame:RegisterEvent("PLAYER_ENTERING_WORLD")
+		self.IceHUDFrame:RegisterEvent("ZONE_CHANGED")
+	end
 	self.IceHUDFrame:RegisterEvent("UNIT_AURA")
+	self.IceHUDFrame:RegisterEvent("PLAYER_REGEN_ENABLED", IceHUD.PLAYER_REGEN_ENABLED)
+	self.IceHUDFrame:RegisterEvent("PLAYER_REGEN_DISABLED", IceHUD.PLAYER_REGEN_DISABLED)
 	self.IceHUDFrame:SetScript("OnEvent", function(self, event, ...)
 		if (event == "PET_BATTLE_OPENING_START") then
 			if IceHUD.IceCore.settings.bHideDuringPetBattles then
@@ -279,13 +305,48 @@ function IceCore.prototype:Enable(userToggle)
 			end
 		elseif (event == "UNIT_AURA") then
 			local unit = ...
-			if IceHUD.IceCore.settings.bHideDuringShellGame and unit == "player" and IceHUD:HasDebuffs("player", {271571})[1] and UnitInVehicle("player") then
+			if unit ~= "player" then
+				return
+			end
+
+			if IceHUD.IceCore.settings.bHideDuringShellGame and IceHUD:HasAnyDebuff("player", {IceHUD.ShellGameSpellID}) and UnitInVehicle("player") then
 				self:RegisterEvent("UNIT_EXITED_VEHICLE")
 				self:Hide()
+			elseif C_Map then
+				local bestMapID = C_Map.GetBestMapForUnit("player")
+				if bestMapID ~= ZM_MAP_ID then
+					return
+				end
+
+				if IceHUD:HasAnyBuff("player", IceCore.zmPuzzleIds) then
+					self:RegisterEvent("COMBAT_LOG_EVENT_UNFILTERED")
+					self:Hide()
+				end
 			end
 		elseif (event == "UNIT_EXITED_VEHICLE") then
 			self:UnregisterEvent("UNIT_EXITED_VEHICLE")
 			self:Show()
+		elseif (event == "PLAYER_ENTERING_WORLD" or event == "ZONE_CHANGED") then
+			if C_Map then
+				local bestMapID = C_Map.GetBestMapForUnit("player")
+				if bestMapID == ZM_MAP_ID then
+					if IceHUD:HasAnyBuff("player", IceCore.zmPuzzleIds) then
+						self:RegisterEvent("COMBAT_LOG_EVENT_UNFILTERED")
+						self:Hide()
+					end
+				end
+			end
+		elseif (event == "COMBAT_LOG_EVENT_UNFILTERED") then
+			local _,subevent,_,_,_,_,_,_,destName,_,_,spellId = CombatLogGetCurrentEventInfo()
+
+			if subevent == "SPELL_AURA_REMOVED" then
+				if destName == UnitName("player") then
+					if IceCore.zmPuzzleMap[spellId] then
+						self:Show()
+						self:UnregisterEvent("COMBAT_LOG_EVENT_UNFILTERED")
+					end
+				end
+			end
 		end
 	end)
 

IceHUD.lua

@@ -1,5 +1,5 @@
 local L = LibStub("AceLocale-3.0"):GetLocale("IceHUD", false)
-IceHUD = LibStub("AceAddon-3.0"):NewAddon("IceHUD", "AceConsole-3.0")
+IceHUD = LibStub("AceAddon-3.0"):NewAddon("IceHUD", "AceConsole-3.0", "AceHook-3.0")
 
 local IceHUD = IceHUD
 
@@ -7,8 +7,6 @@ local SML = LibStub("LibSharedMedia-3.0")
 local ACR = LibStub("AceConfigRegistry-3.0")
 local ConfigDialog = LibStub("AceConfigDialog-3.0")
 local icon = LibStub("LibDBIcon-1.0", true)
-local AceGUI = LibStub("AceGUI-3.0")
-local AceSerializer = LibStub("AceSerializer-3.0", 1)
 
 local pendingModuleLoads = {}
 local bReadyToRegisterModules = false
@@ -18,23 +16,50 @@ IceHUD.debugging = false
 
 IceHUD.WowVer = select(4, GetBuildInfo())
 IceHUD.WowMain = not WOW_PROJECT_ID or WOW_PROJECT_ID == WOW_PROJECT_MAINLINE
-IceHUD.WowClassic = WOW_PROJECT_ID and WOW_PROJECT_ID == WOW_PROJECT_CLASSIC
+if GetClassicExpansionLevel then
-IceHUD.WowClassicBC = WOW_PROJECT_ID and WOW_PROJECT_ID == WOW_PROJECT_BURNING_CRUSADE_CLASSIC
+	IceHUD.WowClassic = GetClassicExpansionLevel() == 0
+	IceHUD.WowClassicBC = GetClassicExpansionLevel() == 1
+	IceHUD.WowClassicWrath = GetClassicExpansionLevel() == 2
+else
+	IceHUD.WowClassic = WOW_PROJECT_ID and WOW_PROJECT_ID == WOW_PROJECT_CLASSIC
+	IceHUD.WowClassicBC = false
+	IceHUD.WowClassicWrath = false
+	if WOW_PROJECT_ID and WOW_PROJECT_ID == WOW_PROJECT_BURNING_CRUSADE_CLASSIC then
+		if not LE_EXPANSION_LEVEL_CURRENT or LE_EXPANSION_LEVEL_CURRENT == LE_EXPANSION_BURNING_CRUSADE then
+			IceHUD.WowClassicBC = true
+		elseif LE_EXPANSION_LEVEL_CURRENT == LE_EXPANSION_WRATH_OF_THE_LICH_KING then
+			IceHUD.WowClassicWrath = true
+		end
+	elseif WOW_PROJECT_WRATH_CLASSIC and WOW_PROJECT_ID == WOW_PROJECT_WRATH_CLASSIC then
+		IceHUD.WowClassicWrath = true
+	end
+end
 
 -- compatibility/feature flags
+IceHUD.GetPlayerAuraBySpellID = _G["C_UnitAuras"] and C_UnitAuras.GetPlayerAuraBySpellID
 IceHUD.SpellFunctionsReturnRank = IceHUD.WowMain and IceHUD.WowVer < 80000
-IceHUD.EventExistsPlayerPetChanged = IceHUD.WowVer < 80000 and not IceHUD.WowClassic and not IceHUD.WowClassicBC
+IceHUD.EventExistsPlayerPetChanged = IceHUD.WowMain and IceHUD.WowVer < 80000
-IceHUD.EventExistsPetBarChanged = IceHUD.WowVer < 80000 and not IceHUD.WowClassic and not IceHUD.WowClassicBC
+IceHUD.EventExistsPetBarChanged = IceHUD.WowMain and IceHUD.WowVer < 80000
 IceHUD.EventExistsPlayerComboPoints = IceHUD.WowMain and IceHUD.WowVer < 30000
 IceHUD.EventExistsUnitComboPoints = IceHUD.WowMain and IceHUD.WowVer < 70000
-IceHUD.EventExistsUnitMaxPower = IceHUD.WowMain and IceHUD.WowVer < 80000
+IceHUD.EventExistsUnitMaxPower = IceHUD.WowMain and IceHUD.WowVer >= 40000
-IceHUD.EventExistsGroupRosterUpdate = IceHUD.WowVer >= 50000 or IceHUD.WowClassic or IceHUD.WowClassicBC
+IceHUD.EventExistsGroupRosterUpdate = IceHUD.WowVer >= 50000 or not IceHUD.WowMain
 IceHUD.EventExistsUnitDynamicFlags = IceHUD.WowMain and IceHUD.WowVer < 80000
+IceHUD.EventExistsUnitHealthFrequent = not IceHUD.WowMain or (IceHUD.WowVer >= 40000 and IceHUD.WowVer < 90000)
 IceHUD.PerPowerEventsExist = IceHUD.WowMain and IceHUD.WowVer < 40000
 IceHUD.PerTargetComboPoints = IceHUD.WowVer < 60000
 IceHUD.CanTrackOtherUnitBuffs = not IceHUD.WowClassic
 IceHUD.CanTrackGCD = not IceHUD.WowClassic
 IceHUD.GetSpellInfoReturnsFunnel = IceHUD.WowMain and IceHUD.WowVer < 60000
+IceHUD.CanHookDestroyTotem = IceHUD.WowClassic or IceHUD.WowClassicBC or IceHUD.WowClassicWrath
+IceHUD.ShouldUpdateTargetHealthEveryTick = (IceHUD.WowClassic or IceHUD.WowClassicBC) and GetCVarBool("predictedHealth")
+IceHUD.UsesUIPanelButtonTemplate = IceHUD.WowVer >= 50000 or not IceHUD.WowMain
+IceHUD.EventExistsSpellcastInterruptible = IceHUD.WowVer >= 30200 and not IceHUD.WowClassicWrath
+IceHUD.DeathKnightUnholyFrostRunesSwapped = IceHUD.WowVer < 70300 and not IceHUD.WowClassicWrath
+IceHUD.SupportsHealPrediction = IceHUD.WowVer >= 40000 or IceHUD.WowClassicWrath
+IceHUD.UnitGroupRolesReturnsRoleString = IceHUD.WowVer >= 40000 or IceHUD.WowClassicWrath
+IceHUD.ShellGameSpellID = 271571
+IceHUD.HasShellGame = GetSpellInfo(IceHUD.ShellGameSpellID)
 
 IceHUD.UnitPowerEvent = "UNIT_POWER_UPDATE"
 
@@ -42,6 +67,8 @@ IceHUD.validBarList = { "Bar", "HiBar", "RoundBar", "ColorBar", "RivetBar", "Riv
 	"BloodGlaives", "ArcHUD", "FangRune", "DHUD", "CleanCurvesOut", "CleanTank", "PillTank", "GemTank" }
 IceHUD.validCustomModules = {Bar="Buff/Debuff watcher", Counter="Buff/Debuff stack counter", CD="Cooldown bar", Health="Health bar", Mana="Mana bar", CounterBar="Stack count bar"}
 
+IceHUD_UnitFrame_DropDown = CreateFrame("Frame", "IceHUD_UnitFrame_DropDown", UIParent, "UIDropDownMenuTemplate")
+
 --@debug@
 IceHUD.optionsLoaded = true
 --@end-debug@
@@ -66,6 +93,43 @@ end
 
 IceHUD.deepcopy = deepcopy
 
+function IceHUD:removeDefaults(db, defaults, blocker)
+	-- remove all metatables from the db, so we don't accidentally create new sub-tables through them
+	setmetatable(db, nil)
+	-- loop through the defaults and remove their content
+	for k,v in pairs(defaults) do
+		if type(v) == "table" and type(db[k]) == "table" then
+			-- if a blocker was set, dive into it, to allow multi-level defaults
+			self:removeDefaults(db[k], v, blocker and blocker[k])
+			if next(db[k]) == nil then
+				db[k] = nil
+			end
+		else
+			-- check if the current value matches the default, and that its not blocked by another defaults table
+			if db[k] == defaults[k] and (not blocker or blocker[k] == nil) then
+				db[k] = nil
+			end
+		end
+	end
+end
+
+function IceHUD:populateDefaults(db, defaults, blocker)
+	-- remove all metatables from the db, so we don't accidentally create new sub-tables through them
+	setmetatable(db, nil)
+	-- loop through the defaults and add their content
+	for k,v in pairs(defaults) do
+		if type(v) == "table" and type(db[k]) == "table" then
+			-- if a blocker was set, dive into it, to allow multi-level defaults
+			self:populateDefaults(db[k], v, blocker and blocker[k])
+		else
+			-- check if the current value matches the default, and that its not blocked by another defaults table
+			if db[k] == nil then
+				db[k] = defaults[k]
+			end
+		end
+	end
+end
+
 IceHUD.Location = "Interface\\AddOns\\IceHUD"
 
 StaticPopupDialogs["ICEHUD_CUSTOM_BAR_CREATED"] =
@@ -341,7 +405,7 @@ end
 -- blizzard interface options
 local blizOptionsPanel = CreateFrame("FRAME", "IceHUDConfigPanel", UIParent)
 blizOptionsPanel.name = "IceHUD"
-blizOptionsPanel.button = CreateFrame("BUTTON", "IceHUDOpenConfigButton", blizOptionsPanel, (IceHUD.WowVer >= 50000 or IceHUD.WowClassic or IceHUD.WowClassicBC) and "UIPanelButtonTemplate" or "UIPanelButtonTemplate2")
+blizOptionsPanel.button = CreateFrame("BUTTON", "IceHUDOpenConfigButton", blizOptionsPanel, IceHUD.UsesUIPanelButtonTemplate and "UIPanelButtonTemplate" or "UIPanelButtonTemplate2")
 blizOptionsPanel.button:SetText("Open IceHUD configuration")
 blizOptionsPanel.button:SetWidth(240)
 blizOptionsPanel.button:SetHeight(30)
@@ -431,6 +495,16 @@ function IceHUD:GetAuraCount(auraType, unit, ability, onlyMine, matchByName)
 		return 0
 	end
 
+	-- Support for Spell IDs
+	if (IceHUD.GetPlayerAuraBySpellID and tonumber(ability) ~= nil) then
+		local aura = C_UnitAuras.GetPlayerAuraBySpellID(ability)
+		if aura ~= nil then
+			return aura.applications
+		else
+			return 0
+		end
+	end
+
 	local i = 1
 	local name, _, texture, applications
 	if IceHUD.SpellFunctionsReturnRank then
@@ -492,6 +566,30 @@ do
 	function IceHUD:HasDebuffs(unit, spellIDs, filter)
 		return IceHUD:HasBuffs(unit, spellIDs, filter and filter.."|HARMFUL" or "HARMFUL")
 	end
+
+	function IceHUD:HasAnyBuff(unit, spellIDs, filter)
+		local buffs = IceHUD:HasBuffs(unit, spellIDs, filter)
+
+		for i=1, #buffs do
+			if buffs[i] then
+				return true
+			end
+		end
+
+		return false
+	end
+
+	function IceHUD:HasAnyDebuff(unit, spellIDs, filter)
+		local debuffs = IceHUD:HasDebuffs(unit, spellIDs, filter)
+
+		for i=1, #debuffs do
+			if debuffs[i] then
+				return true
+			end
+		end
+
+		return false
+	end
 end
 
 function IceHUD:OnDisable()
@@ -631,14 +729,14 @@ function IceHUD:GetIsInLFGGroup()
 	end
 
 	local mode, submode
-	if IceHUD.WowVer >= 50000 then
+	if LE_LFG_CATEGORY_LFD then
 		mode, submode = GetLFGMode(LE_LFG_CATEGORY_LFD)
 	else
 		mode, submode = GetLFGMode()
 	end
 	local IsInLFGGroup = CheckLFGMode(mode)
 
-	if IceHUD.WowVer < 50000 then
+	if not LE_LFG_CATEGORY_LFD then
 		return IsInLFGGroup
 	end
 
@@ -658,31 +756,69 @@ function IceHUD:GetIsInLFGGroup()
 	return IsInLFGGroup
 end
 
-local BLACKLISTED_UNIT_MENU_OPTIONS = {
+local BLACKLISTED_UNIT_MENU_OPTIONS = {}
-	SET_FOCUS = "ICEHUD_SET_FOCUS",
+if UnitPopupButtons then
-	CLEAR_FOCUS = "ICEHUD_CLEAR_FOCUS",
+	BLACKLISTED_UNIT_MENU_OPTIONS = {
-    PET_DISMISS = "ICEHUD_PET_DISMISS",
+		SET_FOCUS = "ICEHUD_SET_FOCUS",
-	LOCK_FOCUS_FRAME = true,
+		CLEAR_FOCUS = "ICEHUD_CLEAR_FOCUS",
-	UNLOCK_FOCUS_FRAME = true,
+		LOCK_FOCUS_FRAME = true,
-}
+		UNLOCK_FOCUS_FRAME = true,
+	}
+	if select(2, UnitClass("player")) ~= "WARLOCK" then
+		BLACKLISTED_UNIT_MENU_OPTIONS[PET_DISMISS] = "ICEHUD_PET_DISMISS"
+	end
 
-UnitPopupButtons["ICEHUD_SET_FOCUS"] = {
+	UnitPopupButtons["ICEHUD_SET_FOCUS"] = {
-	text = L["Type %s to set focus"]:format(SLASH_FOCUS1),
+		text = L["Type %s to set focus"]:format(SLASH_FOCUS1),
-	tooltipText = L["Blizzard currently does not provide a proper way to right-click focus with custom unit frames."],
+		tooltipText = L["Blizzard currently does not provide a proper way to right-click focus with custom unit frames."],
-	dist = 0,
+		dist = 0,
-}
+	}
 
-UnitPopupButtons["ICEHUD_CLEAR_FOCUS"] = {
+	UnitPopupButtons["ICEHUD_CLEAR_FOCUS"] = {
-	text = L["Type %s to clear focus"]:format(SLASH_CLEARFOCUS1),
+		text = L["Type %s to clear focus"]:format(SLASH_CLEARFOCUS1),
-	tooltipText = L["Blizzard currently does not provide a proper way to right-click focus with custom unit frames."],
+		tooltipText = L["Blizzard currently does not provide a proper way to right-click focus with custom unit frames."],
-	dist = 0,
+		dist = 0,
-}
+	}
 
-UnitPopupButtons["ICEHUD_PET_DISMISS"] = {
+	UnitPopupButtons["ICEHUD_PET_DISMISS"] = {
-	text = L["Use your Dismiss Pet spell to dismiss a pet"],
+		text = L["Use your Dismiss Pet spell to dismiss a pet"],
-	tooltipText = L["Blizzard currently does not provide a proper way to right-click dismiss a pet with custom unit frames."],
+		tooltipText = L["Blizzard currently does not provide a proper way to right-click dismiss a pet with custom unit frames."],
-	dist = 0,
+		dist = 0,
-}
+	}
+elseif UnitPopupSetFocusButtonMixin then
+	IceHUDUnitPopupSetFocusButtonMixin = CreateFromMixins(UnitPopupButtonBaseMixin)
+	function IceHUDUnitPopupSetFocusButtonMixin:GetText()
+		return L["Type %s to set focus"]:format(SLASH_FOCUS1)
+	end
+	function IceHUDUnitPopupSetFocusButtonMixin:OnClick()
+	end
+
+	IceHUDUnitPopupClearFocusButtonMixin = CreateFromMixins(UnitPopupButtonBaseMixin)
+	function IceHUDUnitPopupClearFocusButtonMixin:GetText()
+		return L["Type %s to clear focus"]:format(SLASH_CLEARFOCUS1)
+	end
+	function IceHUDUnitPopupClearFocusButtonMixin:OnClick()
+	end
+
+	IceHUDUnitPopupPetDismissButtonMixin = CreateFromMixins(UnitPopupButtonBaseMixin)
+	function IceHUDUnitPopupPetDismissButtonMixin:GetText()
+		return L["Use your Dismiss Pet spell to dismiss a pet"]
+	end
+	function IceHUDUnitPopupPetDismissButtonMixin:CanShow()
+		return UnitPopupPetDismissButtonMixin:CanShow()
+	end
+	function IceHUDUnitPopupPetDismissButtonMixin:OnClick()
+	end
+
+	BLACKLISTED_UNIT_MENU_OPTIONS[SET_FOCUS] = IceHUDUnitPopupSetFocusButtonMixin
+	BLACKLISTED_UNIT_MENU_OPTIONS[CLEAR_FOCUS] = IceHUDUnitPopupClearFocusButtonMixin
+	BLACKLISTED_UNIT_MENU_OPTIONS[LOCK_FOCUS_FRAME] = true
+	BLACKLISTED_UNIT_MENU_OPTIONS[UNLOCK_FOCUS_FRAME] = true
+
+	if select(2, UnitClass("player")) ~= "WARLOCK" then
+		BLACKLISTED_UNIT_MENU_OPTIONS[PET_DISMISS] = IceHUDUnitPopupPetDismissButtonMixin
+	end
+end
 
 local munged_unit_menus = {}
 local function munge_unit_menu(menu)
@@ -703,11 +839,34 @@ local function munge_unit_menu(menu)
 	end
 
 	local found = false
-	local _, v
+	if data.GetMenuButtons then
-	for _, v in ipairs(data) do
+		local btns = data.GetMenuButtons()
-		if BLACKLISTED_UNIT_MENU_OPTIONS[v] then
+		for i=1, #btns do
-			found = true
+			if btns[i].IsMenu() then
-			break
+				local subbtns = btns[i].GetMenuButtons()
+				for j=1, #subbtns do
+					if BLACKLISTED_UNIT_MENU_OPTIONS[subbtns[j]:GetText()] then
+						found = true
+						break
+					end
+				end
+			else
+				if BLACKLISTED_UNIT_MENU_OPTIONS[btns[i]:GetText()] then
+					found = true
+					break
+				end
+			end
+
+			if found then
+				break
+			end
+		end
+	else
+		for _, v in ipairs(data) do
+			if BLACKLISTED_UNIT_MENU_OPTIONS[v] then
+				found = true
+				break
+			end
 		end
 	end
 
@@ -718,15 +877,42 @@ local function munge_unit_menu(menu)
 	end
 
 	local new_data = {}
-	for _, v in ipairs(data) do
+	if data.GetMenuButtons then
-		local blacklisted = BLACKLISTED_UNIT_MENU_OPTIONS[v]
+		local new_buttons_list = {}
-		if v == "PET_DISMISS" and select(2, UnitClass("player")) == "WARLOCK" then
+		local btns = data.GetMenuButtons()
-			blacklisted = false
+		for i=1, #btns do
+			if btns[i].IsMenu() then
+				local subbtns = btns[i].GetMenuButtons()
+				for j=1, #subbtns do
+					local blacklisted = BLACKLISTED_UNIT_MENU_OPTIONS[subbtns[j]:GetText()]
+					if not blacklisted then
+						new_buttons_list[#new_buttons_list+1] = subbtns[j]
+					elseif blacklisted ~= true then
+						new_buttons_list[#new_buttons_list+1] = blacklisted
+					end
+				end
+			else
+				local blacklisted = BLACKLISTED_UNIT_MENU_OPTIONS[btns[i]:GetText()]
+				if not blacklisted then
+					new_buttons_list[#new_buttons_list+1] = btns[i]
+				elseif blacklisted ~= true then
+					new_buttons_list[#new_buttons_list+1] = blacklisted
+				end
+			end
 		end
-		if not blacklisted then
+
-			new_data[#new_data+1] = v
+		new_data = data
-		elseif blacklisted ~= true then
+		function new_data:GetMenuButtons()
-			new_data[#new_data+1] = blacklisted
+			return new_buttons_list
+		end
+	else
+		for _, v in ipairs(data) do
+			local blacklisted = BLACKLISTED_UNIT_MENU_OPTIONS[v]
+			if not blacklisted then
+				new_data[#new_data+1] = v
+			elseif blacklisted ~= true then
+				new_data[#new_data+1] = blacklisted
+			end
 		end
 	end
 	local new_menu_name = "ICEHUD_" .. menu
@@ -772,7 +958,6 @@ local function figure_unit_menu(unit)
 	return "PLAYER"
 end
 
-IceHUD_UnitFrame_DropDown = CreateFrame("Frame", "IceHUD_UnitFrame_DropDown", UIParent, "UIDropDownMenuTemplate")
 if UnitPopupFrames then
 	UnitPopupFrames[#UnitPopupFrames+1] = "IceHUD_UnitFrame_DropDown"
 end
@@ -789,3 +974,53 @@ UIDropDownMenu_Initialize(IceHUD_UnitFrame_DropDown, function()
 		UnitPopup_ShowMenu(IceHUD_UnitFrame_DropDown, menu, IceHUD.DropdownUnit, nil, id)
 	end
 end, "MENU", nil)
+
+function IceHUD:OutOfCombatWrapper(func)
+	return function(...)
+		return IceHUD:RunOnLeaveCombat(func, ...)
+	end
+end
+
+do
+	local in_combat = false
+	local in_lockdown = false
+	local actions_to_perform = {}
+	local pool = setmetatable({}, {__mode='k'})
+	function IceHUD:PLAYER_REGEN_ENABLED()
+		in_combat = false
+		in_lockdown = false
+		for i, t in ipairs(actions_to_perform) do
+			t.f(unpack(t, 1, t.n))
+			actions_to_perform[i] = nil
+			wipe(t)
+			pool[t] = true
+		end
+	end
+	function IceHUD:PLAYER_REGEN_DISABLED()
+		in_combat = true
+	end
+	function IceHUD:RunOnLeaveCombat(func, ...)
+		if not in_combat then
+			-- out of combat, call right away and return
+			func(...)
+			return
+		end
+		if not in_lockdown then
+			in_lockdown = InCombatLockdown() -- still in PLAYER_REGEN_DISABLED
+			if not in_lockdown then
+				func(...)
+				return
+			end
+		end
+		local t = next(pool) or {}
+		pool[t] = nil
+
+		t.f = func
+		local n = select('#', ...)
+		t.n = n
+		for i = 1, n do
+			t[i] = select(i, ...)
+		end
+		actions_to_perform[#actions_to_perform+1] = t
+	end
+end

IceHUD.toc

@@ -1,7 +1,8 @@
-## Interface: 90100
+## Interface: 100002
-## Interface-Retail: 90100
+## Interface-Retail: 100002
-## Interface-Classic: 11306
+## Interface-Classic: 11403
-## Interface-BCC: 20501
+## Interface-BCC: 20504
+## Interface-Wrath: 30400
 ## Author: Parnic, originally created by Iceroth
 ## Name: IceHUD
 ## Title: IceHUD |cff7fff7f-Ace3-|r
@@ -18,6 +19,7 @@
 ## X-Website: https://www.wowace.com/projects/ice-hud
 ## X-Curse-Project-ID: 5394
 ## X-WoWI-ID: 8149
+## X-Wago-ID: 5bGolJN0
 
 #@no-lib-strip@
 # Libraries
@@ -97,7 +99,11 @@ modules\Stagger.lua
 modules\PlayerAltMana.lua
 modules\ArcaneCharges.lua
 modules\RollTheBones.lua
+modules\EssencePower.lua
 
 #@do-not-package@
+IceHUD_Options\Json.lua
+IceHUD_Options\JsonDecode.lua
+IceHUD_Options\JsonEncode.lua
 IceHUD_Options\Options.lua
 #@end-do-not-package@

IceHUD_Options/IceHUD_Options.toc

@@ -1,7 +1,8 @@
-## Interface: 90100
+## Interface: 100002
-## Interface-Retail: 90100
+## Interface-Retail: 100002
-## Interface-Classic: 11306
+## Interface-Classic: 11403
-## Interface-BCC: 20501
+## Interface-BCC: 20504
+## Interface-Wrath: 30400
 ## Title: IceHUD |cff7fff7f-Options-|r
 ## Author: Parnic
 ## Version: @project-version@
@@ -10,4 +11,7 @@
 ## Dependencies: IceHUD
 ## LoadOnDemand: 1
 
+Json.lua
+JsonDecode.lua
+JsonEncode.lua
 Options.lua

IceHUD_Options/Json.lua

@@ -0,0 +1 @@
+IceHUD.json = {}

IceHUD_Options/JsonDecode.lua

@@ -0,0 +1,241 @@
+local parse
+
+local function create_set(...)
+    local res = {}
+    for i = 1, select("#", ...) do
+        res[select(i, ...)] = true
+    end
+    return res
+end
+
+local space_chars  = create_set(" ", "\t", "\r", "\n")
+local delim_chars  = create_set(" ", "\t", "\r", "\n", "]", "}", ",")
+local escape_chars = create_set("\\", "/", '"', "b", "f", "n", "r", "t", "u")
+local literals     = create_set("true", "false", "null")
+
+local literal_map = {
+    ["true"] = true,
+    ["false"] = false,
+    ["null"] = nil,
+}
+
+
+local function next_char(str, idx, set, negate)
+    for i = idx, #str do
+        if set[str:sub(i, i)] ~= negate then
+            return i
+        end
+    end
+    return #str + 1
+end
+
+local function decode_error(str, idx, msg)
+    local line_count = 1
+    local col_count = 1
+    for i = 1, idx - 1 do
+        col_count = col_count + 1
+        if str:sub(i, i) == "\n" then
+            line_count = line_count + 1
+            col_count = 1
+        end
+    end
+
+    return string.format("%s at line %d col %d", msg, line_count, col_count)
+end
+
+local function codepoint_to_utf8(n)
+    -- http://scripts.sil.org/cms/scripts/page.php?site_id=nrsi&id=iws-appendixa
+    local f = math.floor
+    if n <= 0x7f then
+        return string.char(n)
+    elseif n <= 0x7ff then
+        return string.char(f(n / 64) + 192, n % 64 + 128)
+    elseif n <= 0xffff then
+        return string.char(f(n / 4096) + 224, f(n % 4096 / 64) + 128, n % 64 + 128)
+    elseif n <= 0x10ffff then
+        return string.char(f(n / 262144) + 240, f(n % 262144 / 4096) + 128,
+            f(n % 4096 / 64) + 128, n % 64 + 128)
+    end
+    return "", string.format("invalid unicode codepoint '%x'", n)
+end
+
+local function parse_unicode_escape(s)
+    local n1 = tonumber(s:sub(1, 4), 16)
+    local n2 = tonumber(s:sub(7, 10), 16)
+    -- Surrogate pair?
+    if n2 then
+        return codepoint_to_utf8((n1 - 0xd800) * 0x400 + (n2 - 0xdc00) + 0x10000)
+    else
+        return codepoint_to_utf8(n1)
+    end
+end
+
+local function parse_string(str, i)
+    local res = ""
+    local j = i + 1
+    local k = j
+
+    while j <= #str do
+        local x = str:byte(j)
+
+        if x < 32 then
+            return str, j, decode_error(str, j, "control character in string")
+
+        elseif x == 92 then -- `\`: Escape
+            res = res .. str:sub(k, j - 1)
+            j = j + 1
+            local c = str:sub(j, j)
+            if c == "u" then
+                local hex = str:match("^[dD][89aAbB]%x%x\\u%x%x%x%x", j + 1)
+                    or str:match("^%x%x%x%x", j + 1)
+                    or false
+                if hex == false then
+                    return str, j-1, decode_error(str, j - 1, "invalid unicode escape in string")
+                end
+                res = res .. parse_unicode_escape(hex)
+                j = j + #hex
+            else
+                if not escape_chars[c] then
+                    return str, j-1, decode_error(str, j - 1, "invalid escape char '" .. c .. "' in string")
+                end
+                res = res .. escape_char_map_inv[c]
+            end
+            k = j + 1
+
+        elseif x == 34 then -- `"`: End of string
+            res = res .. str:sub(k, j - 1)
+            return res, j + 1
+        end
+
+        j = j + 1
+    end
+
+    return str, i, decode_error(str, i, "expected closing quote for string")
+end
+
+local function parse_number(str, i)
+    local x = next_char(str, i, delim_chars)
+    local s = str:sub(i, x - 1)
+    local n = tonumber(s)
+    if not n then
+        return -1, -1, decode_error(str, i, "invalid number '" .. s .. "'")
+    end
+    return n, x
+end
+
+local function parse_literal(str, i)
+    local x = next_char(str, i, delim_chars)
+    local word = str:sub(i, x - 1)
+    if not literals[word] then
+        return false, -1, decode_error(str, i, "invalid literal '" .. word .. "'")
+    end
+    return literal_map[word], x
+end
+
+local function parse_array(str, i)
+    local res = {}
+    local n = 1
+    i = i + 1
+    while 1 do
+        local x
+        i = next_char(str, i, space_chars, true)
+        -- Empty / end of array?
+        if str:sub(i, i) == "]" then
+            i = i + 1
+            break
+        end
+        -- Read token
+        x, i = parse(str, i)
+        res[n] = x
+        n = n + 1
+        -- Next token
+        i = next_char(str, i, space_chars, true)
+        local chr = str:sub(i, i)
+        i = i + 1
+        if chr == "]" then break end
+        if chr ~= "," then return nil, -1, decode_error(str, i, "expected ']' or ','") end
+    end
+    return res, i
+end
+
+local function parse_object(str, i)
+    local res = {}
+    i = i + 1
+    while 1 do
+        local key, val
+        i = next_char(str, i, space_chars, true)
+        -- Empty / end of object?
+        if str:sub(i, i) == "}" then
+            i = i + 1
+            break
+        end
+        -- Read key
+        if str:sub(i, i) ~= '"' then
+            return nil, -1, decode_error(str, i, "expected string for key")
+        end
+        key, i = parse(str, i)
+        -- Read ':' delimiter
+        i = next_char(str, i, space_chars, true)
+        if str:sub(i, i) ~= ":" then
+            return nil, -1, decode_error(str, i, "expected ':' after key")
+        end
+        i = next_char(str, i + 1, space_chars, true)
+        -- Read value
+        val, i = parse(str, i)
+        -- Set
+        res[key] = val
+        -- Next token
+        i = next_char(str, i, space_chars, true)
+        local chr = str:sub(i, i)
+        i = i + 1
+        if chr == "}" then break end
+        if chr ~= "," then return nil, -1, decode_error(str, i, "expected '}' or ','") end
+    end
+    return res, i
+end
+
+local char_func_map = {
+    ['"'] = parse_string,
+    ["0"] = parse_number,
+    ["1"] = parse_number,
+    ["2"] = parse_number,
+    ["3"] = parse_number,
+    ["4"] = parse_number,
+    ["5"] = parse_number,
+    ["6"] = parse_number,
+    ["7"] = parse_number,
+    ["8"] = parse_number,
+    ["9"] = parse_number,
+    ["-"] = parse_number,
+    ["t"] = parse_literal,
+    ["f"] = parse_literal,
+    ["n"] = parse_literal,
+    ["["] = parse_array,
+    ["{"] = parse_object,
+}
+
+
+parse = function(str, idx)
+    local chr = str:sub(idx, idx)
+    local f = char_func_map[chr]
+    if f then
+        return f(str, idx)
+    end
+    return false, -1, decode_error(str, idx, "unexpected character '" .. chr .. "'")
+end
+
+
+function IceHUD.json.decode(str)
+    if type(str) ~= "string" then
+        return nil, "expected argument of type string, got " .. type(str)
+    end
+    local res, idx, err = parse(str, next_char(str, 1, space_chars, true))
+    if err ~= nil then
+        return nil, err
+    end
+    idx = next_char(str, idx, space_chars, true)
+    if idx <= #str then
+        return nil, decode_error(str, idx, "trailing garbage")
+    end
+    return res, nil
+end

IceHUD_Options/JsonEncode.lua

@@ -0,0 +1,100 @@
+local encode
+
+local escape_char_map = {
+	["\\"] = "\\",
+	["\""] = "\"",
+	["\b"] = "b",
+	["\f"] = "f",
+	["\n"] = "n",
+	["\r"] = "r",
+	["\t"] = "t",
+}
+
+local escape_char_map_inv = { ["/"] = "/" }
+for k, v in pairs(escape_char_map) do
+	escape_char_map_inv[v] = k
+end
+
+
+local function escape_char(c)
+	return "\\" .. (escape_char_map[c] or string.format("u%04x", c:byte()))
+end
+
+local function encode_nil(val)
+	return "null"
+end
+
+local function encode_table(val, stack)
+	local res = {}
+	stack = stack or {}
+
+	-- Circular reference?
+	if stack[val] then error("circular reference") end
+
+	stack[val] = true
+
+	if rawget(val, 1) ~= nil or next(val) == nil then
+		-- Treat as array -- check keys are valid and it is not sparse
+		local n = 0
+		for k in pairs(val) do
+			if type(k) ~= "number" then
+				error("invalid table: mixed or invalid key types")
+			end
+			n = n + 1
+		end
+		if n ~= #val then
+			error("invalid table: sparse array")
+		end
+		-- Encode
+		for i, v in ipairs(val) do
+			table.insert(res, encode(v, stack))
+		end
+		stack[val] = nil
+		return "[" .. table.concat(res, ",") .. "]"
+
+	else
+		-- Treat as an object
+		for k, v in pairs(val) do
+			if type(k) ~= "string" then
+				error("invalid table: mixed or invalid key types")
+			end
+			table.insert(res, encode(k, stack) .. ":" .. encode(v, stack))
+		end
+		stack[val] = nil
+		return "{" .. table.concat(res, ",") .. "}"
+	end
+end
+
+local function encode_string(val)
+	return '"' .. val:gsub('[%z\1-\31\\"]', escape_char) .. '"'
+end
+
+local function encode_number(val)
+	-- Check for NaN, -inf and inf
+	if val ~= val or val <= -math.huge or val >= math.huge then
+		error("unexpected number value '" .. tostring(val) .. "'")
+	end
+	return string.format("%.14g", val)
+end
+
+local type_func_map = {
+	["nil"] = encode_nil,
+	["table"] = encode_table,
+	["string"] = encode_string,
+	["number"] = encode_number,
+	["boolean"] = tostring,
+}
+
+
+encode = function(val, stack)
+	local t = type(val)
+	local f = type_func_map[t]
+	if f then
+		return f(val, stack)
+	end
+	error("unexpected type '" .. t .. "'")
+end
+
+function IceHUD.json.encode(val)
+	return (encode(val))
+end

IceHUD_Options/Options.lua

@@ -1,6 +1,8 @@
 local LibDualSpec = LibStub('LibDualSpec-1.0', true)
 local L = LibStub("AceLocale-3.0"):GetLocale("IceHUD", false)
 local icon = LibStub("LibDBIcon-1.0", true)
+local AceGUI = LibStub("AceGUI-3.0")
+local AceSerializer = LibStub("AceSerializer-3.0", 1)
 local lastCustomModule = "Bar"
 
 IceHUD_Options = {}
@@ -83,13 +85,13 @@ If you have |cff42ffffDogTags|r enabled, you can open the Text Settings for the
 This is a side effect of the animation API that I'm co-opting to force a rotation without having to provide duplicates of every bar texture in the mod. Any bar moving sufficiently quickly and updating rapidly will cause this. |cff9999ffIceHUD|r is intended to be a vertically-oriented mod, so the rotation feature is there for people who are willing to accept the side effects that come with it. My suggestion is to use one of the many horizontally-oriented bar mods out there if you're wanting horizontal bars. |cff42ffffQuartz|r is a good castbar replacement that you can use and disable |cff9999ffIceHUD|r's built-in castbar, for example.
 
 |cff9999ff18. How do I get rid of the bars that showed up beneath the player in the 7.0 patch?|r
-Blizzard added a "Personal Resource Display" feature in the 7.0 game client. You can disable it in the Game options -> Interface -> Names -> Personal Resource Display.
+Blizzard added a "Personal Resource Display" feature in the 7.0 game client. You can disable it in the Game options -> |cffffdc42Interface|r -> |cffffdc42Names|r -> |cffffdc42Personal Resource Display|r (or Options -> |cffffdc42Combat|r -> |cffffdc42Personal Resource Display|r, in 10.0+).
 
 |cff9999ff19. Why is there no target castbar for Classic?|r
-The Classic game client doesn't offer a reliable way to show castbars for anyone except the player. You can install the LibCasterCasterino addon to enable support, but it's a best guess and not at all accurate.
+The Classic game client doesn't offer a reliable way to show castbars for anyone except the player. You can install the |cff42ffffLibCasterCasterino|r addon to enable support, but it's a best guess and not at all accurate.
 
 |cff9999ff20. Why do buff/debuff timers not work in Classic?|r
-The Classic game client doesn't provide this information to addons because it wasn't a feature when the game first released. You can install the LibClassicDurations addon to enable support, but it's a best guess and not at all accurate.]]
+The Classic game client doesn't provide this information to addons because it wasn't a feature when the game first released. You can install the |cff42ffffLibClassicDurations|r addon to enable support, but it's a best guess and not at all accurate.]]
 				}
 			}
 		},
@@ -421,7 +423,7 @@ The Classic game client doesn't provide this information to addons because it wa
 							IceHUD.IceCore.IceHUDFrame:Show()
 						end
 					end,
-					hidden = IceHUD.WowVer < 80000,
+					hidden = not IceHUD.HasShellGame,
 					order = 36,
 				},
 			}
@@ -757,6 +759,9 @@ function IceHUD_Options:OnLoad()
 	self:GenerateModuleOptions(true)
 	self.options.args.colors.args = IceHUD.IceCore:GetColorOptions()
 	self.options.args.profiles = LibStub("AceDBOptions-3.0"):GetOptionsTable(IceHUD.db)
+	--@debug@
+	IceHUD_Options:SetupProfileImportButtons()
+	--@end-debug@
 
 	-- Add dual-spec support
 	if IceHUD.db ~= nil and LibDualSpec then
@@ -787,14 +792,14 @@ function IceHUD_Options:SetupProfileImportButtons()
 				editbox:SetLabel("Profile")
 				editbox:SetFullWidth(true)
 				editbox:SetFullHeight(true)
-				local profileTable = deepcopy(IceHUD.db.profile)
+				local profileTable = IceHUD.deepcopy(IceHUD.db.profile)
 				IceHUD:removeDefaults(profileTable, IceHUD.IceCore.defaults.profile)
-				editbox:SetText(IceHUD:Serialize(profileTable))
+				editbox:SetText(IceHUD.json.encode(profileTable))
 				editbox:DisableButton(true)
 				frame:AddChild(editbox)
 			end,
 			hidden =
-				-- hello, snooper! this feature doesn't actually work yet, so enabling it won't help you much :)
+				-- hello, snooper! exporting works well enough, but importing is very rough, so enable this at your own peril
 				--[===[@non-debug@
 				true
 				--@end-non-debug@]===]
@@ -803,7 +808,7 @@ function IceHUD_Options:SetupProfileImportButtons()
 				--@end-debug@
 			,
 			disabled =
-				-- hello, snooper! this feature doesn't actually work yet, so enabling it won't help you much :)
+				-- hello, snooper! exporting works well enough, but importing is very rough, so enable this at your own peril
 				--[===[@non-debug@
 				true
 				--@end-non-debug@]===]
@@ -824,11 +829,14 @@ function IceHUD_Options:SetupProfileImportButtons()
 				frame:SetStatusText("Exported profile details")
 				frame:SetLayout("Flow")
 				frame:SetCallback("OnClose", function(widget)
-					local success, newTable = IceHUD:Deserialize(widget.children[1]:GetText())
+					local newTable, err = IceHUD.json.decode(widget.children[1]:GetText())
-					if success then
+					if err ~= nil then
+						print("failed to import profile: "..err)
+					else
+						print("importing profile")
 						IceHUD:PreProfileChanged()
 						IceHUD:populateDefaults(newTable, IceHUD.IceCore.defaults.profile)
-						IceHUD.db.profile = deepcopy(newTable)
+						IceHUD.db.profile = IceHUD.deepcopy(newTable)
 						IceHUD:PostProfileChanged()
 					end
 					AceGUI:Release(widget)
@@ -841,7 +849,7 @@ function IceHUD_Options:SetupProfileImportButtons()
 				frame:AddChild(editbox)
 			end,
 			hidden =
-				-- hello, snooper! this feature doesn't actually work yet, so enabling it won't help you much :)
+				-- hello, snooper! this feature is really rough, so enable it at your own peril
 				--[===[@non-debug@
 				true
 				--@end-non-debug@]===]
@@ -850,7 +858,7 @@ function IceHUD_Options:SetupProfileImportButtons()
 				--@end-debug@
 			,
 			disabled =
-				-- hello, snooper! this feature doesn't actually work yet, so enabling it won't help you much :)
+				-- hello, snooper! this feature is really rough, so enable it at your own peril
 				--[===[@non-debug@
 				true
 				--@end-non-debug@]===]
@@ -862,7 +870,3 @@ function IceHUD_Options:SetupProfileImportButtons()
 		}
 	end
 end
-
---@debug@
-IceHUD_Options:SetupProfileImportButtons()
---@end-debug@

IceHUD_Options/TablePrint.lua

@@ -0,0 +1,37 @@
+local function table_print(tt, indent, done)
+	done = done or {}
+	indent = indent or 0
+	if type(tt) == "table" then
+		local sb = {}
+		for key, value in pairs(tt) do
+			table.insert(sb, string.rep(" ", indent)) -- indent it
+			if type(value) == "table" and not done[value] then
+				done[value] = true
+				table.insert(sb, key .. " = {\n");
+				table.insert(sb, table_print(value, indent + 2, done))
+				table.insert(sb, string.rep(" ", indent)) -- indent it
+				table.insert(sb, "}\n");
+			elseif "number" == type(key) then
+				table.insert(sb, string.format("\"%s\"\n", tostring(value)))
+			else
+				table.insert(sb, string.format(
+					"%s = \"%s\"\n", tostring(key), tostring(value)))
+			end
+		end
+		return table.concat(sb)
+	else
+		return tt .. "\n"
+	end
+end
+
+local function to_string(tbl)
+	if "nil" == type(tbl) then
+		return tostring(nil)
+	elseif "table" == type(tbl) then
+		return table_print(tbl)
+	elseif "string" == type(tbl) then
+		return tbl
+	else
+		return tostring(tbl)
+	end
+end

IceStackCounter.lua

@@ -52,7 +52,13 @@ function IceStackCounter_GetOptions(frame, opts)
 	opts["auraName"] = {
 		type = 'input',
 		name = L["Aura to track"],
-		desc = L["Which buff/debuff this counter will be tracking. \n\nRemember to press ENTER after filling out this box with the name you want or it will not save."],
+		desc = function()
+			if IceHUD.GetPlayerAuraBySpellID then
+				return L["Which buff/debuff this counter will be tracking. Can use the name or spell id. \n\nRemember to press ENTER after filling out this box with the name you want or it will not save."]
+			else
+				return L["Which buff/debuff this counter will be tracking. \n\nRemember to press ENTER after filling out this box with the name you want or it will not save."]
+			end
+		end,
 		get = function()
 			return frame.moduleSettings.auraName
 		end,

LICENSE

@@ -1,6 +1,6 @@
 MIT License
 
-Copyright (c) 2021 parnic
+Copyright (c) 2021-2022 parnic
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal

changelog.md

@@ -1,5 +1,114 @@
 # Changelog
 
+v1.14.5:
+
+- Fix castbar flashing. There are controls on the player castbar module for flashing when a spell succeeds or fails, and separate controls for flashing when an instant cast completes. Those were broken, but now work again.
+- Add "@" after the number when the Combo Points module is in Numeric mode, "Show Charged points" is enabled, and the current combo point is charged.
+- Fix Charged point support in the ComboPointsBar module.
+
+v1.14.4:
+
+- Update TOC for 10.0.2
+
+v1.14.3:
+
+- Add Spell ID support for aura tracking.
+- Add Evoker support.
+- Add Empowered Casting (hold-to-cast levels) support.
+
+v1.14.2:
+
+- Fix CC and Invuln modules not showing immediately when they should.
+
+v1.14.1:
+
+- Fix Hide Party feature on pre-10.0 clients.
+
+v1.14.0:
+
+- 10.0 compatibility
+- Renamed Anima Charged combo points to Charged, and removed specific references to Kyrian.
+
+v1.13.17.3:
+
+- Packaged latest LibDogTag-Unit to work around crash in Wrath Classic client.
+
+v1.13.17.2:
+
+- Fixed Runes disappearing for Death Knights on Wrath Classic when using the dual spec feature.
+
+v1.13.17.1:
+
+- Fixed Priests hanging on login on the retail client.
+
+v1.13.17:
+
+- Internal maintainability updates. There are so many versions of the game now, updates need to be as easy and safe as possible.
+- Improved reliability of Slice-n-Dice predicted length when changing talents.
+- Improved various modules's ability to respond to the player's maximum power type changing (going from 5 max combo points to 6, for example).
+- Fixed invalid texture layers specified on a variety of textures (10.0 fix).
+- Removed HolyPowerNumeric text from the configuration options of several modules that it didn't belong with.
+- Fixed combo points in Classic Era clients.
+
+v1.13.16:
+
+- Enabled Incoming Heal Prediction on Wrath-Classic.
+- Added detection for the full Wrath Classic build (not just the pre-patch).
+
+v1.13.15:
+
+- Updated TOC for Retail (9.2.7).
+- Added Wrath-Classic compatibility.
+
+v1.13.14.3:
+
+- Restored right-click menus on Info and Health bars when targeting other players.
+
+v1.13.14.2:
+
+- Restored right-click menus on Info and Health bars.
+
+v1.13.14.1:
+
+- Restored guard around array that doesn't exist on Classic clients.
+
+v1.13.14:
+
+- Fixed target health updating infrequently on Classic.
+- Fixed compatibility with WoW 9.2.5.
+- Updated TOC for all game flavors.
+
+v1.13.13:
+
+- Slight optimization of Zereth Mortis puzzle detection logic.
+- Fixed target health updating infrequently on Classic-BC.
+- Fixed reported error in TargetInvuln module.
+
+v1.13.12:
+
+- Hide IceHUD during Zereth Mortis puzzles
+- Fixed default player and target frames coming back sometimes (github issue #19)
+- Updated TOC for 9.2.0 and 1.14.2
+
+v1.13.11:
+
+- Fixed totem bar dismissal for BC-Classic and Classic
+- Updated TOC for BC-Clasic
+
+v1.13.10:
+
+- Updated TOCs for 9.1.5 and 1.14.1
+
+v1.13.9:
+
+- Fixed FocusMana modules attempting to register invalid events in Classic builds.
+- Add support for multiple anima-charged combo points to display at once.
+- Update TOC for Classic 1.14.0
+
+v1.13.8.1:
+
+- Updated TOC for BC-Classic and Classic.
+
 v1.13.8:
 
 - Fixed Paladin GCD not functioning in BC-Classic.

embeds.xml

@@ -11,6 +11,7 @@
 	<Include file="libs\AceConsole-3.0\AceConsole-3.0.xml"/>
 	<Include file="libs\AceAddon-3.0\AceAddon-3.0.xml"/>
 	<Include file="libs\AceLocale-3.0\AceLocale-3.0.xml"/>
+	<Include file="libs\AceHook-3.0\AceHook-3.0.xml"/>
 	<Include file="libs\LibDogTag-3.0\lib.xml"/>
 	<Include file="libs\LibDogTag-Unit-3.0\lib.xml"/>
 	<Script file="libs\LibRangeCheck-2.0\LibRangeCheck-2.0.lua"/>

modules/ArcaneCharges.lua

@@ -61,6 +61,6 @@ end
 
 -- Load us up
 local _, unitClass = UnitClass("player")
-if (unitClass == "MAGE" and IceHUD.WowVer >= 70000) then
+if (unitClass == "MAGE" and MageArcaneChargesFrame) then
 	IceHUD.ArcaneCharges = ArcaneCharges:new()
 end

modules/CastBar.lua

@@ -3,6 +3,11 @@ local CastBar = IceCore_CreateClass(IceCastBar)
 
 local IceHUD = _G.IceHUD
 
+local CastingBarFrame = CastingBarFrame
+if not CastingBarFrame then
+	CastingBarFrame = PlayerCastingBarFrame
+end
+
 CastBar.prototype.spellCastSent = nil
 
 -- Constructor --
@@ -34,6 +39,9 @@ function CastBar.prototype:GetDefaultSettings()
 	settings["rangeColor"] = true
 	settings["bAllowExpand"] = false
 	settings["respectLagTolerance"] = true
+	settings["lockUpperTextAlpha"] = true
+	settings["lockLowerTextAlpha"] = true
+	settings["empowerStageTextDisplay"] = "TOPLINE"
 
 	return settings
 end
@@ -231,6 +239,7 @@ function CastBar.prototype:GetOptions()
 				end,
 				set = function(info, v)
 					self.moduleSettings.lockUpperTextAlpha = v
+					self.moduleSettings.lockLowerTextAlpha = v
 					self:Redraw()
 				end,
 				order = 13
@@ -303,7 +312,26 @@ function CastBar.prototype:GetOptions()
 				disabled = function()
 					return not self.moduleSettings.enabled
 				end,
-			}
+			},
+
+			empowerStageText = {
+				type = 'select',
+				name = L["Empower stage label display"],
+				desc = L["How to display the stage of an empowered spell"],
+				get = function()
+					return self.moduleSettings.empowerStageTextDisplay
+				end,
+				set = function(info, value)
+					self.moduleSettings.empowerStageTextDisplay = value
+				end,
+				values = { NONE = L["Don't show"], TOPLINE = L["After spell name"], BOTTOMLINE = L["Below spell name"] },
+				disabled = function()
+					return not self.moduleSettings.enabled
+				end,
+				hidden = function()
+					return not GetUnitEmpowerMinHoldTime
+				end,
+			},
 		}
 	}
 

modules/ClassPowerCounter.lua

@@ -101,7 +101,7 @@ function IceClassPowerCounter.prototype:GetOptions()
 	opts["displayMode"] = {
 		type = 'select',
 		name = L["Display mode"],
-		desc = L["Choose whether you'd like a graphical or numeric representation of the runes.\n\nNOTE: The color of 'Numeric' mode can be controlled by the HolyPowerNumeric color."],
+		desc = L["Choose whether you'd like a graphical or numeric representation of the runes."],
 		get = function(info)
 			return IceHUD:GetSelectValue(info, self.moduleSettings.runeMode)
 		end,
@@ -462,12 +462,19 @@ function IceClassPowerCounter.prototype:CheckValidSpec()
 	end
 end
 
+function IceClassPowerCounter.prototype:GetPowerEvent()
+	return IceHUD.UnitPowerEvent
+end
+
 function IceClassPowerCounter.prototype:DisplayCounter()
 	self:UnregisterEvent("PLAYER_LEVEL_UP")
 
-	self:RegisterEvent(IceHUD.UnitPowerEvent, "UpdateRunePower")
+	self:RegisterEvent(self:GetPowerEvent(), "UpdateRunePower")
 	self:RegisterEvent("UNIT_DISPLAYPOWER", "UpdateRunePower")
 	self:RegisterEvent("PLAYER_ENTERING_WORLD", "EnteringWorld")
+	if IceHUD.EventExistsUnitMaxPower then
+		self:RegisterEvent("UNIT_MAXPOWER", "UpdateRunePower")
+	end
 
 	if (self.moduleSettings.hideBlizz) then
 		self:HideBlizz()
@@ -490,15 +497,29 @@ function IceClassPowerCounter.prototype:EnteringWorld()
 end
 
 function IceClassPowerCounter.prototype:UpdateRunePower(event, arg1, arg2)
-	if event and (event == IceHUD.UnitPowerEvent or event == "UNIT_POWER_FREQUENT") and arg1 ~= "player" and arg1 ~= "vehicle" then
+	if event and (event == self:GetPowerEvent() or event == "UNIT_POWER_FREQUENT") and arg1 ~= "player" and arg1 ~= "vehicle" then
 		return
 	end
 
 	if IceHUD.WowVer >= 70000 then
 		local numMax = UnitPowerMax(self.unit, self.unitPower)
 		if numMax ~= self.numRunes then
+			local oldMax = self.numRunes
 			self.numRunes = numMax
 			self:CreateFrame()
+			self:SetDisplayMode()
+
+			for i=self.numRunes+1, oldMax do
+				if self.frame.graphical[i] then
+					self.frame.graphical[i]:Hide()
+				end
+			end
+			for i=oldMax+1, self.numRunes do
+				if self:GetRuneMode() ~= "Numeric" then
+					self.frame.graphical[i]:Show()
+				end
+				self:HideRune(i)
+			end
 		end
 	end
 
@@ -567,11 +588,7 @@ function IceClassPowerCounter.prototype:UpdateRunePower(event, arg1, arg2)
 					end
 				end
 			else
-				if self.moduleSettings.inactiveDisplayMode == "Darkened" then
+				self:HideRune(i)
-					self.frame.graphical[i].rune:SetVertexColor(0, 0, 0)
-				elseif self.moduleSettings.inactiveDisplayMode == "Hidden" then
-					self.frame.graphical[i]:Hide()
-				end
 			end
 		end
 	end
@@ -592,6 +609,19 @@ function IceClassPowerCounter.prototype:UpdateRunePower(event, arg1, arg2)
 	end
 end
 
+function IceClassPowerCounter.prototype:HideRune(i)
+	if self:GetRuneMode() == "Numeric" then
+		self.frame.graphical[i].Hide()
+		return
+	end
+
+	if self.moduleSettings.inactiveDisplayMode == "Darkened" then
+		self.frame.graphical[i].rune:SetVertexColor(0, 0, 0)
+	elseif self.moduleSettings.inactiveDisplayMode == "Hidden" then
+		self.frame.graphical[i]:Hide()
+	end
+end
+
 function IceClassPowerCounter.prototype:StartRunesFullAnimation()
 	if not self.AnimUpdate then
 		self.AnimUpdate = function() self:UpdateRuneAnimation() end
@@ -717,6 +747,9 @@ function IceClassPowerCounter.prototype:CreateRuneFrame()
 	for i=1, self.numRunes do
 		self:CreateRune(i)
 	end
+	for i=self.numRunes+1, #self.frame.graphical do
+		self.frame.graphical[i]:Hide()
+	end
 end
 
 function IceClassPowerCounter.prototype:CreateRune(i)
@@ -758,7 +791,13 @@ function IceClassPowerCounter.prototype:CreateRune(i)
 	end
 end
 
+function IceClassPowerCounter.prototype:SetupNewRune(rune)
+end
+
 function IceClassPowerCounter.prototype:SetupRuneTexture(rune)
+	if rune > #self.runeCoords then
+		self:SetupNewRune(rune)
+	end
 	if not rune or rune < 1 or rune > #self.runeCoords then
 		return
 	end

modules/ComboPoints.lua

@@ -13,13 +13,6 @@ if Enum and Enum.PowerType then
 	SPELL_POWER_COMBO_POINTS = Enum.PowerType.ComboPoints
 end
 
-local GetUnitChargedPowerPoints = GetUnitChargedPowerPoints
-if not GetUnitChargedPowerPoints then
-	GetUnitChargedPowerPoints = function()
-		return nil
-	end
-end
-
 -- Constructor --
 function ComboPoints.prototype:init()
 	ComboPoints.super.prototype.init(self, "ComboPoints")
@@ -28,7 +21,7 @@ function ComboPoints.prototype:init()
 	if AnticipationExists then
 		self:SetDefaultColor("AnticipationPoints", 1, 0, 1)
 	end
-	self:SetDefaultColor("KyrianAnimaComboPoint", 0.3137254901960784, 0.3725490196078432, 1)
+	self:SetDefaultColor("ChargedComboPoint", 0.3137254901960784, 0.3725490196078432, 1)
 	self.scalingEnabled = true
 end
 
@@ -229,25 +222,26 @@ function ComboPoints.prototype:GetOptions()
 		order = 35
 	}
 
-	if IceHUD.WowVer >= 90000 then
+	opts["bShowCharged"] = {
-		opts["bShowAnimaCharged"] = {
+		type = 'toggle',
-			type = 'toggle',
+		width = 'double',
-			width = 'double',
+		name = L["Show Charged points"],
-			name = L["Show Anima-charged points"],
+		desc = L["Whether or not to color a charged combo point a separate color. Set the ChargedComboPoint color to the color you would like it to be."],
-			desc = L["Whether or not to color an anima-charged combo point a separate color. Set the KyrianAnimaComboPoint color to the color you would like it to be."],
+		get = function()
-			get = function()
+			return self.moduleSettings.bShowCharged
-				return self.moduleSettings.bShowAnimaCharged
+		end,
-			end,
+		set = function(info, v)
-			set = function(info, v)
+			self.moduleSettings.bShowCharged = v
-				self.moduleSettings.bShowAnimaCharged = v
+			self:UpdateChargedComboPoints()
-				self:UpdateChargedComboPoints()
+		end,
-			end,
+		disabled = function()
-			disabled = function()
+			return not self.moduleSettings.enabled
-				return not self.moduleSettings.enabled
+		end,
-			end,
+		hidden = function()
-			order = 36
+			return not GetUnitChargedPowerPoints
-		}
+		end,
-	end
+		order = 36
+	}
 
 	return opts
 end
@@ -267,7 +261,7 @@ function ComboPoints.prototype:GetDefaultSettings()
 	defaults["comboGap"] = 0
 	defaults["showAnticipation"] = true
 	defaults["bShowWithNoTarget"] = true
-	defaults["bShowAnimaCharged"] = true
+	defaults["bShowCharged"] = true
 	return defaults
 end
 
@@ -291,7 +285,7 @@ function ComboPoints.prototype:Enable(core)
 			self:RegisterEvent("UNIT_COMBO_POINTS", "UpdateComboPoints")
 		else
 			self:RegisterEvent(IceHUD.UnitPowerEvent, "UpdateComboPoints")
-			if IceHUD.WowVer < 80000 then
+			if IceHUD.EventExistsUnitMaxPower then
 				self:RegisterEvent("UNIT_MAXPOWER", "UpdateMaxComboPoints")
 			end
 		end
@@ -307,7 +301,7 @@ function ComboPoints.prototype:Enable(core)
 		self:RegisterEvent("PLAYER_COMBO_POINTS", "UpdateComboPoints")
 	end
 
-	if IceHUD.WowVer >= 90000 then
+	if GetUnitChargedPowerPoints then
 		self:RegisterEvent("UNIT_POWER_POINT_CHARGE", "UpdateChargedComboPoints")
 	end
 
@@ -330,10 +324,11 @@ function ComboPoints.prototype:UpdateMaxComboPoints(event, unit, powerType)
 end
 
 function ComboPoints.prototype:UpdateChargedComboPoints()
-	local chargedPowerPoints = GetUnitChargedPowerPoints("player")
+	if GetUnitChargedPowerPoints then
-	self.chargedPowerPointIndex = chargedPowerPoints and chargedPowerPoints[1]
+		self.chargedPowerPoints = GetUnitChargedPowerPoints("player")
-	self:CreateComboFrame()
+		self:CreateComboFrame()
-	self:UpdateComboPoints()
+		self:UpdateComboPoints()
+	end
 end
 
 -- 'Protected' methods --------------------------------------------------------
@@ -445,8 +440,8 @@ function ComboPoints.prototype:CreateComboFrame(forceTextureUpdate)
 			g = g - ((1 / maxComboPoints)*i)
 		end
 
-		if i == self.chargedPowerPointIndex and self.moduleSettings.bShowAnimaCharged then
+		if self.moduleSettings.bShowCharged and self:IsChargedPoint(i) then
-			self.frame.graphical[i].texture:SetVertexColor(self:GetColor("KyrianAnimaComboPoint"))
+			self.frame.graphical[i].texture:SetVertexColor(self:GetColor("ChargedComboPoint"))
 		else
 			self.frame.graphical[i].texture:SetVertexColor(r, g, b)
 		end
@@ -494,6 +489,20 @@ function ComboPoints.prototype:CreateComboFrame(forceTextureUpdate)
 	end
 end
 
+function ComboPoints.prototype:IsChargedPoint(point)
+	if not self.chargedPowerPoints then
+		return false
+	end
+
+	for i=1, #self.chargedPowerPoints do
+		if self.chargedPowerPoints[i] == point then
+			return true
+		end
+	end
+
+	return false
+end
+
 function ComboPoints.prototype:UpdateComboPoints(...)
 	if select('#', ...) >= 3 and select(1, ...) == IceHUD.UnitPowerEvent and select(3, ...) ~= "COMBO_POINTS" then
 		return
@@ -502,7 +511,7 @@ function ComboPoints.prototype:UpdateComboPoints(...)
 	local points, anticipate, _
 	if IceHUD.IceCore:IsInConfigMode() then
 		points = self:GetMaxComboPoints()
-	elseif IceHUD.WowVer >= 30000 or IceHUD.WowClassic or IceHUD.WowClassicBC then
+	elseif UnitHasVehicleUI then
 		-- Parnic: apparently some fights have combo points while the player is in a vehicle?
 		local isInVehicle = UnitHasVehicleUI and UnitHasVehicleUI("player")
 		local checkUnit = isInVehicle and "vehicle" or "player"
@@ -518,7 +527,7 @@ function ComboPoints.prototype:UpdateComboPoints(...)
 			anticipate = 0
 		end
 	else
-		points = GetComboPoints("target")
+		points = GetComboPoints("player", "target")
 	end
 
 	points = points or 0
@@ -536,6 +545,9 @@ function ComboPoints.prototype:UpdateComboPoints(...)
 		self.frame.numeric:SetTextColor(r, g, b, 0.7)
 
 		local pointsText = tostring(points)
+		if self.moduleSettings.bShowCharged and self:IsChargedPoint(points) then
+			pointsText = pointsText.."@"
+		end
 		if anticipate > 0 then
 			pointsText = pointsText.."+"..tostring(anticipate)
 		end
@@ -580,7 +592,7 @@ do
 	function ComboPoints.prototype:CheckAnticipation(e, unit) -- UNIT_AURA handler
 		if UnitIsUnit(unit, "player") then
 			local _, _, _, newAntStacks
-			if IceHUD.WowVer < 80000 then
+			if IceHUD.SpellFunctionsReturnRank then
 				_, _, _, newAntStacks = UnitAura("player", GetSpellInfo(AnticipationSpellId))
 			else
 				_, _, newAntStacks = UnitAura("player", GetSpellInfo(AnticipationSpellId))

modules/ComboPointsBar.lua

@@ -6,18 +6,12 @@ if Enum and Enum.PowerType then
 	SPELL_POWER_COMBO_POINTS = Enum.PowerType.ComboPoints
 end
 
-local GetUnitChargedPowerPoints = GetUnitChargedPowerPoints
-if not GetUnitChargedPowerPoints then
-	GetUnitChargedPowerPoints = function()
-		return nil
-	end
-end
-
 function ComboPointsBar.prototype:init()
 	ComboPointsBar.super.prototype.init(self, "ComboPointsBar")
 
 	self:SetDefaultColor("ComboPointsBarMin", 1, 1, 0)
 	self:SetDefaultColor("ComboPointsBarMax", 0, 1, 0)
+	self:SetDefaultColor("ChargedComboPointBar", 0.3137254901960784, 0.3725490196078432, 1)
 
 	self.bTreatEmptyAsFull = true
 end
@@ -59,6 +53,26 @@ function ComboPointsBar.prototype:GetOptions()
 		end,
 	}
 
+	opts["bShowCharged"] = {
+		type = 'toggle',
+		width = 'double',
+		name = L["Show Charged points"],
+		desc = L["Whether or not to color a charged combo point a separate color and append an @ sign to the number. Set the ChargedComboPointBar color to the color you would like it to be."],
+		get = function()
+			return self.moduleSettings.bShowCharged
+		end,
+		set = function(info, v)
+			self.moduleSettings.bShowCharged = v
+			self:UpdateComboPoints()
+		end,
+		disabled = function()
+			return not self.moduleSettings.enabled
+		end,
+		hidden = function()
+			return not GetUnitChargedPowerPoints
+		end,
+	}
+
 	return opts
 end
 
@@ -69,6 +83,7 @@ function ComboPointsBar.prototype:GetDefaultSettings()
 	defaults.alwaysDisplay = false
 	defaults.desiredLerpTime = 0.05
 	defaults.bShowWithNoTarget = true
+	defaults.bShowCharged = true
 	return defaults
 end
 
@@ -90,17 +105,9 @@ function ComboPointsBar.prototype:Enable(core)
 		self:RegisterEvent("PLAYER_COMBO_POINTS", "UpdateComboPoints")
 	end
 
-	if IceHUD.WowVer >= 90000 then
+	if GetUnitChargedPowerPoints then
-		self:RegisterEvent("UNIT_POWER_POINT_CHARGE", "UpdateChargedComboPoints")
+		self:RegisterEvent("UNIT_POWER_POINT_CHARGE", "UpdateComboPoints")
 	end
-
-	self:UpdateChargedComboPoints()
-end
-
-function ComboPointsBar.prototype:UpdateChargedComboPoints()
-	local chargedPowerPoints = GetUnitChargedPowerPoints("player")
-	self.chargedPowerPointIndex = chargedPowerPoints and chargedPowerPoints[1]
-	self:UpdateComboPoints()
 end
 
 function ComboPointsBar.prototype:CreateFrame()
@@ -119,7 +126,7 @@ function ComboPointsBar.prototype:UpdateComboPoints(...)
 	local points
 	if IceHUD.IceCore:IsInConfigMode() then
 		points = UnitPowerMax("player", SPELL_POWER_COMBO_POINTS)
-	elseif IceHUD.WowVer >= 30000 or IceHUD.WowClassic or IceHUD.WowClassicBC then
+	elseif UnitHasVehicleUI then
 		-- Parnic: apparently some fights have combo points while the player is in a vehicle?
 		local isInVehicle = UnitHasVehicleUI and UnitHasVehicleUI("player")
 		local checkUnit = isInVehicle and "vehicle" or "player"
@@ -129,25 +136,53 @@ function ComboPointsBar.prototype:UpdateComboPoints(...)
 			points = UnitPower(checkUnit, SPELL_POWER_COMBO_POINTS)
 		end
 	else
-		points = GetComboPoints("target")
+		points = GetComboPoints("player", "target")
 	end
 
 	if (points == 0) then
 		points = nil
 	end
 
+	local isCharged = self:IsChargedPoint(points) and self.moduleSettings.bShowCharged
+
 	if points == nil or points == 0 or (not UnitExists("target") and not self.moduleSettings.bShowWithNoTarget) then
 		self:Show(self.moduleSettings.alwaysDisplay)
 		self:UpdateBar(0, "undef")
 	else
 		self:Show(true)
-		self:SetScaledColor(color, (points - 1) / 4.0, self.settings.colors["ComboPointsBarMax"], self.settings.colors["ComboPointsBarMin"])
+		if isCharged then
+			color.r, color.g, color.b = self:GetColor("ChargedComboPointBar")
+		else
+			self:SetScaledColor(color, (points - 1) / 4.0, self.settings.colors["ComboPointsBarMax"], self.settings.colors["ComboPointsBarMin"])
+		end
 		self:UpdateBar(points / UnitPowerMax("player", SPELL_POWER_COMBO_POINTS), "undef")
 		self.barFrame.bar:SetVertexColor(color.r, color.g, color.b, self.alpha)
 	end
 
-	self:SetBottomText1(points or "0")
+	local pointsText = tostring(points or 0)
-	self:SetBottomText2(self.chargedPowerPointIndex)
+	if isCharged then
+		pointsText = pointsText .. "@"
+	end
+	self:SetBottomText1(pointsText or "0")
+end
+
+function ComboPointsBar.prototype:IsChargedPoint(point)
+	if not GetUnitChargedPowerPoints or not point then
+		return false
+	end
+
+	local chargedPoints = GetUnitChargedPowerPoints("player")
+	if not chargedPoints then
+		return false
+	end
+
+	for i=1, #chargedPoints do
+		if chargedPoints[i] == point then
+			return true
+		end
+	end
+
+	return false
 end
 
 function ComboPointsBar.prototype:Update()

modules/CustomBar.lua

@@ -171,7 +171,7 @@ function IceCustomBar.prototype:CreateBar()
 	IceCustomBar.super.prototype.CreateBar(self)
 
 	if not self.barFrame.icon then
-		self.barFrame.icon = self.masterFrame:CreateTexture(nil, "LOW")
+		self.barFrame.icon = self.masterFrame:CreateTexture(nil, "BACKGROUND")
 		-- this cuts off the border around the buff icon
 		self.barFrame.icon:SetTexCoord(0.1, 0.9, 0.1, 0.9)
 		self.barFrame.icon:SetDrawLayer("OVERLAY")
@@ -329,16 +329,18 @@ function IceCustomBar.prototype:GetOptions()
 	opts["buffToTrack"] = {
 		type = 'input',
 		name = L["Aura to track"],
-		desc = L["Which buff/debuff this bar will be tracking.\n\nRemember to press ENTER after filling out this box with the name you want or it will not save."],
+		desc = function()
+			if IceHUD.GetPlayerAuraBySpellID then
+				return L["Which buff/debuff this bar will be tracking. Can use the name or spell id. \n\nRemember to press ENTER after filling out this box with the name you want or it will not save."]
+			else
+				return L["Which buff/debuff this bar will be tracking.\n\nRemember to press ENTER after filling out this box with the name you want or it will not save."]
+			end
+		end,
 		get = function()
 			return self.moduleSettings.buffToTrack
 		end,
 		set = function(info, v)
 			local orig = v
-			--Parnic: we now allow spell IDs to be used directly
-			--if tonumber(v) ~= nil then
-			--	v = GetSpellInfo(tonumber(v))
-			--end
 			if v == nil then
 				v = orig
 			end

modules/CustomCDBar.lua

@@ -131,7 +131,7 @@ function IceCustomCDBar.prototype:CreateBar()
 	IceCustomCDBar.super.prototype.CreateBar(self)
 
 	if not self.barFrame.icon then
-		self.barFrame.icon = self.masterFrame:CreateTexture(nil, "LOW")
+		self.barFrame.icon = self.masterFrame:CreateTexture(nil, "BACKGROUND")
 		-- this cuts off the border around the buff icon
 		self.barFrame.icon:SetTexCoord(0.1, 0.9, 0.1, 0.9)
 		self.barFrame.icon:SetDrawLayer("OVERLAY")

modules/CustomCounterBar.lua

@@ -277,7 +277,7 @@ function IceCustomCounterBar.prototype:CreateFrame()
 	IceCustomCounterBar.super.prototype.CreateFrame(self)
 
 	if not self.barFrame.icon then
-		self.barFrame.icon = self.masterFrame:CreateTexture(nil, "LOW")
+		self.barFrame.icon = self.masterFrame:CreateTexture(nil, "BACKGROUND")
 		self.barFrame.icon:SetTexCoord(0.1, 0.9, 0.1, 0.9)
 		self.barFrame.icon:SetDrawLayer("OVERLAY")
 		self.barFrame.icon:Hide()

modules/EclipseBar.lua

@@ -119,7 +119,7 @@ function EclipseBar.prototype:UpdateShown()
 
 	if form == MOONKIN_FORM or not form then
 		local PrimaryTalentTree = 0
-		if IceHUD.WowVer >= 50000 then
+		if GetSpecialization then
 			PrimaryTalentTree = GetSpecialization()
 		else
 			PrimaryTalentTree = GetPrimaryTalentTree()
@@ -190,6 +190,6 @@ function EclipseBar.prototype:MyOnUpdate()
 end
 
 local _, unitClass = UnitClass("player")
-if (unitClass == "DRUID" and IceHUD.WowVer >= 40000 and IceHUD.WowVer < 70000) then
+if (unitClass == "DRUID" and GetEclipseDirection) then
 	IceHUD.EclipseBar = EclipseBar:new()
 end

modules/EssencePower.lua

@@ -0,0 +1,74 @@
+local L = LibStub("AceLocale-3.0"):GetLocale("IceHUD", false)
+local EssencePower = IceCore_CreateClass(IceClassPowerCounter)
+
+local SPELL_POWER_ESSENCE = SPELL_POWER_ESSENCE
+if Enum and Enum.PowerType then
+	SPELL_POWER_ESSENCE = Enum.PowerType.Essence
+end
+
+function EssencePower.prototype:init()
+	EssencePower.super.prototype.init(self, "EssencePower")
+
+	self:SetDefaultColor("EssencePowerNumeric", 150, 150, 255)
+
+	self.unit = "player"
+	self.numericColor = "EssencePowerNumeric"
+	self.unitPower = SPELL_POWER_ESSENCE
+	self.minLevel = 0
+	self.bTreatEmptyAsFull = false
+	self.runeWidth = self.runeHeight
+end
+
+function EssencePower.prototype:Enable(core)
+	self.numRunes = UnitPowerMax(self.unit, SPELL_POWER_ESSENCE)
+	self.runeCoords = { }
+	for i = 1, self.numRunes do
+		self:SetupNewRune(i)
+	end
+
+	EssencePower.super.prototype.Enable(self, core)
+end
+
+function EssencePower.prototype:SetupNewRune(rune)
+    self.runeCoords[rune] = {0, 1, 0, 1}
+end
+
+function EssencePower.prototype:GetPowerEvent()
+	return "UNIT_POWER_FREQUENT"
+end
+
+function EssencePower.prototype:GetDefaultSettings()
+	local defaults =  EssencePower.super.prototype.GetDefaultSettings(self)
+
+	defaults["pulseWhenFull"] = false
+
+	return defaults
+end
+
+function EssencePower.prototype:GetOptions()
+	local opts = EssencePower.super.prototype.GetOptions(self)
+
+	opts.hideBlizz.hidden = function() return true end
+
+	return opts
+end
+
+function EssencePower.prototype:GetRuneAtlas(rune)
+	return "UF-Essence-Icon"
+end
+
+function EssencePower.prototype:GetShineAtlas(rune)
+	return "Mage-ArcaneCharge-SmallSpark"
+end
+
+function EssencePower.prototype:ShowBlizz()
+end
+
+function EssencePower.prototype:HideBlizz()
+end
+
+-- Load us up
+local _, unitClass = UnitClass("player")
+if unitClass == "EVOKER" then
+	IceHUD.EssencePower = EssencePower:new()
+end

modules/FocusMana.lua

@@ -39,9 +39,9 @@ end
 function FocusMana.prototype:Enable(core)
 	FocusMana.super.prototype.Enable(self, core)
 
-	if IceHUD.WowVer >= 40000 then
+	if not IceHUD.PerPowerEventsExist then
 		self:RegisterEvent(IceHUD.UnitPowerEvent, "UpdateEvent")
-		if IceHUD.WowVer < 80000 then
+		if IceHUD.EventExistsUnitMaxPower then
 			self:RegisterEvent("UNIT_MAXPOWER", "UpdateEvent")
 		end
 	else

modules/GlobalCoolDown.lua

@@ -286,7 +286,7 @@ function GlobalCoolDown.prototype:GetSpellId()
 			MONK=100780, -- jab
 		}
 
-		if IceHUD.WowClassicBC or IceHUD.WowClassic then
+		if not GetSpellInfo(defaultSpells["PALADIN"]) then
 			defaultSpells["PALADIN"] = 635
 		end
 

modules/HarmonyPower.lua

@@ -2,6 +2,9 @@ local L = LibStub("AceLocale-3.0"):GetLocale("IceHUD", false)
 local HarmonyPower = IceCore_CreateClass(IceClassPowerCounter)
 
 local SPELL_POWER_CHI = SPELL_POWER_CHI
+if not SPELL_POWER_CHI then
+	SPELL_POWER_CHI = SPELL_POWER_LIGHT_FORCE
+end
 if Enum and Enum.PowerType then
 	SPELL_POWER_CHI = Enum.PowerType.Chi
 end
@@ -23,11 +26,7 @@ function HarmonyPower.prototype:init()
 	}
 	self.numRunes = 4
 	self.numericColor = "ChiNumeric"
-	if IceHUD.WowVer >= 50100 then
+	self.unitPower = SPELL_POWER_CHI
-		self.unitPower = SPELL_POWER_CHI
-	else
-		self.unitPower = SPELL_POWER_LIGHT_FORCE
-	end
 	if IceHUD.WowVer >= 70000 then
 		self.requiredSpec = SPEC_MONK_WINDWALKER
 	end
@@ -117,6 +116,6 @@ end
 
 -- Load us up
 local _, unitClass = UnitClass("player")
-if (unitClass == "MONK" and IceHUD.WowVer >= 50000) then
+if unitClass == "MONK" then
 	IceHUD.HarmonyPower = HarmonyPower:new()
 end

modules/HolyPower.lua

@@ -38,7 +38,7 @@ function HolyPower.prototype:init()
 	self.bTreatEmptyAsFull = true
 	self.unit = "player"
 	self.numRunes = 5
-	if IceHUD.WowVer >= 50000 then
+	if HOLY_POWER_FULL then
 		self.numConsideredFull = HOLY_POWER_FULL
 	else
 		self.numConsideredFull = 3
@@ -134,7 +134,7 @@ end
 
 -- Load us up
 local _, unitClass = UnitClass("player")
-if (unitClass == "PALADIN" and IceHUD.WowVer >= 40000) then
+if (unitClass == "PALADIN" and (PaladinPowerBar or PaladinPowerBarFrame)) then
 	IceHUD.HolyPower = HolyPower:new()
 end
 

modules/PetHealth.lua

@@ -49,7 +49,7 @@ function PetHealth.prototype:Enable(core)
 	self:RegisterEvent("UNIT_PET", "CheckPet");
 
 	self:RegisterEvent("UNIT_HEALTH", "UpdateEvent")
-	if IceHUD.WowVer < 90000 then
+	if IceHUD.EventExistsUnitHealthFrequent then
 		self:RegisterEvent("UNIT_HEALTH_FREQUENT", "UpdateEvent")
 	end
 	self:RegisterEvent("UNIT_MAXHEALTH", "UpdateEvent")

modules/PlayerAlternatePower.lua

@@ -29,7 +29,7 @@ function IceHUDPlayerAlternatePower.prototype:Enable(core)
 	IceHUDPlayerAlternatePower.super.prototype.Enable(self, core)
 
 	self:RegisterEvent(IceHUD.UnitPowerEvent, "UpdateEvent")
-	if IceHUD.WowVer < 80000 then
+	if IceHUD.EventExistsUnitMaxPower then
 		self:RegisterEvent("UNIT_MAXPOWER", "UpdateEvent")
 	end
 	self:RegisterEvent("UNIT_POWER_BAR_SHOW", "PowerBarShow")

modules/PlayerHealth.lua

@@ -10,6 +10,7 @@ PlayerHealth.prototype.absorbAmount = 0
 local configMode = false
 local HealComm
 local incomingHealAmt = 0
+local groupEvent = IceHUD.EventExistsGroupRosterUpdate and "GROUP_ROSTER_UPDATE" or "PARTY_MEMBERS_CHANGED"
 
 -- Constructor --
 function PlayerHealth.prototype:init()
@@ -68,7 +69,7 @@ function PlayerHealth.prototype:Enable(core)
 	PlayerHealth.super.prototype.Enable(self, core)
 
 	self:RegisterEvent("UNIT_HEALTH", "UpdateEvent")
-	if IceHUD.WowVer < 90000 then
+	if IceHUD.EventExistsUnitHealthFrequent then
 		self:RegisterEvent("UNIT_HEALTH_FREQUENT", "UpdateEvent")
 	end
 	self:RegisterEvent("UNIT_MAXHEALTH", "UpdateEvent")
@@ -81,11 +82,7 @@ function PlayerHealth.prototype:Enable(core)
 	self:RegisterEvent("PLAYER_REGEN_DISABLED", "CheckCombat")
 
 	self:RegisterEvent("PARTY_LEADER_CHANGED", "CheckLeader")
-	if IceHUD.EventExistsGroupRosterUpdate then
+	self:RegisterEvent(groupEvent, "CheckLeader")
-		self:RegisterEvent("GROUP_ROSTER_UPDATE", "CheckLeader")
-	else
-		self:RegisterEvent("PARTY_MEMBERS_CHANGED", "CheckLeader")
-	end
 	if GetLFGProposal then
 		self:RegisterEvent("LFG_PROPOSAL_UPDATE", "CheckPartyRole")
 		self:RegisterEvent("LFG_PROPOSAL_FAILED", "CheckPartyRole")
@@ -105,7 +102,7 @@ function PlayerHealth.prototype:Enable(core)
 		self:RegisterEvent("UNIT_EXITED_VEHICLE", "ExitingVehicle")
 	end
 
-	if IceHUD.WowVer < 40000 then
+	if not IceHUD.SupportsHealPrediction then
 		HealComm = LibStub("LibHealComm-4.0", true)
 		if HealComm then
 			HealComm.RegisterCallback(self, "HealComm_HealStarted", function(event, casterGUID, spellID, spellType, endTime, ...) self:HealComm_HealEvent(event, casterGUID, spellID, spellType, endTime, ...) end)
@@ -169,7 +166,7 @@ function PlayerHealth.prototype:HealComm_ModifierChanged(event, guid)
 end
 
 function PlayerHealth.prototype:IncomingHealPrediction(event, unit)
-	if IceHUD.WowVer >= 40000 then
+	if IceHUD.SupportsHealPrediction then
 		if unit and unit ~= self.unit then
 			return
 		end
@@ -321,7 +318,7 @@ function PlayerHealth.prototype:GetOptions()
 			self:Update()
 		end,
 		disabled = function()
-			return not (self.moduleSettings.enabled and (IceHUD.WowVer >= 40000 or HealComm))
+			return not (self.moduleSettings.enabled and (IceHUD.SupportsHealPrediction or HealComm))
 		end,
 		order = 43.6
 	}
@@ -367,7 +364,7 @@ function PlayerHealth.prototype:GetOptions()
 			self:Update()
 		end,
 		disabled = function()
-			return not (self.moduleSettings.enabled and IceHUD.WowVer >= 70000)
+			return not (self.moduleSettings.enabled and UnitGetTotalAbsorbs)
 		end,
 		order = 43.8
 	}
@@ -942,7 +939,7 @@ function PlayerHealth.prototype:CreateHealBar()
 
 	self:UpdateBar(1, "undef")
 
-	if not self.moduleSettings.showIncomingHeals or (IceHUD.WowVer < 40000 and not HealComm) then
+	if not self.moduleSettings.showIncomingHeals or (not IceHUD.SupportsHealPrediction and not HealComm) then
 		self.healFrame.bar:Hide()
 	end
 end
@@ -954,7 +951,7 @@ function PlayerHealth.prototype:CreateAbsorbBar()
 
 	self:UpdateBar(1, "undef")
 
-	if not self.moduleSettings.showAbsorbs or UnitGetTotalAbsorbs == nil then
+	if not self.moduleSettings.showAbsorbs or not UnitGetTotalAbsorbs then
 		self.absorbFrame.bar:Hide()
 	end
 end
@@ -1094,7 +1091,7 @@ function PlayerHealth.prototype:CheckPartyRole()
 			proposalExists, id, typeID, subtypeID, name, texture, role, hasResponded, totalEncounters, completedEncounters, numMembers, isleader = GetLFGProposal()
 
 			local p = self.unit
-			if IceHUD.WowVer < 40000 then
+			if not IceHUD.UnitGroupRolesReturnsRoleString then
 				isTank, isHeal, isDPS = UnitGroupRolesAssigned(p)
 			else
 				local grpRole = UnitGroupRolesAssigned(p)
@@ -1407,15 +1404,56 @@ end
 
 
 function PlayerHealth.prototype:ShowBlizz()
-	PlayerFrame:Show()
+	PlayerFrame:SetParent(self.OriginalPlayerFrameParent or UIParent)
-	PlayerFrame:GetScript("OnLoad")(PlayerFrame)
 end
 
 
 function PlayerHealth.prototype:HideBlizz()
-	PlayerFrame:Hide()
+	if not self.PlayerFrameParent then
+		self.PlayerFrameParent = CreateFrame("Frame")
+		self.PlayerFrameParent:Hide()
+	end
 
-	PlayerFrame:UnregisterAllEvents()
+	self.OriginalPlayerFrameParent = PlayerFrame:GetParent()
+	PlayerFrame:SetParent(self.PlayerFrameParent)
+end
+
+local parents = {}
+local hide_frame = IceHUD:OutOfCombatWrapper(function(self) self:Hide() end)
+
+local function hook_frames(...)
+	for i = 1, select("#", ...) do
+		local frame = select(i, ...)
+		frame:UnregisterAllEvents()
+		if not IceHUD:IsHooked(frame, "OnShow") then
+			IceHUD:SecureHookScript(frame, "OnShow", hide_frame)
+		end
+		frame:Hide()
+	end
+end
+
+local function unhook_frame(frame)
+	if IceHUD:IsHooked(frame, "OnShow") then
+		IceHUD:Unhook(frame, "OnShow")
+		local parent = parents[frame]
+		if parent then
+			frame:SetParent(parent)
+		end
+	elseif IceHUD:IsHooked(frame, "Show") then
+		IceHUD:Unhook(frame, "Show")
+		IceHUD:Unhook(frame, "SetPoint")
+	end
+end
+
+local function unhook_frames(...)
+	for i = 1, select("#", ...) do
+		local frame = select(i, ...)
+		unhook_frame(frame)
+		local handler = frame:GetScript("OnLoad")
+		if handler then
+			handler(frame)
+		end
+	end
 end
 
 function PlayerHealth.prototype:HideBlizzardParty()
@@ -1424,37 +1462,34 @@ function PlayerHealth.prototype:HideBlizzardParty()
 		return
 	end
 
-	-- Both Pitbull 4 and Xperl use these exact code, so we use it too.
+	if PartyFrame then
-	for i = 1, MAX_PARTY_MEMBERS do
+		PartyFrame:Hide()
-		local party = _G['PartyMemberFrame'..i]
+		PartyFrame:UnregisterEvent(groupEvent)
-		party:UnregisterAllEvents()
+	else
-		party:Hide()
+		for i = 1, MAX_PARTY_MEMBERS do
-		party.Show = function() end
+			local frame = _G["PartyMemberFrame" .. i]
+			frame:SetAttribute("statehidden", true)
+			hook_frames(frame)
+		end
+		UIParent:UnregisterEvent(groupEvent)
 	end
-
-	UIParent:UnregisterEvent('RAID_ROSTER_UPDATE')
-
 end
 
 
 function PlayerHealth.prototype:ShowBlizzardParty()
-	-- Both Pitbull 4 and Xperl use these exact code, so we use it too.
+	if PartyFrame then
-	for i = 1, MAX_PARTY_MEMBERS do
+		PartyFrame:Show()
-		local frame = _G["PartyMemberFrame"..i]
+		PartyFrame:Layout()
-		if frame then
+		PartyFrame:RegisterEvent(groupEvent)
-			frame.Show = nil
+	else
-			frame:GetScript("OnLoad")(frame)
+		for i = 1, MAX_PARTY_MEMBERS do
-			if IceHUD.WowVer >= 50000 then
+			local frame = _G["PartyMemberFrame" .. i]
-				frame:GetScript("OnEvent")(frame, "GROUP_ROSTER_UPDATE")
+			frame:SetAttribute("statehidden", nil)
-			else
+			unhook_frames(frame)
-				frame:GetScript("OnEvent")(frame, "PARTY_MEMBERS_CHANGED")
+			frame:GetScript("OnEvent")(frame, groupEvent)
-			end
-
-			PartyMemberFrame_UpdateMember(frame)
 		end
+		UIParent:RegisterEvent(groupEvent)
 	end
-
-	UIParent:RegisterEvent("RAID_ROSTER_UPDATE")
 end
 
 --function PlayerHealth.prototype:ShowBlizzParty()

modules/PlayerInfo.lua

@@ -115,7 +115,9 @@ end
 
 function PlayerInfo.prototype:ShowBlizz()
 	BuffFrame:Show()
-	TemporaryEnchantFrame:Show()
+	if TemporaryEnchantFrame then
+		TemporaryEnchantFrame:Show()
+	end
 
 	BuffFrame:GetScript("OnLoad")(BuffFrame)
 end
@@ -123,7 +125,9 @@ end
 
 function PlayerInfo.prototype:HideBlizz()
 	BuffFrame:Hide()
-	TemporaryEnchantFrame:Hide()
+	if TemporaryEnchantFrame then
+		TemporaryEnchantFrame:Hide()
+	end
 
 	BuffFrame:UnregisterAllEvents()
 end

modules/PlayerMana.lua

@@ -203,7 +203,7 @@ function PlayerMana.prototype:CheckVehicle()
 end
 
 function PlayerMana.prototype:ShouldUseTicker()
-	return IceHUD.WowVer < 30000 or (IceHUD.WowVer < 70100 and not GetCVarBool("predictedPower"))
+	return IceHUD.WowVer < 30000 or (IceHUD.WowVer < 70100 and not GetCVarBool("predictedPower") and not IceHUD.WowClassicWrath)
 end
 
 function PlayerMana.prototype:SetupOnUpdate(enable)
@@ -353,13 +353,13 @@ function PlayerMana.prototype:Update(unit, powertype)
 			color = "PlayerRunicPower"
 		elseif (self.manaType == SPELL_POWER_FOCUS) then
 			color = "PlayerFocus"
-		elseif (IceHUD.WowVer >= 70000 and self.manaType == SPELL_POWER_INSANITY) then
+		elseif (self.manaType == SPELL_POWER_INSANITY) then
 			color = "PlayerInsanity"
-		elseif (IceHUD.WowVer >= 70000 and self.manaType == SPELL_POWER_FURY) then
+		elseif (self.manaType == SPELL_POWER_FURY) then
 			color = "PlayerFury"
-		elseif (IceHUD.WowVer >= 70000 and self.manaType == SPELL_POWER_MAELSTROM) then
+		elseif (self.manaType == SPELL_POWER_MAELSTROM) then
 			color = "PlayerMaelstrom"
-		elseif (IceHUD.WowVer >= 70000 and self.manaType == SPELL_POWER_PAIN) then
+		elseif (self.manaType == SPELL_POWER_PAIN) then
 			color = "PlayerPain"
 		end
 	end

modules/Resolve.lua

@@ -79,7 +79,7 @@ end
 
 -- Load for tanks only
 local _, unitClass = UnitClass("player")
-if ((unitClass == "DEATHKNIGHT" or unitClass == "DRUID" or unitClass == "PALADIN" or unitClass == "WARRIOR" or unitClass == "MONK")
+if (unitClass == "DEATHKNIGHT" or unitClass == "DRUID" or unitClass == "PALADIN" or unitClass == "WARRIOR" or unitClass == "MONK")
-	and IceHUD.WowVer >= 60000 and IceHUD.WowVer < 70000) then
+	and GetSpellInfo(RESOLVE_SPELL_ID) then
   IceHUD.Resolve = Resolve:new()
 end

modules/RollTheBones.lua

@@ -235,7 +235,7 @@ end
 function RollTheBones.prototype:GetBuffDuration(unitName, ids)
   local i = 1
   local buff, _, type, duration, endTime, spellId
-  if IceHUD.WowVer < 80000 then
+  if IceHUD.SpellFunctionsReturnRank then
     buff, _, _, _, type, duration, endTime, _, _, _, spellId = UnitBuff(unitName, i)
   else
     buff, _, _, type, duration, endTime, _, _, _, spellId = UnitBuff(unitName, i)
@@ -256,7 +256,7 @@ function RollTheBones.prototype:GetBuffDuration(unitName, ids)
 
     i = i + 1;
 
-    if IceHUD.WowVer < 80000 then
+    if IceHUD.SpellFunctionsReturnRank then
       buff, _, _, _, type, duration, endTime, _, _, _, spellId = UnitBuff(unitName, i)
     else
       buff, _, _, type, duration, endTime, _, _, _, spellId = UnitBuff(unitName, i)
@@ -274,7 +274,7 @@ end
 function RollTheBones.prototype:MyOnUpdate()
   RollTheBones.super.prototype.MyOnUpdate(self)
   if self.bUpdateRtb then
-    self:UpdateRollTheBones(nil, self.unit, true)
+    self:UpdateRollTheBones("internal", self.unit)
   end
   if self.target or self.moduleSettings.bShowWithNoTarget then
     self:UpdateDurationBar()
@@ -296,13 +296,14 @@ local function ShouldHide()
   return not HasSpell(193316)
 end
 
-function RollTheBones.prototype:UpdateRollTheBones(event, unit, fromUpdate)
+function RollTheBones.prototype:UpdateRollTheBones(event, unit)
   if unit and unit ~= self.unit then
     return
   end
 
   local now = GetTime()
   local remaining = nil
+  local fromUpdate = event == "internal"
 
   if not fromUpdate then
     rtbDuration, remaining, rtbCount = self:GetBuffDuration(self.unit, RtBSet)
@@ -376,14 +377,18 @@ function RollTheBones.prototype:UpdateDurationBar(event, unit)
   end
 
   local points = RTBGetComboPoints(self.unit)
-  -- check for Deeper Stratagem
+  if UnitPowerMax then
-  local _, _, _, DeeperStratagem = GetTalentInfoByID(sixComboPointsTalentID, GetActiveSpecGroup())
+    CurrMaxRtBDuration = self:GetMaxBuffTime(UnitPowerMax(self.unit, SPELL_POWER_COMBO_POINTS))
-
-  if DeeperStratagem then
-    -- first, set the cached upper limit of RtB duration
-    CurrMaxRtBDuration = self:GetMaxBuffTime(maxComboPoints + 1)
   else
-    CurrMaxRtBDuration = self:GetMaxBuffTime(maxComboPoints)
+    -- check for Deeper Stratagem
+    local _, _, _, DeeperStratagem = GetTalentInfoByID(sixComboPointsTalentID, GetActiveSpecGroup())
+    
+    if DeeperStratagem then
+      -- first, set the cached upper limit of RtB duration
+      CurrMaxRtBDuration = self:GetMaxBuffTime(maxComboPoints + 1)
+    else
+      CurrMaxRtBDuration = self:GetMaxBuffTime(maxComboPoints)
+    end
   end
 
   if event then

modules/Runes.lua

@@ -3,21 +3,23 @@ local Runes = IceCore_CreateClass(IceElement)
 
 local IceHUD = _G.IceHUD
 
+local RunesReturnedByMaxPower = IceHUD.WowVer >= 70000
+
 local CooldownFrame_SetTimer = CooldownFrame_SetTimer
 if CooldownFrame_Set then
 	CooldownFrame_SetTimer = CooldownFrame_Set
 end
 
 local RUNETYPE_BLOOD = 1;
-local RUNETYPE_DEATH = IceHUD.WowVer < 70300 and 2 or 3;
+local RUNETYPE_DEATH = IceHUD.DeathKnightUnholyFrostRunesSwapped and 2 or 3;
-local RUNETYPE_FROST = IceHUD.WowVer < 70300 and 3 or 2;
+local RUNETYPE_FROST = IceHUD.DeathKnightUnholyFrostRunesSwapped and 3 or 2;
 local RUNETYPE_CHROMATIC = 4;
 local RUNETYPE_LEGION = 5; -- not real, but makes for an easy update
 
 local GetRuneType = GetRuneType
 if IceHUD.WowVer >= 70000 and IceHUD.WowVer < 70300 then
 	GetRuneType = function() return RUNETYPE_LEGION end
-elseif IceHUD.WowVer >= 70300 then
+elseif IceHUD.WowVer >= 70300 and GetSpecialization then
 	GetRuneType = function() return GetSpecialization() end
 end
 
@@ -132,6 +134,9 @@ function Runes.prototype:GetOptions()
 		disabled = function()
 			return not self.moduleSettings.enabled
 		end,
+		hidden = function()
+			return not PlayerFrame_HideVehicleTexture
+		end,
 		order = 32
 	}
 
@@ -265,7 +270,7 @@ end
 
 -- OVERRIDE
 function Runes.prototype:Enable(core)
-	if IceHUD.WowVer >= 70000 then
+	if RunesReturnedByMaxPower then
 		self.numRunes = UnitPowerMax("player", SPELL_POWER_RUNES)
 	end
 
@@ -283,7 +288,9 @@ function Runes.prototype:Enable(core)
 		self:RegisterEvent("PLAYER_SPECIALIZATION_CHANGED", "UpdateRuneColors")
 	end
 	self:RegisterEvent("PLAYER_ENTERING_WORLD", "EnteringWorld")
-	self:RegisterEvent("UNIT_MAXPOWER", "CheckMaxNumRunes")
+	if RunesReturnedByMaxPower then
+		self:RegisterEvent("UNIT_MAXPOWER", "CheckMaxNumRunes")
+	end
 
 	if (self.moduleSettings.hideBlizz) then
 		self:HideBlizz()
@@ -503,7 +510,7 @@ function Runes.prototype:CreateRune(i, type, name)
 	-- create runes
 	if (not self.frame.graphical[i]) then
 		self.frame.graphical[i] = CreateFrame("Frame", nil, self.frame)
-		self.frame.graphical[i].rune = self.frame.graphical[i]:CreateTexture(nil, "LOW")
+		self.frame.graphical[i].rune = self.frame.graphical[i]:CreateTexture(nil, "BACKGROUND")
 		self.frame.graphical[i].rune:SetAllPoints(self.frame.graphical[i])
 		self.frame.graphical[i].cd = CreateFrame("Cooldown", nil, self.frame.graphical[i], "CooldownFrameTemplate")
 		self.frame.graphical[i].shine = self.frame.graphical[i]:CreateTexture(nil, "OVERLAY")
@@ -577,6 +584,10 @@ local function hook_playerframe()
 end
 
 function Runes.prototype:HideBlizz()
+	if not PlayerFrame_HideVehicleTexture then
+		return
+	end
+
 	RuneFrame:Hide()
 	RuneFrame:UnregisterAllEvents()
 

modules/Shards.lua

@@ -276,6 +276,6 @@ end
 
 -- Load us up
 local _, unitClass = UnitClass("player")
-if (unitClass == "WARLOCK" and IceHUD.WowVer >= 40000) then
+if (unitClass == "WARLOCK" and WarlockPowerFrame) then
 	IceHUD.ShardCounter = ShardCounter:new()
 end

modules/SliceAndDice.lua

@@ -42,6 +42,10 @@ elseif IceHUD.WowClassicBC then
 	impSndBonusPerRank = 0.15
 	impSndTalentPage = 2
 	impSndTalentIdx = 4
+elseif IceHUD.WowClassicWrath then
+	impSndBonusPerRank = 0.25
+	impSndTalentPage = 2
+	impSndTalentIdx = 23
 end
 
 local SPELL_POWER_COMBO_POINTS = SPELL_POWER_COMBO_POINTS
@@ -81,6 +85,10 @@ function SliceAndDice.prototype:Enable(core)
 		self:CheckMaxComboPoints()
 	end
 
+	if IceHUD.EventExistsUnitMaxPower then
+		self:RegisterEvent("UNIT_MAXPOWER", "CheckMaxComboPoints")
+	end
+
 	if not self.moduleSettings.alwaysFullAlpha then
 		self:Show(false)
 	else
@@ -91,8 +99,12 @@ function SliceAndDice.prototype:Enable(core)
 end
 
 function SliceAndDice.prototype:CheckMaxComboPoints()
-	local talentID, name, texture, selected, available, spellID, unknown, row, column, known, grantedByAura = GetTalentInfoByID(sixComboPointsTalentID, GetActiveSpecGroup())
+	if UnitPowerMax then
-	maxComboPoints = selected and 6 or 5
+		maxComboPoints = UnitPowerMax(self.unit, SPELL_POWER_COMBO_POINTS)
+	else
+		local talentID, name, texture, selected, available, spellID, unknown, row, column, known, grantedByAura = GetTalentInfoByID(sixComboPointsTalentID, GetActiveSpecGroup())
+		maxComboPoints = selected and 6 or 5
+	end
 end
 
 function SliceAndDice.prototype:Disable(core)
@@ -265,7 +277,7 @@ end
 function SliceAndDice.prototype:MyOnUpdate()
 	SliceAndDice.super.prototype.MyOnUpdate(self)
 	if self.bUpdateSnd then
-		self:UpdateSliceAndDice(nil, self.unit, true)
+		self:UpdateSliceAndDice("internal", self.unit)
 	end
 	if self.target or self.moduleSettings.bShowWithNoTarget then
 		self:UpdateDurationBar()
@@ -290,7 +302,7 @@ local function HasSpell(id)
 end
 
 local function ShouldHide()
-	if IceHUD.WowVer >= 90000 or IceHUD.WowClassicBC then
+	if IceHUD.WowVer >= 90000 or IceHUD.WowClassicBC or IceHUD.WowClassicWrath then
 		return false
 	end
 
@@ -300,13 +312,14 @@ local function ShouldHide()
 	-- with different durations
 end
 
-function SliceAndDice.prototype:UpdateSliceAndDice(event, unit, fromUpdate)
+function SliceAndDice.prototype:UpdateSliceAndDice(event, unit)
 	if unit and unit ~= self.unit then
 		return
 	end
 
 	local now = GetTime()
 	local remaining = nil
+	local fromUpdate = event == "internal"
 
 	if not fromUpdate or IceHUD.WowVer < 30000 then
 		sndDuration, remaining = self:GetBuffDuration(self.unit, sndBuffName)
@@ -411,13 +424,11 @@ function SliceAndDice.prototype:UpdateDurationBar(event, unit)
 end
 
 function SliceAndDice.prototype:GetMaxBuffTime(numComboPoints)
-	local maxduration
-
 	if numComboPoints == 0 then
 		return 0
 	end
 
-	maxduration = baseTime + ((numComboPoints - 1) * gapPerComboPoint)
+	local maxduration = baseTime + ((numComboPoints - 1) * gapPerComboPoint)
 
 	if self:HasNetherbladeBonus() then
 		maxduration = maxduration + netherbladeBonus

modules/Stagger.lua

@@ -185,7 +185,7 @@ function StaggerBar.prototype:GetDebuffInfo()
 	local staggerLevel = 1
 
 	for i = 1, IceCore.BuffLimit do
-		local debuffID = select(IceHUD.WowVer < 80000 and 11 or 10, UnitDebuff(self.unit, i))
+		local debuffID = select(IceHUD.SpellFunctionsReturnRank and 11 or 10, UnitDebuff(self.unit, i))
 
 		if debuffID == LightID or debuffID == ModerateID or debuffID == HeavyID then
 			local spellName = UnitDebuff(self.unit, i)
@@ -236,7 +236,7 @@ end
 
 function StaggerBar.prototype:GetDebuffDuration(unitName, buffId)
 	local name, _, duration, endTime
-	if IceHUD.WowVer < 80000 then
+	if IceHUD.SpellFunctionsReturnRank then
 		name, _, _, _, _, duration, endTime = UnitDebuff(unitName, buffName)
 	else
 		for i = 1, IceCore.BuffLimit do

modules/TargetCC.lua

@@ -7,7 +7,7 @@ TargetCC.prototype.debuffRemaining = 0
 TargetCC.prototype.debuffDuration = 0
 
 local GetNumPartyMembers, GetNumRaidMembers = GetNumPartyMembers, GetNumRaidMembers
-if IceHUD.WowVer >= 50000 then
+if GetNumGroupMembers then
 	GetNumPartyMembers = GetNumGroupMembers
 	GetNumRaidMembers = GetNumGroupMembers
 end
@@ -375,11 +375,12 @@ end
 
 function TargetCC.prototype:MyOnUpdate()
 	TargetCC.super.prototype.MyOnUpdate(self)
-	self:UpdateTargetDebuffs(nil, self.unit, true)
+	self:UpdateTargetDebuffs("internal", self.unit)
 end
 
-function TargetCC.prototype:UpdateTargetDebuffs(event, unit, isUpdate)
+function TargetCC.prototype:UpdateTargetDebuffs(event, unit)
 	local name, duration, remaining
+	local isUpdate = event == "internal"
 
 	if not isUpdate or not self.lastUpdateTime then
 		self.debuffName, self.debuffDuration, self.debuffRemaining = self:GetMaxDebuffDuration(self.unit, self.debuffList)

modules/TargetCast.lua

@@ -15,7 +15,7 @@ end
 function TargetCast.prototype:Enable(core)
 	TargetCast.super.prototype.Enable(self, core)
 
-	if IceHUD.WowVer >= 30200 then
+	if IceHUD.EventExistsSpellcastInterruptible then
 		self:RegisterEvent("UNIT_SPELLCAST_INTERRUPTIBLE", "SpellCastInterruptible")
 		self:RegisterEvent("UNIT_SPELLCAST_NOT_INTERRUPTIBLE", "SpellCastNotInterruptible")
 	end
@@ -183,11 +183,11 @@ function TargetCast.prototype:StartBar(action, message)
 	local spell, notInterruptible
 	if UnitCastingInfo then
 		spell = UnitCastingInfo(self.unit)
-		notInterruptible = select(IceHUD.WowVer < 80000 and 9 or 8, UnitCastingInfo(self.unit))
+		notInterruptible = select(IceHUD.SpellFunctionsReturnRank and 9 or 8, UnitCastingInfo(self.unit))
 	end
 	if UnitChannelInfo and not spell then
 		spell = UnitChannelInfo(self.unit)
-		notInterruptible = select(IceHUD.WowVer < 80000 and 8 or 7, UnitChannelInfo(self.unit))
+		notInterruptible = select(IceHUD.SpellFunctionsReturnRank and 8 or 7, UnitChannelInfo(self.unit))
 
 		if not spell then
 			return

modules/TargetHealth.lua

@@ -642,6 +642,10 @@ function IceTargetHealth.prototype:Enable(core)
 			self:RegisterEvent("LFG_PROPOSAL_FAILED", "CheckPartyRole")
 			self:RegisterEvent("LFG_ROLE_UPDATE", "CheckPartyRole")
 		end
+
+		if IceHUD.ShouldUpdateTargetHealthEveryTick and self.unit == "target" then
+			self.frame:SetScript("OnUpdate", function() self:Update(self.unit) end)
+		end
 	end
 
 	if (self.moduleSettings.hideBlizz) then
@@ -659,6 +663,10 @@ function IceTargetHealth.prototype:Disable(core)
 
 	UnregisterUnitWatch(self.frame)
 
+	if self.registerEvents and IceHUD.ShouldUpdateTargetHealthEveryTick and self.unit == "target" then
+		self.frame:SetScript("OnUpdate", nil)
+	end
+
 	if self.moduleSettings.hideBlizz then
 		self:ShowBlizz()
 	end
@@ -1057,20 +1065,25 @@ end
 
 
 function IceTargetHealth.prototype:ShowBlizz()
-	TargetFrame:Show()
+	TargetFrame:SetParent(self.OriginalTargetFrameParent or UIParent)
-	TargetFrame:GetScript("OnLoad")(TargetFrame)
+	ComboFrame:SetParent(self.OriginalComboFrameParent or UIParent)
-
-	ComboFrame:Show()
-	ComboFrame:GetScript("OnLoad")(ComboFrame)
 end
 
 
 function IceTargetHealth.prototype:HideBlizz()
-	TargetFrame:Hide()
+	if not self.TargetFrameParent then
-	TargetFrame:UnregisterAllEvents()
+		self.TargetFrameParent = CreateFrame("Frame")
+		self.TargetFrameParent:Hide()
+	end
+	if not self.ComboFrameParent then
+		self.ComboFrameParent = CreateFrame("Frame")
+		self.ComboFrameParent:Hide()
+	end
 
-	ComboFrame:Hide()
+	self.OriginalTargetFrameParent = TargetFrame:GetParent()
-	ComboFrame:UnregisterAllEvents()
+	TargetFrame:SetParent(self.TargetFrameParent)
+	self.OriginalComboFrameParent = ComboFrame:GetParent()
+	ComboFrame:SetParent(self.ComboFrameParent)
 end
 
 function IceTargetHealth.prototype:UpdateBar(scale, color, alpha)
@@ -1095,7 +1108,7 @@ function IceTargetHealth.prototype:CheckPartyRole()
 			proposalExists, id, typeID, subtypeID, name, texture, role, hasResponded, totalEncounters, completedEncounters, numMembers, isleader = GetLFGProposal()
 
 			local p = self.unit
-			if IceHUD.WowVer < 40000 then
+			if not IceHUD.UnitGroupRolesReturnsRoleString then
 				isTank, isHeal, isDPS = UnitGroupRolesAssigned(p)
 			else
 				local grpRole = UnitGroupRolesAssigned(p)

modules/TargetInvuln.lua

@@ -7,7 +7,7 @@ TargetInvuln.prototype.buffRemaining = 0
 TargetInvuln.prototype.buffDuration = 0
 
 local GetNumPartyMembers, GetNumRaidMembers = GetNumPartyMembers, GetNumRaidMembers
-if IceHUD.WowVer >= 50000 then
+if GetNumGroupMembers then
 	GetNumPartyMembers = GetNumGroupMembers
 	GetNumRaidMembers = GetNumGroupMembers
 end
@@ -191,13 +191,14 @@ end
 
 function TargetInvuln.prototype:MyOnUpdate()
 	TargetInvuln.super.prototype.MyOnUpdate(self)
-	self:UpdateTargetBuffs(nil, self.unit, true)
+	self:UpdateTargetBuffs("internal", self.unit)
 end
 
-function TargetInvuln.prototype:UpdateTargetBuffs(event, unit, isUpdate)
+function TargetInvuln.prototype:UpdateTargetBuffs(event, unit)
 	local name, duration, remaining
+	local isUpdate = event == "internal"
 
-	if not isUpdate then
+	if not isUpdate or not self.lastUpdateTime then
 		self.buffName, self.buffDuration, self.buffRemaining = self:GetMaxbuffDuration(self.unit, self.buffList)
 	else
 		self.buffRemaining = math.max(0, self.buffRemaining - (GetTime() - self.lastUpdateTime))

modules/TargetMana.lua

@@ -83,7 +83,7 @@ function IceTargetMana.prototype:Enable(core)
 			self:RegisterEvent("UNIT_FOCUS", "UpdateEvent")
 
 			-- DK rune stuff
-			if IceHUD.WowVer >= 30000 then
+			if SPELL_POWER_RUNIC_POWER then
 				self:RegisterEvent("UNIT_RUNIC_POWER", "UpdateEvent")
 				self:RegisterEvent("UNIT_MAXRUNIC_POWER", "UpdateEvent")
 			end
@@ -135,13 +135,13 @@ function IceTargetMana.prototype:Update(unit)
 			self.color = "TargetEnergy"
 		elseif (manaType == SPELL_POWER_RUNIC_POWER) then
 			self.color = "TargetRunicPower"
-		elseif (IceHUD.WowVer >= 70000 and manaType == SPELL_POWER_INSANITY) then
+		elseif (manaType == SPELL_POWER_INSANITY) then
 			self.color = "TargetInsanity"
-		elseif (IceHUD.WowVer >= 70000 and manaType == SPELL_POWER_FURY) then
+		elseif (manaType == SPELL_POWER_FURY) then
 			self.color = "TargetFury"
-		elseif (IceHUD.WowVer >= 70000 and manaType == SPELL_POWER_MAELSTROM) then
+		elseif (manaType == SPELL_POWER_MAELSTROM) then
 			self.color = "TargetMaelstrom"
-		elseif (IceHUD.WowVer >= 70000 and manaType == SPELL_POWER_PAIN) then
+		elseif (manaType == SPELL_POWER_PAIN) then
 			self.color = "TargetPain"
 		end
 

modules/Totems.lua

@@ -339,16 +339,14 @@ function Totems.prototype:CreateTotem(i, name)
 		return
 	end
 	local haveTotem, name, startTime, duration, icon = GetTotemInfo(i)
-	local bWasNewFrame = false
 	if (not self.frame.graphical[i]) then
 		self.frame.graphical[i] = CreateFrame("Frame", nil, self.frame)
-		self.frame.graphical[i].totem = self.frame.graphical[i]:CreateTexture(nil, "LOW")
+		self.frame.graphical[i].totem = self.frame.graphical[i]:CreateTexture(nil, "BACKGROUND")
 		self.frame.graphical[i].cd = CreateFrame("Cooldown", nil, self.frame.graphical[i], "CooldownFrameTemplate")
 		self.frame.graphical[i].shine = self.frame.graphical[i]:CreateTexture(nil, "OVERLAY")
 
 		self.frame.graphical[i].totem:SetTexture(icon)
 		self.frame.graphical[i].totem:SetAllPoints(self.frame.graphical[i])
-		bWasNewFrame = true
 	end
 
 	self.frame.graphical[i]:SetFrameStrata("BACKGROUND")
@@ -405,18 +403,19 @@ function Totems.prototype:CreateTotem(i, name)
 		self.frame.graphical[i]:EnableMouse(true)
 		self.frame.graphical[i]:SetScript("OnEnter", self.graphicalOnEnter)
 		self.frame.graphical[i]:SetScript("OnLeave", self.graphicalOnLeave)
+		if IceHUD.CanHookDestroyTotem then
+			self.frame.graphical[i]:SetScript("OnMouseUp", self.graphicalOnMouseUp)
+		end
 	else
 		self.frame.graphical[i]:EnableMouse(false)
 		self.frame.graphical[i]:SetScript("OnEnter", nil)
 		self.frame.graphical[i]:SetScript("OnLeave", nil)
+		if IceHUD.CanHookDestroyTotem then
+			self.frame.graphical[i]:SetScript("OnMouseUp", nil)
+		end
 	end
 	self.frame.graphical[i].slot = i
 	self.frame.graphical[i].name = name
-
-	-- it looks like HookScript will continue to add handlers every time instead of replacing them like SetScript
-	if (bWasNewFrame) then
-		--self.frame.graphical[i]:HookScript("OnMouseUp", self.graphicalOnMouseUp)
-	end
 end
 
 -- Load us up

this_version.md

@@ -1,5 +1,30 @@
 # Changelog
 
-v1.13.8:
+v1.14.5:
 
-- Fixed Paladin GCD not functioning in BC-Classic.
+- Fix castbar flashing. There are controls on the player castbar module for flashing when a spell succeeds or fails, and separate controls for flashing when an instant cast completes. Those were broken, but now work again.
+- Add "@" after the number when the Combo Points module is in Numeric mode, "Show Charged points" is enabled, and the current combo point is charged.
+- Fix Charged point support in the ComboPointsBar module.
+
+v1.14.4:
+
+- Update TOC for 10.0.2
+
+v1.14.3:
+
+- Add Spell ID support for aura tracking.
+- Add Evoker support.
+- Add Empowered Casting (hold-to-cast levels) support.
+
+v1.14.2:
+
+- Fix CC and Invuln modules not showing immediately when they should.
+
+v1.14.1:
+
+- Fix Hide Party feature on pre-10.0 clients.
+
+v1.14.0:
+
+- 10.0 compatibility
+- Renamed Anima Charged combo points to Charged, and removed specific references to Kyrian.